Merge pull request #116 from vektah/extends-missing

Allow extending types that haven't been declared
vektah · Feb 8, 2020 · 4684b46 · 4684b46
2 parents c07bed4 + 3eaa5ac
commit 4684b46
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/validator/schema.go b/validator/schema.go
@@ -37,7 +37,12 @@ func ValidateSchemaDocument(ast *SchemaDocument) (*Schema, *gqlerror.Error) {
 	for _, ext := range ast.Extensions {
 		def := schema.Types[ext.Name]
 		if def == nil {
-			return nil, gqlerror.ErrorPosf(ext.Position, "Cannot extend type %s because it does not exist.", ext.Name)
+			schema.Types[ext.Name] = &Definition{
+				Kind:        ext.Kind,
+				Name:        ext.Name,
+				Position: ext.Position,
+			}
+			def = schema.Types[ext.Name]
 		}
 
 		if def.Kind != ext.Kind {

diff --git a/validator/schema_test.yml b/validator/schema_test.yml
@@ -419,14 +419,12 @@ unions:
       locations: [{line: 1, column: 7}]
 
 type extensions:
-  - name: cannot extend non existant types
+  - name: can extend non existant types
     input: |
       extend type A {
         name: String
       }
-    error:
-      message: "Cannot extend type A because it does not exist."
-      locations: [{line: 1, column: 13}]
+
 
   - name: cannot extend incorret type existant types
     input: |