Merge pull request #122 from vincenteasy/121/fix-wrong-validation-on-…

…input-with-default-value Fix wrong validation on input field with default value
vektah · Oct 22, 2020 · df51733 · df51733
2 parents 0f583e8 + 52681f0
commit df51733
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/validator/testdata/vars.graphql b/validator/testdata/vars.graphql
@@ -19,6 +19,7 @@ input InputType {
     nullName: String
     nullEmbedded: Embedded
     enum: Enum
+    defaultName: String! = "defaultFoo"
 }
 
 input Embedded {

diff --git a/validator/vars.go b/validator/vars.go
@@ -185,6 +185,13 @@ func (v *varValidator) validateVarType(typ *ast.Type, val reflect.Value) *gqlerr
 			field := val.MapIndex(reflect.ValueOf(fieldDef.Name))
 			if !field.IsValid() {
 				if fieldDef.Type.NonNull {
+					if fieldDef.DefaultValue != nil {
+						var err error
+						_, err = fieldDef.DefaultValue.Value(nil)
+						if err == nil {
+							continue
+						}
+					}
 					return gqlerror.ErrorPathf(v.path, "must be defined")
 				}
 				continue