Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatter package #103

Merged
merged 12 commits into from
Jul 15, 2019
Merged

Add formatter package #103

merged 12 commits into from
Jul 15, 2019

Conversation

vvakame
Copy link
Collaborator

@vvakame vvakame commented Jun 14, 2019

Motivation

I'm trying to genarate gRPC <-> gqlgen glue code. (in vvakame/til#31)
I wanna generate 1. part of resolver implementation, 2. part of schema.graphql from .proto file.

genarate schema.graphql is not easy.
but construct ast/SchemaDocument is easy (maybe...).

Goal

  • convert AST to schema or query text

Non-goal

  • configurable
  • re-emit same as original source order
  • add extra new package
    • e.g. internal/walker that shared with validator

#101 is same request? 👀

@vvakame vvakame requested a review from vektah June 14, 2019 07:10
@coveralls
Copy link

coveralls commented Jun 14, 2019

Coverage Status

Coverage increased (+0.9%) to 92.298% when pulling 9f6da28 on vvakame:feat-formatter into 05741cd on vektah:master.

@vvakame
Copy link
Collaborator Author

vvakame commented Jun 14, 2019

🤔 My test code covered all statement (without return err) more than once...

go.mod Outdated Show resolved Hide resolved
formatter/formatter_test.go Outdated Show resolved Hide resolved
formatter/formatter.go Outdated Show resolved Hide resolved
formatter/formatter.go Outdated Show resolved Hide resolved
@vvakame vvakame requested a review from vektah June 26, 2019 04:23
@vektah vektah merged commit 3d8f0da into vektah:master Jul 15, 2019
@vektah vektah mentioned this pull request Jul 15, 2019
@vvakame vvakame deleted the feat-formatter branch July 15, 2019 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants