introduce ast.Path type #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vektah
reviewed
Feb 7, 2020
| case PathIndex: | ||
| str.WriteString(fmt.Sprintf("[%d]", v)) | ||
| case PathName: | ||
| if i != 0 { |
There was a problem hiding this comment.
bug if path starts with number?
eg .[0].foo.bar?
There was a problem hiding this comment.
expected is [0].foo.bar ? 🤔
I think number is not coming at head of path.
so, this PR can't validate element value.
- don't place number at head
- don't contains
nilvalue
vektah
approved these changes
Feb 7, 2020
vektah
requested changes
Feb 7, 2020
vvakame
added a commit
to 99designs/gqlgen
that referenced
this pull request
Feb 9, 2020
2 tasks
|
@vektah 99designs/gqlgen#1022 I tried to apply this patch to gqlgen.
New code is developer-friendly. prevention of runtime errors may be small 🤔 |
vvakame
added a commit
to 99designs/gqlgen
that referenced
this pull request
Feb 9, 2020
vektah
approved these changes
Feb 9, 2020
|
@vektah thanks! please ping me when add new tags for this repo. I'll update gqlgen side. |
vektah
added a commit
to 99designs/gqlgen
that referenced
this pull request
Feb 16, 2020
example about apply vektah/gqlparser#117
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
example about apply vektah/gqlparser#117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a Breaking Change.
but I think it's better to do it before gqlgen becomes 1.0.0.
Motivation.
[]interface{}is unclear typing.I read source code that what's contains in Path values often.
and, I want to use string format path value.
It uses for collect gqlgen metrics & logs to OpenCensus / Stackdriver Logging.