-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support intermediate interface #180
Conversation
@StevenACoffman Could you handle this PR? |
Have you already figured out what is necessary to change in gqlgen to support this? We had to reverta PR here recently because it broke gqlgen and I'd like to avoid repeating that. What is different in your change here from the changes in #169 : https://github.com/vektah/gqlparser/pull/169/files @wilhelmeek FYI |
@StevenACoffman I understand the case (maybe this one?). I believe the broken is caused by updated introspection.
These are the same PR. but another one is draft. If #169 is open, I'm OK to merge it and close this one (but I want this change as soon as possible 🙏 ) |
In addition, If I were to mention this issue, We would have to modify the - func (t *Type) InputFields() []InputValue {
+ func (t *Type) InputFields(includeDeprecated bool) []InputValue {
if t.def == nil || t.def.Kind != ast.InputObject {
return []InputValue{}
}
res := []InputValue{}
for _, f := range t.def.Fields {
+ if !includeDeprecated && f.Directives.ForName("deprecated") != nil {
+ continue
+ }
res = append(res, InputValue{
Name: f.Name,
Description: f.Description,
Type: WrapTypeFromType(t.schema, f.Type),
DefaultValue: defaultValue(f.DefaultValue),
})
}
return res
} |
@Code-Hex I rebased and merged #169 since it preserves the original author for attribution. However, when I then rebased #178 the tests continued to fail. I wasn't able to push the rebased version back up to @vvakame fork, so I created #181 to demonstrate the continued failure. Unfortunately, I'm not going to be able to spend more time looking into this at present, so if anyone else can sort it out, I would welcome a PR that passed the tests. |
@StevenACoffman Thank you for merged! Sure. Because this is necessary a part of process.
Thank you |
@StevenACoffman Could you release for merged one? You said
If so, We have to do "small change, small release". Thanks. |
#169 is inactive. I created a new one
required also: #178