Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added AddTypes helper to ast.Schema #215

Merged
merged 1 commit into from
Apr 10, 2022
Merged

feat: added AddTypes helper to ast.Schema #215

merged 1 commit into from
Apr 10, 2022

Conversation

giautm
Copy link
Contributor

@giautm giautm commented Apr 10, 2022

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 92.615% when pulling cae87e0 on giautm:patch-1 into 1f5572c on vektah:master.

@giautm
Copy link
Contributor Author

giautm commented Apr 10, 2022

This helper allows me to remove the insertDefinitions function from entgql. And refactor the internal to be more clean, get-out of types map[string]*ast.Definition

https://github.com/ent/contrib/blob/ebaf866000895bd91df5f1dbf53895bd64430717/entgql/schema.go#L653-L657

cc: @a8m

a8m
a8m approved these changes Apr 10, 2022
View reviewed changes
Copy link
Contributor

@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@StevenACoffman StevenACoffman merged commit db38a01 into vektah:master Apr 10, 2022
@StevenACoffman
Copy link
Collaborator

Thanks!

@giautm giautm deleted the patch-1 branch April 10, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a8m a8m a8m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@giautm @coveralls @StevenACoffman @a8m