Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report error about null value for any type that cannot be null, not for only built-in #222

Merged
merged 2 commits into from
May 26, 2022

Conversation

atzedus
Copy link
Contributor

@atzedus atzedus commented May 25, 2022

Validator skip any checks when validating custom scalar types.
But if any type marked as not nullable ('Time!' for example) it doesn't matter what type is it custom or basic when provided 'null' value.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 92.287% when pulling 2e01e2d on atzedus:master into d3d9eb0 on vektah:master.

@StevenACoffman StevenACoffman merged commit 6519773 into vektah:master May 26, 2022
@StevenACoffman
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants