Add WrapIfUnwrapped and other Lint fixes #275
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reviewing other PRs, I noticed some linter suggestions.
One of them was that we didn't wrap errors from external packages here:
It was tedious to look through all the possible error originations to see if they could be wrapped so I added a convenience "WrapIfUnwrapped" and just called that.
There were some other linter issues where we reused package names as variable names such that it was a bit confusing, so I renamed those.
Signed-off-by: Steve Coffman [email protected]