Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure generated imports doesn't start with digit #806

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Ensure generated imports doesn't start with digit #806

merged 1 commit into from
Aug 16, 2024

Conversation

leitzler
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Version of Go used when building/testing:

  • tip

How Has This Been Tested?

Updated unit tests.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • [-] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@LandonTClipp
Copy link
Collaborator

Thanks for the fix. I'm a bit confused as to why mockery is doing this in the first place but regardless it seems like this will work. Will merge once the checks pass.

@LandonTClipp
Copy link
Collaborator

Look like github.com/vektra/mockery/v2/pkg/fixtures/12345678/http was not actually included in this PR?

@leitzler
Copy link
Contributor Author

Ops, apologies, just pushed it too.

I'm a bit confused as to why mockery is doing this in the first place [..]

Yeah, me too. Feels like just adding a digit at the end would be enough. But I thought this fix was least intrusive as it won't change the existing behaviour 😅

@LandonTClipp LandonTClipp merged commit 910874a into vektra:master Aug 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Same name imports with numbers in the directory structure generates invalid imports
2 participants