Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unreachable links in docs #830

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

alexandear
Copy link
Contributor

Description

The PR fixes unreachable links in the documentation.

Details

❯ linkchecker --no-warnings https://vektra.github.io/mockery/latest/
INFO linkcheck.cmdline 2024-10-21 18:29:27,168 MainThread Checking intern URLs only; use --check-extern to check extern URLs.
LinkChecker 10.4.0
Copyright (C) 2000-2016 Bastian Kleineidam, 2010-2023 LinkChecker Authors
LinkChecker comes with ABSOLUTELY NO WARRANTY!
This is free software, and you are welcome to redistribute it under
certain conditions. Look at the file `COPYING' within this distribution.
Read the documentation at https://linkchecker.github.io/linkchecker/
Write comments and bugs to https://github.com/linkchecker/linkchecker/issues

Start checking at 2024-10-21 18:29:27+003
10 threads active,    20 links queued,   66 links in  96 URLs checked, runtime 1 seconds
10 threads active,     8 links queued,  131 links in 149 URLs checked, runtime 6 seconds
 5 threads active,     0 links queued,  144 links in 149 URLs checked, runtime 11 seconds

URL        `(https://taskfile.dev/)'
Name       `Task'
Parent URL https://vektra.github.io/mockery/latest/, line 965, col 17
Real URL   https://vektra.github.io/mockery/latest/(https://taskfile.dev/)
Check time 4.124 seconds
Size       5KB
Result     Error: 404 Not Found

URL        `installation/#go-install'
Name       `recommend not to use go install'
Parent URL https://vektra.github.io/mockery/latest/notes/, line 978, col 125
Real URL   https://vektra.github.io/mockery/latest/notes/installation/#go-install
Check time 3.780 seconds
Size       5KB
Result     Error: 404 Not Found

Statistics:
Downloaded: 628.34KB.
Content types: 17 image, 15 text, 0 video, 0 audio, 3 application, 0 mail and 114 other.
URL lengths: min=16, max=896, avg=134.

That's it. 149 links in 149 URLs checked. 0 warnings found. 2 errors found.
Stopped checking at 2024-10-21 18:29:40+003 (13 seconds)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Version of Go used when building/testing:

  • 1.22
  • 1.23

How Has This Been Tested?

Manually reviewed.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Collaborator

@LandonTClipp LandonTClipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@LandonTClipp LandonTClipp merged commit 33886a9 into vektra:master Oct 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants