-
Notifications
You must be signed in to change notification settings - Fork 87
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bugfix: SectionFooterView AutoDimension Support (#110)
* Revert "fixes footer and header heights on ios 11 to be automatic dimension if the view returns as 0 (#109)" This reverts commit 319a8b8. * Revert "Merge pull request #108 from nealyoung/extremity-height-fix" This reverts commit 2071110, reversing changes made to e002d86. * Bugfix: SectionFooterView AutoDimension Support Problem: 1. I noticed our app was manually laying out subviews in our sectionFooters when I didn't see the need to. 2. After recent changes, Group tableView's which had nil section extremity defaulted to zero, which drops the standard spacing between sections. Note in attatchment. Notable info: Statics currently has deploy target of iOS8, which did not yet support automatic sectionFooterView dimensioning. Solution: - Offer autosizing option which uses UITableViewAutomaticDimension rather than view's original bounds height. Retain original .view(_) case in the event some clients were already sizing beforehand limiting integration breaks. This also offers automatic margin adherence. - Bump deploy target to iOS9 for clean integration. - Revert 2 previous PRs - Default height for plain/grouped styles to play friendly with tableView's defaults. * Example: AutoSized Extremity
- Loading branch information
Showing
4 changed files
with
52 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters