Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Row be agnostic of its presentation #60

Merged
merged 4 commits into from
Nov 18, 2015
Merged

Make Row be agnostic of its presentation #60

merged 4 commits into from
Nov 18, 2015

Commits on Nov 14, 2015

  1. Height does not belong on Row. 

    If you want a custom height for a cell, set tableView.estimatedRowHeight and then add a constraint to cell.contentView to set its height.
    @soffes
    soffes committed Nov 14, 2015
    Configuration menu
    Copy the full SHA
    ba184b4 View commit details
    Browse the repository at this point in the history

  2. Fix constraints in example nib

    @soffes
    soffes committed Nov 14, 2015
    Configuration menu
    Copy the full SHA
    0dacf89 View commit details
    Browse the repository at this point in the history

  3. Colors do not belong in view models. 

    If you want to set the color of something, you should use a custom cell.
    @soffes
    soffes committed Nov 14, 2015
    Configuration menu
    Copy the full SHA
    7f5669c View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2015

  1. Remove tint color test

    @soffes
    soffes committed Nov 17, 2015
    Configuration menu
    Copy the full SHA
    307c28d View commit details
    Browse the repository at this point in the history