Lazily stream responses #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8ccfe46 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Kikobeats
approved these changes
Jun 13, 2023
|
This is really great, thanks for it 🙂 |
Merged
jridgewell
added a commit
to jridgewell/edge-runtime
that referenced
this pull request
Jun 23, 2023
* Use a lazy stream implementation * Add proper test for unhandled rejection in pull * Use consumeUint8ArrayReadableStream * Remove module method mocking * Extract stream helper so it can be reused by Next * Fix test * Export method * Create spicy-toys-teach.md --------- Co-authored-by: Kiko Beats <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reimplements our streaming code to pull data from the
ReadableStreamlazily. The old could would eagerly read and push all data in thefor await (…)loop.This is particularly important for long-running requests when the user's connection is slow or cancels the browser request. If the client is slow, we now respect the back-pressure and wait for a
drainevent. And if the user cancels the request, we detect thecloseevent to stop pulling more data.I chose not to reuse the
consumeUint8ArrayReadableStream, for a few reasons:bodyStream