Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canary.15 broke Hyper with plugins #2788

Closed
2 tasks done
danieldunderfelt opened this issue Mar 27, 2018 · 10 comments
Closed
2 tasks done

Canary.15 broke Hyper with plugins #2788

danieldunderfelt opened this issue Mar 27, 2018 · 10 comments

Comments

@danieldunderfelt
Copy link

danieldunderfelt commented Mar 27, 2018

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: macOS High Sierra, 10.13.3
  • Hyper.app version: 2.0.0 canary.15
  • Link of a Gist with the contents of your .hyper.js: https://gist.github.com/danieldunderfelt/1334ba3fa66987fff6709ed9e46dbe5a
  • Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere): N/A
  • The issue is reproducible in vanilla Hyper.app: No, Hyper-snazzy and hyper-border installed.

Issue

I just got an update notification that Canary.15 was available and restarted the app to update. But now the app doesn't work at all, all I see is the red/yellow/green window management buttons. I cannot type anything in the terminal and I can't even grab the top to move it. AFAIK none of the plugins work either.

I will try reinstalling and disabling the plugins to see if it fixes it, but I assume these are the kinds of things in the canary you want to know about!

Thanks!

@danieldunderfelt danieldunderfelt changed the title Canary.15 completely broke Hyper Canary.15 broke Hyper with plugins Mar 27, 2018
@danieldunderfelt
Copy link
Author

Update: Disabling the plugins made Hyper work again, so I've updated the issue title to reflect this. In short, canary.15 is not compatible with plugins, at least mot Hyper-snazzy or Hyperborder.

@chabou
Copy link
Collaborator

chabou commented Mar 27, 2018

@danieldunderfelt Thank you for your feedback. Our last canary is broken by hyperborder.

@chabou
Copy link
Collaborator

chabou commented Mar 27, 2018

webmatze/hyperborder#43

Maybe not the same issue, but I confirm it is due to hyperborder

@danieldunderfelt
Copy link
Author

I didn't get an error in the console, but yeah, seems like Hyperborder is the culprit.

Thanks! 👍

@alexjmoore
Copy link

Hyperborder is definitely the culprit - however could Hyper itself handle this kind of issue more gracefully? I didn't get any visible error.

@artulito
Copy link

First time user here. I tried canary-15 with hyper-cat, hyperpower, hyperline, but nothing worked.

@danieldunderfelt
Copy link
Author

I'm using it with only the hyper-snazzy theme now and it works. Hyperline has not worked for me at all in v2.

@chabou
Copy link
Collaborator

chabou commented Mar 28, 2018

hyper-cat is totally broken because it used some hterm internals
hyperpower is broken but I made a PR to make it compatible: vercel/hyperpower#52
hyperline is broken and I made some research to understand why: Hyperline/hyperline#150 (comment)

I have no idea yet why Hyperborder is broken. We made a lot of effort to detect broken plugins in v2: 9bd410f

But this is pretty hard to anticipate all problems that plugins can encounter.

@webmatze
Copy link

The problem with hyperborder should be fixed with the latest version 1.0.1 of the plugin.

@Stanzilla
Copy link
Collaborator

Go update your plugins, everyone. If there is no update, disable for the time being. We are working towards a better solution in #2633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants