Keyboard shortcut prefix fix for Windows, Linux (Ctrl+Shift). Fixes #1069. #1191

nbolten · 2016-12-14T01:41:33Z

This pull request fixes #1069 (and related issues like #1100).

Overview

Interactive command line applications commonly bind to Ctrl+<key> keyboard shortcuts. For example, nano uses Ctrl+(G, O, W, K, J, C, X, R, \, U, T, _, V) for essential functionality like reading and writing files and exiting the program. Other applications are similar, like tmux and screen, relying on keyboard shortcuts to manage the program's basic functionality.

This isn't an issue when using hyper on Macs, as the modifier prefix for interacting with the hyper windows is Cmd. On non-Macs (like Windows and Linux machines), the default prefix is Ctrl, which causes many conflicts.

This pull request proposes to address these conflicts by setting the default prefix on non-Macs to Ctrl+Shift, which is common for terminal emulators in linux. The Super key has been suggested as an alternative, but this would conflict with several shortcuts built into the Windows OS as well as many linux-focused desktop environment like Unity and Gnome. To avoid conflicts with defaults that already used Ctrl+Shift, some shortcuts were changed to (hopefully) reasonable alternatives. This pull request does not change any shortcuts on Macs.

Summary of changes

Default shortcut prefix on non-Macs changed from Ctrl to Ctrl+Shift.
Some shortcuts that already used Ctrl+Shift were changed to be more similar to their Mac counterparts:
- split vertically was changed from Ctrl+Shift+E to Ctrl+Shift+D
Some shortcuts already used Ctrl+Shift and are unchanged
- copy is Ctrl+Shift+C
- devtools is Ctrl+Shift+I
- update plugins is Ctrl+Shift+U
- moveLeft2 and moveRight2 are Ctrl+Shift+{ and Ctrl+Shift+}
Some shortcuts were changed to (hopefully) reasonable alternatives
- split horizontally was changed from Ctrl+Shift+O to Ctrl+Shift+E
- redo was changed from Ctrl+Shift+Z (now undo) to Ctrl+Shift+Y
- closing the entire window was changed from Ctrl+Shift+W (now close tab) to Ctrl+Shift+Q
- full reload was changed from Ctrl+Shift+R (now reload) to Ctrl+Shift+F5
I didn't know what to do with some of the shortcuts, so in those cases I replaced Shift with Z (please review/change!)
- previous pane was changed from Ctrl+Shift+Alt+Tab to Ctrl+Z+Alt+Tab.
- moveLeft1 was changed from Ctrl+Shift+Left to Ctrl+Shift+Z+Left
- moveRight1 was changed from Ctrl+Shift+Right to Ctrl+Shift+Z+Right
- moveLeft4 was changed from Ctrl+Shift+Tab to Ctrl+Shift+Z+Tab

One of the shortcuts in that last case already involved five simultaneous keypresses, even on a Mac, so I'll humbly suggest it be switched to something else entirely!

I was unable to test whether the undo functionality was broken by using Ctrl+Shift+Z+<key>. I'm not actually sure what undo is supposed to do in hyper (or the moveLeft1/2/3/4 options). Are they bound to any actions?

It may also be worthwhile to review Atom's shortcuts for linux + windows for better defaults. Windows version here https://github.com/atom/atom/blob/master/keymaps/win32.cson and linux version here https://github.com/atom/atom/blob/master/keymaps/linux.cson.

From hyper's pull request template

To help whoever reviews your PR, it'd be extremely helpful for you to list whether your PR is ready to be merged:
- This PR is ready to be merged
If there's anything left to do and if there are any related PRs
- Someone should review the new defaults to make sure they don't break conventions. I'm also unsure what to do with the 4 cases where I used Z instead of Shift, though it didn't seem to break anything for me.
- Pull requests related to shortcuts would need to be updated, particularly keymap feature #925
It'd also be extremely helpful to enable us to update your PR incase we need to rebase or what-not by checking Allow edits from maintainers
- Done!

…inux, windows, etc) to prevent conflict with common terminal application shortcuts (e.g. ctrl+x in nano).

fungiboletus · 2016-12-14T09:45:17Z

I tested the diff on Hyper 1.0.0 Windows. The new shortcuts don't seem to work, Ctrl+Shift+T or Ctrl+Shift+A for example. Ctrl+A still selects the text and doesn't send the command.

It's on the good track though 😃

nbolten · 2016-12-14T20:08:51Z

Hi @yellowiscool! I did a build on Windows 10 (npm run dev + npm run pack + running the dist Hyper.exe) and Ctrl+Shift+T and Ctrl+Shift+W worked fine.

Is Ctrl+A supposed to select all the text in the current cursor? Neither that nor Ctrl+Shift+A work for me, nor does Menu>Edit>Select All.

This is running off of a downloaded zip copy of my fork.

nbolten · 2016-12-16T02:05:36Z

Ah, @yellowiscool, the accelerators.js file didn't exist in v1.0.0, so applying the diff won't do anything (the app won't even read accelerators.js). accelerators.js was added in commit be286c0.

hahuang65 · 2016-12-21T18:23:43Z

I'd love for this to make it into a build sooner rather than later! I really want to use Hyper on Linux, but I need ctrl-a and ctrl-v to not be swallowed by the app and passed on to the shell.

AlinaNova21 · 2016-12-21T18:37:38Z

Same here, I use ctrl+a in tmux and ctrl+w and ctrl+x in nano, this is currently a blocker for me using hyper until this is merged.

…#1306

celevra · 2016-12-31T14:17:19Z

same here, this is bug not a feature, the fix has to be released asap. For me its also a show stopper

hahuang65 · 2017-01-04T23:11:24Z

Any chance we can get a review on this? Would really love to use this...

alanzanattadev · 2017-01-09T12:35:13Z

An update on the current state of this issue ?

internalfx · 2017-01-10T18:55:08Z

Awwww....I assumed this had been merged when 1.1 came out.....back to running @nbolten fork again.

sambanks · 2017-01-11T01:19:23Z

I am also waiting on this one, would love to start using on my Linux desktop

anaisbetts · 2017-01-11T05:58:09Z

I'm 👍 on this idea, Ctrl-[LETTER] has too much going on to try to assign all of the shortcuts to it

anaisbetts

I'm generally into this change, just a few suggestions

anaisbetts · 2017-01-11T05:59:37Z

app/accelerators.js


  // Window menu
  minimize: 'M',
-  showPreviousTab: 'Alt+Left',
-  showNextTab: 'Alt+Right',
+  showPreviousTab: isMac ? 'Alt+Left' : '+Ctrl+PageDown',


Can this just be Ctrl-Shift-Tab?

No strong opinions from me on this, but Ctrl+PageDown/Up is used by VS Code, Gnome Terminal, and Atom.

Actually, Ctrl+Tab and Ctrl+Shift+Tab is also used by Atom/Chrome, so maybe both could be used?

anaisbetts · 2017-01-11T05:59:45Z

app/accelerators.js

-  showPreviousTab: 'Alt+Left',
-  showNextTab: 'Alt+Right',
+  showPreviousTab: isMac ? 'Alt+Left' : '+Ctrl+PageDown',
+  showNextTab: isMac ? 'Alt+Right' : '+Ctrl+PageUp',


anaisbetts · 2017-01-11T06:04:49Z

app/accelerators.js

-  showPreviousTab: 'Alt+Left',
-  showNextTab: 'Alt+Right',
+  showPreviousTab: isMac ? 'Alt+Left' : '+Ctrl+PageDown',
+  showNextTab: isMac ? 'Alt+Right' : '+Ctrl+PageUp',
  selectNextPane: 'Ctrl+Alt+Tab',


This shortcut doesn't work on Windows, it will invoke Alt-Tab

Ctrl+Alt+Tab/Ctrl+Shift+Alt+Tab also conflicts with the Accessibility Switcher on Gnome, that's no good...

iTerm uses Cmd+]/[.

tmux, screen, and Atom use special pane modes for pane manipulation, so e.g 'next pane' in Atom is Ctrl+k to enter pane mode, then Ctrl+n for 'next pane'.

I don't use panes and also don't have strong opinions on this one.

Maybe Ctrl-Shift-LeftArrow + Ctrl-Shift-RightArrow?

just throwing out some ideas.. in atom, the panes are indexed, and we can switch between them using ctrl+[index].. would it be possible to have something similar?

@ignatiusreza hyper-pane plugin has been made for this purpose: https://www.npmjs.com/package/hyper-pane

wow! looking good! thanks @chabou 👍

m-dango · 2017-01-27T11:38:56Z

Would it be possible to change the 'update plugins' shortcut? Ctrl+Shift+U is for inserting unicode characters in Ubuntu. Perhaps Ctrl+Shift+P?

ppot · 2017-02-11T08:02:45Z

Some are missing. But can you update those key map with the desired keys in comments.
ppot#11

{
 "devtools":"Cmd+Alt+I",
 "window:new":"Cmd+N",
 "window:minimize": "Cmd+M",
 "window:close":"Cmd+Shift+W",
 "tab:new":"Cmd+T",
 "tab:next":"Cmd+shift+]",
 "tab:prev":"Cmd+shift+[",
 "pane:next":"Cmd+]",
 "pane:prev":"Cmd+[",
 "pane:left":"Cmd+Alt+Left",
 "pane:right":"Cmd+Alt+Right",
 "pane:up":"Cmd+Alt+Up",
 "pane:down":"Cmd+Alt+Down",
 "pane:vertical":"Cmd+D",
 "pane:horizontal":"Cmd+Shift+D",
 "pane:close":"Cmd+W",
 "editor:undo":"Cmd+Z",
 "editor:redo":"Cmd+Shift+Z",
 "editor:cut":"Cmd+X",
 "editor:copy":"Cmd+C",
 "editor:paste":"Cmd+V",
 "editor:selectAll":"Cmd+A",
 "editor:clearBuffer":"Cmd+K"
}

celevra · 2017-02-16T19:12:27Z

why is this not in the actual release?
hyper is not usable under windows and linux without this pull request!
and no, ctrl+shift is no solution!

nandak522 · 2017-02-24T06:21:34Z

👍

Stanzilla · 2017-02-24T16:38:18Z

@ppot any chance to get this in any time soon?

ppot · 2017-02-24T16:58:22Z

@Stanzilla You mean my version? See #1509

Still need to make flexible Keymap before merging

Stanzilla · 2017-02-24T19:51:42Z

Oh, I see

celevra · 2017-03-11T12:04:45Z

three weaks gone, 2 new release and this isn't merged... again so much time lost where i cant use hyper, and i want to use hyper!

ppot · 2017-03-11T17:42:25Z

@celevra Look at Keymap PR

RobertWHurst · 2017-03-13T09:11:02Z

Would love to see this merged.

apinter · 2017-03-21T03:45:23Z

I just started to use Hyper a few hours ago on my Arch box and love it so much I put it on my F25 daily workstation as well, BUT the keybindings are making it... well not useless, but difficult to live with.
Frankly I can't use vim and having difficulties with tmux as well.
Do you happened to have an estimate when can this fix go public?

EDIT: Me honestly could live with a super as cmd key, is there any way to change it? I think can do that in accelerators.js, but not sure if takes effect?

ignatiusreza · 2017-03-23T10:40:19Z

any plan on making the shortcuts configurable?

ppot · 2017-03-24T01:41:16Z

@ignatiusreza Yes, #1509

alexellis · 2017-04-07T12:24:06Z

How can I fix the key-bindings to match with the Gnome Terminal? Is there somewhere I need to paste the {} json block quoted above?

ppot · 2017-04-08T04:15:56Z

@alexellis PR listed above Keymaps

alexellis · 2017-04-08T09:19:17Z

@ppot my question is how to apply / set those keycaps. It's not clear to me from the documentation / PR. Please could you explain?

ppot · 2017-04-11T00:48:18Z

@alexellis Take a look at my PR Keymaps #1509

nbolten · 2017-05-18T16:58:06Z

Since a cooler keymaps implementation is on the way, I'm closing this PR. Hope #1509 gets reviewed/merged soon!

Changed default keyboard shortcut prefix to ctrl+shift on non-macs (l…

9163bd4

…inux, windows, etc) to prevent conflict with common terminal application shortcuts (e.g. ctrl+x in nano).

This was referenced Dec 16, 2016

Ctrl + W closes the terminal #1199

Closed

Ctrl+X not working in nano #1069

Closed

CTRL+a does not work in tmux under Linux #1100

Closed

Merge branch 'master' of https://github.com/zeit/hyper

066aa6e

This was referenced Dec 20, 2016

Nano constant glitches #1271

Closed

Git automerge - nano edit fail #1279

Closed

TylerRick mentioned this pull request Dec 23, 2016

Make keyboard shortcuts (etc.) work as expected on Linux #1306

Closed

nbolten added 2 commits December 24, 2016 01:35

Modified default accelerators on Linux, Windows to reflect feedback in …

2efb62a

…#1306

Merge branch 'master' of https://github.com/zeit/hyper

27e3147

anaisbetts reviewed Jan 11, 2017

View reviewed changes

flybayer mentioned this pull request Jan 13, 2017

Ctrl-based shortcuts don't work on Linux #274

Closed

arcanis mentioned this pull request Jan 21, 2017

Running nano from Hyper on Windows, doesn't allow me to exit with CTRL+X. #1424

Closed

adambair mentioned this pull request Apr 12, 2017

More portable control key awarness (windows and linux) #1525

Closed

2 tasks

MartyGentillon mentioned this pull request Apr 15, 2017

Improve Linux keyboard shortcuts #1616

Closed

nbolten closed this May 18, 2017

Keyboard shortcut prefix fix for Windows, Linux (Ctrl+Shift). Fixes #1069. #1191

Keyboard shortcut prefix fix for Windows, Linux (Ctrl+Shift). Fixes #1069. #1191

Conversation

nbolten commented Dec 14, 2016 • edited Loading

Overview

Summary of changes

From hyper's pull request template

fungiboletus commented Dec 14, 2016

nbolten commented Dec 14, 2016

nbolten commented Dec 16, 2016

hahuang65 commented Dec 21, 2016

AlinaNova21 commented Dec 21, 2016

celevra commented Dec 31, 2016

hahuang65 commented Jan 4, 2017

alanzanattadev commented Jan 9, 2017

internalfx commented Jan 10, 2017

sambanks commented Jan 11, 2017

anaisbetts commented Jan 11, 2017

anaisbetts left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

m-dango commented Jan 27, 2017 • edited Loading

ppot commented Feb 11, 2017

celevra commented Feb 16, 2017

nandak522 commented Feb 24, 2017

Stanzilla commented Feb 24, 2017

ppot commented Feb 24, 2017

Stanzilla commented Feb 24, 2017

celevra commented Mar 11, 2017

ppot commented Mar 11, 2017

RobertWHurst commented Mar 13, 2017

apinter commented Mar 21, 2017 • edited Loading

ignatiusreza commented Mar 23, 2017

ppot commented Mar 24, 2017

alexellis commented Apr 7, 2017

ppot commented Apr 8, 2017

alexellis commented Apr 8, 2017

ppot commented Apr 11, 2017

nbolten commented May 18, 2017

nbolten commented Dec 14, 2016 •

edited

Loading

m-dango commented Jan 27, 2017 •

edited

Loading

apinter commented Mar 21, 2017 •

edited

Loading