Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequelize integration test, with sample package support page #407

Merged
merged 4 commits into from
May 28, 2019

Conversation

guybedford
Copy link
Contributor

@guybedford guybedford commented May 23, 2019

This adds an integration test for sequelize, while also including a new documentation page linked to from the readme that we can use to document packages that need specific configurations for ncc.

In this case the dialectModule option for sequelize.

Resolves #397 and resolves #345.

@guybedford
Copy link
Contributor Author

Note - this is passing with the asset relocator loader updates.

package-support.md Outdated Show resolved Hide resolved
@styfle
Copy link
Member

styfle commented May 23, 2019

In your comment from vercel/webpack-asset-relocator-loader#39 it sounds like this fixes both sequelize and lighthouse.

Can you also add an integration test for lighthouse?

@guybedford
Copy link
Contributor Author

Unfortunately there's another issue for Lighthouse - I've discussed this at #290 (comment).

styfle
styfle previously approved these changes May 23, 2019
@styfle styfle dismissed their stale review May 23, 2019 14:22

Please update warl dependency so the tests pass

@codecov-io
Copy link

Codecov Report

Merging #407 into master will decrease coverage by 1.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
- Coverage   74.68%   73.29%   -1.39%     
==========================================
  Files          13       14       +1     
  Lines         395      397       +2     
==========================================
- Hits          295      291       -4     
- Misses        100      106       +6
Impacted Files Coverage Δ
src/index.js 83.12% <0%> (-0.42%) ⬇️
src/@@notfound.js 0% <0%> (ø) ⬆️
src/sourcemap-register.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67ebbf1...ef48761. Read the comment docs.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But why did coverage drop so much?

@guybedford
Copy link
Contributor Author

The coverage change seems like it might have been delayed from one of the previous PRs? Because the diff is the same otherwise.

@styfle
Copy link
Member

styfle commented May 25, 2019

@guybedford Ok I think this is good to merge.

I missed the last release but it looks like it was a beta. Why was that? And should the next release be beta too or stable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sequelize regression Issues with multi-database libs: sequelize
3 participants