-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sequelize integration test, with sample package support page #407
Conversation
06e4636
to
bb06d83
Compare
Note - this is passing with the asset relocator loader updates. |
bb06d83
to
f09d859
Compare
f09d859
to
5b3ddfc
Compare
In your comment from vercel/webpack-asset-relocator-loader#39 it sounds like this fixes both sequelize and lighthouse. Can you also add an integration test for lighthouse? |
Unfortunately there's another issue for Lighthouse - I've discussed this at #290 (comment). |
Co-Authored-By: Steven <[email protected]>
Please update warl dependency so the tests pass
93bc689
to
ef48761
Compare
Codecov Report
@@ Coverage Diff @@
## master #407 +/- ##
==========================================
- Coverage 74.68% 73.29% -1.39%
==========================================
Files 13 14 +1
Lines 395 397 +2
==========================================
- Hits 295 291 -4
- Misses 100 106 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. But why did coverage drop so much?
The coverage change seems like it might have been delayed from one of the previous PRs? Because the diff is the same otherwise. |
@guybedford Ok I think this is good to merge. I missed the last release but it looks like it was a beta. Why was that? And should the next release be beta too or stable? |
This adds an integration test for sequelize, while also including a new documentation page linked to from the readme that we can use to document packages that need specific configurations for ncc.
In this case the
dialectModule
option for sequelize.Resolves #397 and resolves #345.