-
Notifications
You must be signed in to change notification settings - Fork 26.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Simplify with-noscript example (#9094)
## Changelog - Removed react-lazyload - Removed images - Removed ReactDOMServer from Client - Removed next.config.js ## Notes **CommonJS vs ESM:** In the future we might be able to use top level `await` in order to import only on the server (e.g.: `await import(“react-dom/server”)`) Until then we need to mix CommonJS and ESM in favor of messing with the webpack config.
- Loading branch information
1 parent
beed775
commit 02e75cf
Showing
8 changed files
with
22 additions
and
47 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,15 @@ | ||
import React from 'react' | ||
import ReactDOMServer from 'react-dom/server' | ||
|
||
export default function Noscript (props) { | ||
const staticMarkup = ReactDOMServer.renderToStaticMarkup(props.children) | ||
// We don't want to send 'react-dom/server' to the client | ||
let ReactDOMServer | ||
if (typeof window === 'undefined') { | ||
ReactDOMServer = require('react-dom/server') | ||
} | ||
|
||
export default function Noscript ({ children }) { | ||
if (!ReactDOMServer) { | ||
return null | ||
} | ||
const staticMarkup = ReactDOMServer.renderToStaticMarkup(children) | ||
return <noscript dangerouslySetInnerHTML={{ __html: staticMarkup }} /> | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,35 +1,15 @@ | ||
import React from 'react' | ||
import LazyLoad from 'react-lazyload' | ||
import Noscript from '../components/Noscript' | ||
|
||
const images = [ | ||
'/static/img/reactjs.png', | ||
'/static/img/nextjs.png', | ||
'/static/img/vuejs.png', | ||
'/static/img/angular.jpg' | ||
] | ||
export default function IndexPage () { | ||
return ( | ||
<> | ||
<h1>noscript</h1> | ||
<p>Disable JavaScript to see it in action:</p> | ||
|
||
class Index extends React.Component { | ||
static getInitialProps (context) { | ||
const { isServer } = context | ||
return { isServer } | ||
} | ||
render () { | ||
return ( | ||
<div style={{ textAlign: 'center' }}> | ||
{images.map((item, index) => ( | ||
<div key={index}> | ||
<LazyLoad height={700} offset={100}> | ||
<img width={700} height={700} src={item} alt={`image_${index}`} /> | ||
</LazyLoad> | ||
<Noscript> | ||
<img width={700} height={700} src={item} alt={`image_${index}`} /> | ||
</Noscript> | ||
</div> | ||
))} | ||
</div> | ||
) | ||
} | ||
} | ||
<hr /> | ||
|
||
export default Index | ||
<Noscript>Noscript is enabled!</Noscript> | ||
</> | ||
) | ||
} |
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.