Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: handle jsxspreadattribute in inline-script-id eslint rule (#32421)
fixes #32178 the `inline-script-id` eslint rule crashed when encountering a `JSXSpreadAttribute`. this pr fixes that, and also handles `id` being passed via the spreaded object. ## Bug - [x] Related issues linked using `fixes #number` - [x] ~~Integration~~ Unit tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
- Loading branch information
49afcd4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stats from current release
Default Build (Increase detected⚠️ )
General Overall increase⚠️
Page Load Tests Overall increase ✓
Client Bundles (main, webpack, commons) Overall increase⚠️
Legacy Client Bundles (polyfills)
Client Pages Overall decrease ✓
Client Build Manifests
Rendered Page Sizes Overall increase⚠️
Diffs
Diff for _buildManifest.js
Diff for image-HASH.js
Diff for main-HASH.js
Diff for index.html
Diff for link.html
Diff for withRouter.html
Default Build with SWC (Increase detected⚠️ )
General Overall increase⚠️
Page Load Tests Overall increase ✓
Client Bundles (main, webpack, commons) Overall increase⚠️
Legacy Client Bundles (polyfills)
Client Pages Overall decrease ✓
Client Build Manifests
Rendered Page Sizes Overall decrease ✓
Diffs
Diff for _buildManifest.js
Diff for image-HASH.js
Diff for main-HASH.js
Diff for index.html
Diff for link.html
Diff for withRouter.html