Move isSrcDir back to eventVersion

vercel · Oct 23, 2019 · 517914b · 517914b
1 parent 5c01535
commit 517914b
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 22 deletions.
diff --git a/packages/next/build/index.ts b/packages/next/build/index.ts
@@ -85,23 +85,29 @@ export default async function build(dir: string, conf = null): Promise<void> {
     )
   }
 
+  const buildSpinner = createSpinner({
+    prefixText: 'Creating an optimized production build',
+  })
+
   const config = loadConfig(PHASE_PRODUCTION_BUILD, dir, conf)
   const { target } = config
   const buildId = await generateBuildId(config.generateBuildId, nanoid)
   const distDir = path.join(dir, config.distDir)
   const publicDir = path.join(dir, 'public')
   const pagesDir = findPagesDir(dir)
-  const telemetry = new Telemetry({
-    distDir,
-    isSrcDir: pagesDir.startsWith('src'),
-  })
+  const telemetry = new Telemetry({ distDir })
 
   let publicFiles: string[] = []
   let hasPublicDir = false
 
   let backgroundWork: (Promise<any> | undefined)[] = []
   backgroundWork.push(
-    telemetry.record(eventVersion({ cliCommand: 'build' })),
+    telemetry.record(
+      eventVersion({
+        cliCommand: 'build',
+        isSrcDir: pagesDir.startsWith('src'),
+      })
+    ),
     eventNextPlugins(path.resolve(dir)).then(events => telemetry.record(events))
   )
 

diff --git a/packages/next/export/index.ts b/packages/next/export/index.ts
@@ -95,7 +95,7 @@ export default async function(
   const distDir = join(dir, nextConfig.distDir)
   if (!options.buildExport) {
     const telemetry = new Telemetry({ distDir })
-    telemetry.record(eventVersion({ cliCommand: 'export' }))
+    telemetry.record(eventVersion({ cliCommand: 'export', isSrcDir: null }))
   }
 
   const subFolders = nextConfig.exportTrailingSlash

diff --git a/packages/next/server/next-dev-server.ts b/packages/next/server/next-dev-server.ts
@@ -206,11 +206,13 @@ export default class DevServer extends Server {
     await this.startWatcher()
     this.setDevReady!()
 
-    const telemetry = new Telemetry({
-      distDir: this.distDir,
-      isSrcDir: this.pagesDir!.startsWith('src'),
-    })
-    telemetry.record(eventVersion({ cliCommand: 'dev' }))
+    const telemetry = new Telemetry({ distDir: this.distDir })
+    telemetry.record(
+      eventVersion({
+        cliCommand: 'dev',
+        isSrcDir: this.pagesDir!.startsWith('src'),
+      })
+    )
   }
 
   protected async close() {

diff --git a/packages/next/telemetry/anonymous-meta.ts b/packages/next/telemetry/anonymous-meta.ts
@@ -14,25 +14,19 @@ type AnonymousMeta = {
   isDocker: boolean
   isNowDev: boolean
   isCI: boolean
-  isSrcDir?: boolean
   ciName: string | null
 }
 
 let traits: AnonymousMeta | undefined
 
-export function getAnonymousMeta({
-  isSrcDir,
-}: {
-  isSrcDir?: boolean
-}): AnonymousMeta {
+export function getAnonymousMeta(): AnonymousMeta {
   if (traits) {
     return traits
   }
 
   const cpus = os.cpus() || []
   const { NOW_REGION } = process.env
   traits = {
-    isSrcDir,
     // Software information
     systemPlatform: os.platform(),
     systemRelease: os.release(),

diff --git a/packages/next/telemetry/events/version.ts b/packages/next/telemetry/events/version.ts
@@ -4,6 +4,7 @@ type EventCliSessionStarted = {
   nextVersion: string
   nodeVersion: string
   cliCommand: string
+  isSrcDir: boolean | null
 }
 
 export function eventVersion(
@@ -21,6 +22,7 @@ export function eventVersion(
         nextVersion: process.env.__NEXT_VERSION,
         nodeVersion: process.version,
         cliCommand: event.cliCommand,
+        isSrcDir: event.isSrcDir,
       } as EventCliSessionStarted,
     },
   ]

diff --git a/packages/next/telemetry/storage.ts b/packages/next/telemetry/storage.ts
@@ -44,15 +44,13 @@ export class Telemetry {
   private conf: Conf<any>
   private sessionId: string
   private rawProjectId: string
-  private isSrcDir?: boolean
 
-  constructor({ distDir, isSrcDir }: { distDir: string; isSrcDir?: boolean }) {
+  constructor({ distDir }: { distDir: string }) {
     const storageDirectory = getStorageDirectory(distDir)
 
     this.conf = new Conf({ projectName: 'nextjs', cwd: storageDirectory })
     this.sessionId = randomBytes(32).toString('hex')
     this.rawProjectId = getRawProjectId()
-    this.isSrcDir = isSrcDir
 
     this.notify()
   }
@@ -204,7 +202,7 @@ export class Telemetry {
       projectId: this.projectId,
       sessionId: this.sessionId,
     }
-    const meta: EventMeta = getAnonymousMeta({ isSrcDir: this.isSrcDir })
+    const meta: EventMeta = getAnonymousMeta()
 
     return _postPayload(`https://telemetry.nextjs.org/api/v1/record`, {
       context,