Disable suggesting incremental type checking (#25144)

It have performance characteristics that might not work for everyone. You can still enable it manually.
vercel · May 14, 2021 · 84d5766 · 84d5766
1 parent 64a709d
commit 84d5766
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 10 deletions.
diff --git a/packages/next/lib/typescript/writeConfigurationDefaults.ts b/packages/next/lib/typescript/writeConfigurationDefaults.ts
@@ -1,7 +1,6 @@
 import { promises as fs } from 'fs'
 import chalk from 'chalk'
 import * as CommentJson from 'next/dist/compiled/comment-json'
-import semver from 'next/dist/compiled/semver'
 import os from 'os'
 import { getTypeScriptConfiguration } from './getTypeScriptConfiguration'
 
@@ -29,9 +28,6 @@ function getDesiredCompilerOptions(
     strict: { suggested: false },
     forceConsistentCasingInFileNames: { suggested: true },
     noEmit: { suggested: true },
-    ...(semver.gte(ts.version, '4.3.0-beta')
-      ? { incremental: { suggested: true } }
-      : undefined),
 
     // These values are required and cannot be changed by the user
     // Keep this in sync with the webpack config

diff --git a/test/integration/tsconfig-verifier/test/index.test.js b/test/integration/tsconfig-verifier/test/index.test.js
@@ -39,7 +39,6 @@ describe('tsconfig.json verifier', () => {
           \\"strict\\": false,
           \\"forceConsistentCasingInFileNames\\": true,
           \\"noEmit\\": true,
-          \\"incremental\\": true,
           \\"esModuleInterop\\": true,
           \\"module\\": \\"esnext\\",
           \\"moduleResolution\\": \\"node\\",
@@ -84,7 +83,6 @@ describe('tsconfig.json verifier', () => {
           \\"strict\\": false,
           \\"forceConsistentCasingInFileNames\\": true,
           \\"noEmit\\": true,
-          \\"incremental\\": true,
           \\"esModuleInterop\\": true,
           \\"module\\": \\"esnext\\",
           \\"moduleResolution\\": \\"node\\",
@@ -152,7 +150,6 @@ describe('tsconfig.json verifier', () => {
           \\"strict\\": false,
           \\"forceConsistentCasingInFileNames\\": true,
           \\"noEmit\\": true,
-          \\"incremental\\": true,
           \\"moduleResolution\\": \\"node\\",
           \\"resolveJsonModule\\": true,
           \\"isolatedModules\\": true,
@@ -201,7 +198,6 @@ describe('tsconfig.json verifier', () => {
           \\"strict\\": false,
           \\"forceConsistentCasingInFileNames\\": true,
           \\"noEmit\\": true,
-          \\"incremental\\": true,
           \\"moduleResolution\\": \\"node\\",
           \\"resolveJsonModule\\": true,
           \\"isolatedModules\\": true,
@@ -247,7 +243,6 @@ describe('tsconfig.json verifier', () => {
           \\"strict\\": false,
           \\"forceConsistentCasingInFileNames\\": true,
           \\"noEmit\\": true,
-          \\"incremental\\": true,
           \\"moduleResolution\\": \\"node\\",
           \\"resolveJsonModule\\": true,
           \\"isolatedModules\\": true,
@@ -286,7 +281,6 @@ describe('tsconfig.json verifier', () => {
           "strict": false,
           "forceConsistentCasingInFileNames": true,
           "noEmit": true,
-          "incremental": true,
           "esModuleInterop": true,
           "module": "esnext",
           "moduleResolution": "node",