Skip to content

Commit

Permalink
Update reason message for isolatedModules and esModuleInterop (#31150)
Browse files Browse the repository at this point in the history
This is still required with SWC. The message just wasn't updated.

Fixes #31149



## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
  • Loading branch information
timneutkens authored Nov 8, 2021
1 parent 283af4e commit 9d7900c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/next/lib/typescript/writeConfigurationDefaults.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function getDesiredCompilerOptions(
// 'parsedValue' matches the output value from ts.parseJsonConfigFileContent()
esModuleInterop: {
value: true,
reason: 'requirement for babel',
reason: 'requirement for SWC / babel',
},
module: {
parsedValue: ts.ModuleKind.ESNext,
Expand All @@ -60,7 +60,7 @@ function getDesiredCompilerOptions(
resolveJsonModule: { value: true, reason: 'to match webpack resolution' },
isolatedModules: {
value: true,
reason: 'requirement for babel',
reason: 'requirement for SWC / Babel',
},
jsx: {
parsedValue: ts.JsxEmit.Preserve,
Expand Down

0 comments on commit 9d7900c

Please sign in to comment.