Throw error instead of logging to make sure it's noticed

vercel · Oct 28, 2019 · f3db0a0 · f3db0a0
1 parent 98f1f59
commit f3db0a0
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 9 deletions.
diff --git a/packages/next/next-server/server/render.tsx b/packages/next/next-server/server/render.tsx
@@ -286,7 +286,7 @@ export async function renderToHTML(
   }
 
   if (!!unstable_getStaticParams && !isSpr) {
-    console.error(
+    throw new Error(
       `unstable_getStaticParams was added without a unstable_getStaticProps in ${pathname}. Without unstable_getStaticProps, unstable_getStaticParams does nothing`
     )
   }

diff --git a/test/integration/prerender/pages/no-getStaticProps.js b/test/integration/prerender/pages/no-getStaticProps.js
diff --git a/test/integration/prerender/test/index.test.js b/test/integration/prerender/test/index.test.js
@@ -239,9 +239,24 @@ const runTests = (dev = false) => {
     })
 
     it('should show error when getStaticParams is used without getStaticProps', async () => {
-      await renderViaHTTP(appPort, '/no-getStaticProps')
+      const pagePath = join(appDir, 'pages/no-getStaticProps.js')
+      await fs.writeFile(
+        pagePath,
+        `
+        export async function unstable_getStaticParams() {
+          return []
+        }
+
+        export default () => 'hi'
+      `,
+        'utf8'
+      )
+
+      const html = await renderViaHTTP(appPort, '/no-getStaticProps')
+      await fs.remove(pagePath)
       await waitFor(500)
-      expect(stderr).toMatch(
+
+      expect(html).toMatch(
         /unstable_getStaticParams was added without a unstable_getStaticProps in/
       )
     })