Ensure notFound entries are not added to manifest

vercel · Jan 27, 2021 · f528d9d · f528d9d
1 parent 73a9f24
commit f528d9d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 17 deletions.
diff --git a/packages/next/build/index.ts b/packages/next/build/index.ts
@@ -1164,15 +1164,18 @@ export default async function build(
                 // TODO: do we want to show all locale variants in build output
                 for (const locale of i18n.locales) {
                   const localePage = `/${locale}${page === '/' ? '' : page}`
-                  finalPrerenderRoutes[localePage] = {
-                    initialRevalidateSeconds:
-                      exportConfig.initialPageRevalidationMap[localePage],
-                    srcRoute: null,
-                    dataRoute: path.posix.join(
-                      '/_next/data',
-                      buildId,
-                      `${file}.json`
-                    ),
+
+                  if (!ssgNotFoundPaths.includes(localePage)) {
+                    finalPrerenderRoutes[localePage] = {
+                      initialRevalidateSeconds:
+                        exportConfig.initialPageRevalidationMap[localePage],
+                      srcRoute: null,
+                      dataRoute: path.posix.join(
+                        '/_next/data',
+                        buildId,
+                        `${file}.json`
+                      ),
+                    }
                   }
                 }
               } else {

diff --git a/test/integration/i18n-support/test/shared.js b/test/integration/i18n-support/test/shared.js
@@ -555,10 +555,6 @@ export function runTests(ctx) {
             \\"srcRoute\\": \\"/gsp/fallback/[slug]\\",
             \\"dataRoute\\": \\"/_next/data/BUILD_ID/en/gsp/fallback/always.json\\"
           },
-          \\"/en/not-found\\": {
-            \\"srcRoute\\": null,
-            \\"dataRoute\\": \\"/_next/data/BUILD_ID/not-found.json\\"
-          },
           \\"/fr\\": {
             \\"initialRevalidateSeconds\\": false,
             \\"srcRoute\\": null,
@@ -768,10 +764,6 @@ export function runTests(ctx) {
             \\"initialRevalidateSeconds\\": false,
             \\"srcRoute\\": \\"/gsp/fallback/[slug]\\",
             \\"dataRoute\\": \\"/_next/data/BUILD_ID/nl/gsp/fallback/always.json\\"
-          },
-          \\"/nl/not-found\\": {
-            \\"srcRoute\\": null,
-            \\"dataRoute\\": \\"/_next/data/BUILD_ID/not-found.json\\"
           }
         }"
       `)