Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/canary' into wbinnssmith/routes-…
Browse files Browse the repository at this point in the history
…client-component
  • Loading branch information
wbinnssmith committed Apr 15, 2024
2 parents f2a73f9 + 3491417 commit ffdc703
Show file tree
Hide file tree
Showing 13 changed files with 219 additions and 189 deletions.
70 changes: 35 additions & 35 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ swc_core = { version = "0.90.30", features = [
testing = { version = "0.35.22" }

# Turbo crates
turbopack-binding = { git = "https://github.com/vercel/turbo.git", tag = "turbopack-240411.3" }
turbopack-binding = { git = "https://github.com/vercel/turbo.git", tag = "turbopack-240415.5" }
# [TODO]: need to refactor embed_directory! macro usages, as well as resolving turbo_tasks::function, macros..
turbo-tasks = { git = "https://github.com/vercel/turbo.git", tag = "turbopack-240411.3" }
turbo-tasks = { git = "https://github.com/vercel/turbo.git", tag = "turbopack-240415.5" }
# [TODO]: need to refactor embed_directory! macro usage in next-core
turbo-tasks-fs = { git = "https://github.com/vercel/turbo.git", tag = "turbopack-240411.3" }
turbo-tasks-fs = { git = "https://github.com/vercel/turbo.git", tag = "turbopack-240415.5" }

# General Deps

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -877,7 +877,7 @@ Here are authentication solutions compatible with Next.js, please refer to the q
- [Clerk](https://clerk.com/docs/quickstarts/nextjs)
- [Kinde](https://kinde.com/docs/developer-tools/nextjs-sdk)
- [Lucia](https://lucia-auth.com/getting-started/nextjs-app)
- [NextAuth.js](https://authjs.dev/guides/upgrade-to-v5)
- [NextAuth.js](https://authjs.dev/getting-started/migrating-to-v5)
- [Supabase](https://supabase.com/docs/guides/getting-started/quickstarts/nextjs)
- [Stytch](https://stytch.com/docs/guides/quickstarts/nextjs)
- [Iron Session](https://github.com/vvo/iron-session)
Expand Down
2 changes: 1 addition & 1 deletion packages/next/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@
"@types/ws": "8.2.0",
"@vercel/ncc": "0.34.0",
"@vercel/nft": "0.26.4",
"@vercel/turbopack-ecmascript-runtime": "https://gitpkg-fork.vercel.sh/vercel/turbo/crates/turbopack-ecmascript-runtime/js?turbopack-240411.3",
"@vercel/turbopack-ecmascript-runtime": "https://gitpkg-fork.vercel.sh/vercel/turbo/crates/turbopack-ecmascript-runtime/js?turbopack-240415.5",
"acorn": "8.5.0",
"amphtml-validator": "1.0.35",
"anser": "1.4.9",
Expand Down
3 changes: 2 additions & 1 deletion packages/next/src/build/webpack-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1880,7 +1880,8 @@ export default async function getBaseWebpackConfig(
new NextFontManifestPlugin({
appDir,
}),
isClient &&
!dev &&
isClient &&
new CssChunkingPlugin(config.experimental.cssChunking === 'strict'),
!dev &&
isClient &&
Expand Down
30 changes: 13 additions & 17 deletions packages/next/src/lib/metadata/resolvers/resolve-opengraph.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,24 +96,20 @@ export function resolveImages(
return nonNullableImages
}

const ogTypeToFields: Record<string, readonly string[]> = {
article: OgTypeFields.article,
book: OgTypeFields.article,
'music.song': OgTypeFields.song,
'music.album': OgTypeFields.song,
'music.playlist': OgTypeFields.playlist,
'music.radio_station': OgTypeFields.radio,
'video.movie': OgTypeFields.video,
'video.episode': OgTypeFields.video,
}

function getFieldsByOgType(ogType: OpenGraphType | undefined) {
switch (ogType) {
case 'article':
case 'book':
return OgTypeFields.article
case 'music.song':
case 'music.album':
return OgTypeFields.song
case 'music.playlist':
return OgTypeFields.playlist
case 'music.radio_station':
return OgTypeFields.radio
case 'video.movie':
case 'video.episode':
return OgTypeFields.video
default:
return OgTypeFields.basic
}
if (!ogType || !(ogType in ogTypeToFields)) return OgTypeFields.basic
return ogTypeToFields[ogType].concat(OgTypeFields.basic)
}

function validateResolvedImageUrl(
Expand Down
Loading

0 comments on commit ffdc703

Please sign in to comment.