Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[experimental] Basepath bug with catch all routes #13966

Closed
Timer opened this issue Jun 9, 2020 · 1 comment · Fixed by #14036
Closed

[experimental] Basepath bug with catch all routes #13966

Timer opened this issue Jun 9, 2020 · 1 comment · Fixed by #14036
Assignees
@ijjk
Milestone
june 2020

Comments

@Timer
Copy link
Member

Timer commented Jun 9, 2020

Question/possible bug with the latest commit on this branch.

The previous solution worked fine for me with catch-all routes and basePath (see earlier comment), but with the later commit I now get incompatible-href-as errors with router.push, as the as value gets basePath added but href does not.

Example

router.push('/section/[...slug]', '/section/success')

results in the error

Error: The provided `as` value (/basepath/section/success) is incompatible with the `href` value (/section/[...slug])

Assuming this a bug unless I'm missing something?

Originally posted by @daveskybet in #13560 (comment)
@Timer Timer added the kind: bug label Jun 9, 2020
@Timer Timer modified the milestone: june 2020 Jun 9, 2020
@ijjk ijjk mentioned this issue Jun 10, 2020
Merged
@kodiakhq kodiakhq bot closed this as completed in #14036 Jun 10, 2020
kodiakhq bot pushed a commit that referenced this issue Jun 10, 2020
@ijjk
Fix dynamic route match and basePath (#14036)
d5493ff 
This correctly strips the `basePath` before generating the `route-matcher` for dynamic routes and adds regression tests to ensure these work correctly with the `basePath` feature

Closes: #13966
darshkpatel pushed a commit to MLH-Fellowship/next.js that referenced this issue Jun 12, 2020
@ijjk @darshkpatel
Fix dynamic route match and basePath (vercel#14036)
95915d7 
This correctly strips the `basePath` before generating the `route-matcher` for dynamic routes and adds regression tests to ensure these work correctly with the `basePath` feature

Closes: vercel#13966
rokinsky pushed a commit to rokinsky/next.js that referenced this issue Jul 11, 2020
@ijjk @rokinsky
Fix dynamic route match and basePath (vercel#14036)
07fa80a 
This correctly strips the `basePath` before generating the `route-matcher` for dynamic routes and adds regression tests to ensure these work correctly with the `basePath` feature

Closes: vercel#13966
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ijjk ijjk

Labels
None yet
Projects
None yet
Milestone
june 2020
Development

Successfully merging a pull request may close this issue.

Fix dynamic route match and basePath ijjk/next.js
3 participants
@Timer @balazsorban44 @ijjk