Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlay font size with global styles #18680

Closed
Timer opened this issue Nov 2, 2020 · 3 comments · Fixed by #17723
Closed

Overlay font size with global styles #18680

Timer opened this issue Nov 2, 2020 · 3 comments · Fixed by #17723
Milestone
iteration 15

Comments

@Timer
Copy link
Member

Timer commented Nov 2, 2020

image

The font size is affected by the user’s style sheet (I had a global style for pre)

html, body { font-size: 20px }
@Timer Timer added the kind: bug label Nov 2, 2020
@Timer Timer added this to the 10.x.x milestone Nov 2, 2020
@lachlanjc
Copy link
Contributor

Does #17723 fix this?

@Timer
Copy link
Member Author

Timer commented Dec 31, 2020

Looks like it.

@Timer Timer mentioned this issue Dec 31, 2020
Merged
@kodiakhq kodiakhq bot closed this as completed in #17723 Dec 31, 2020
kodiakhq bot pushed a commit that referenced this issue Dec 31, 2020
@zimv
Fix react-dev-overlay rem style conflict (#17723)
088f374 
### Don‘t use rem in react-dev-overlay.
If we create a nextjs project and use css rem. We could set the html fontsize to any 'px'.  The react-dev-overlay components styles will be affected so that the style becomes larger or smaller.

![image](https://user-images.githubusercontent.com/10840654/95490394-c189a800-09ca-11eb-816a-8bcaf6bcb657.png)
## So i suggest change the rem to px.
## After modification：
![image](https://user-images.githubusercontent.com/10840654/95490703-2e9d3d80-09cb-11eb-8369-7ec650fa6c52.png)

---

Fixes #18680
@Timer Timer modified the milestones: 10.x.x, iteration 15 Dec 31, 2020
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
iteration 15
Development

Successfully merging a pull request may close this issue.

Fix react-dev-overlay rem style conflict zimv/next.js
3 participants
@Timer @lachlanjc @balazsorban44