Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEXT-1281] Support moduleResolution bundler in tsconfig.json #47858

Closed
1 task done
joshuajaco opened this issue Apr 3, 2023 · 2 comments · Fixed by #51065
Closed
1 task done

[NEXT-1281] Support moduleResolution bundler in tsconfig.json #47858

joshuajaco opened this issue Apr 3, 2023 · 2 comments · Fixed by #51065
Assignees
Labels
TypeScript Related to types with Next.js.

Comments

@joshuajaco
Copy link

joshuajaco commented Apr 3, 2023

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

Operating System:
      Platform: darwin
      Arch: arm64
      Version: Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:29 PDT 2022; root:xnu-8020.121.3~4/RELEASE_ARM64_T8101
    Binaries:
      Node: 18.4.0
      npm: 8.12.1
      Yarn: 1.22.19
      pnpm: 7.2.1
    Relevant packages:
      next: 13.2.5-canary.28
      eslint-config-next: 13.2.4
      react: 18.2.0
      react-dom: 18.2.0

Which area(s) of Next.js are affected? (leave empty if unsure)

TypeScript

Link to the code that reproduces this issue

https://codesandbox.io/p/sandbox/relaxed-tess-ylwq9s?file=%2Ftsconfig.json&selection=%5B%7B%22endColumn%22%3A55%2C%22endLineNumber%22%3A18%2C%22startColumn%22%3A55%2C%22startLineNumber%22%3A18%7D%5D

To Reproduce

Set compilerOptions.moduleResolution to bundler in tsconfig.json

Describe the Bug

When setting the moduleResolution to bundler in tsconfig.json it will be reset to node when running next build.

Expected Behavior

It should allow bundler as it has been added in typescript@5

Which browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

No response

NEXT-1281

@joshuajaco joshuajaco added the bug Issue was opened via the bug report template. label Apr 3, 2023
@github-actions github-actions bot added the TypeScript Related to types with Next.js. label Apr 3, 2023
@jthoward64
Copy link

Relevant code is here

@styfle styfle added kind: bug and removed bug Issue was opened via the bug report template. labels Jun 9, 2023
@styfle styfle self-assigned this Jun 9, 2023
@styfle styfle changed the title Support moduleResolution bundler in tsconfig.json [NEXT-1281] Support moduleResolution bundler in tsconfig.json Jun 9, 2023
@kodiakhq kodiakhq bot closed this as completed in #51065 Jun 9, 2023
kodiakhq bot pushed a commit that referenced this issue Jun 9, 2023
@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
TypeScript Related to types with Next.js.
Projects
None yet
3 participants