-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option arg to changeState when onlyAHashChange #10003
Conversation
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
buildDuration | 12.9s | 12.9s | |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons) Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.js gzip | 5.11 kB | 5.11 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..9881.js gzip | 13.7 kB | 13.7 kB | -2 B |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 67.4 kB | 67.4 kB | -2 B |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.17 kB | 4.17 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.5 kB | 12.5 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 62.1 kB | 62.1 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.9 kB | 2.9 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.87 kB | 9.87 kB | ✓ |
Client Pages Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.module.js gzip | 757 B | 757 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.47 kB | 2.47 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.41 kB | 7.41 kB | ✓ |
Client Build Manifests
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
index.html gzip | 1.02 kB | 1.02 kB | -1 B |
link.html gzip | 1.03 kB | 1.03 kB | -2 B |
withRouter.html gzip | 1.01 kB | 1.01 kB | -1 B |
Overall change | 3.06 kB | 3.06 kB | -4 B |
Diffs
Diff for de003c3a9d30..26.module.js
@@ -2052,7 +2052,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
if (!options._h && this.onlyAHashChange(as)) {
this.asPath = as
Router.events.emit('hashChangeStart', as)
- this.changeState(method, url, addBasePath(as))
+ this.changeState(method, url, addBasePath(as), options)
this.scrollToHash(as)
Router.events.emit('hashChangeComplete', as)
return resolve(true)
Diff for de003c3a9d30..ba6a65095.js
@@ -1732,7 +1732,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
_this2.asPath = as
Router.events.emit('hashChangeStart', as)
- _this2.changeState(method, url, addBasePath(as))
+ _this2.changeState(method, url, addBasePath(as), options)
_this2.scrollToHash(as)
Diff for index.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d9b3b214074605052c26.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d99641aeb40abfb78dcb.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -151,13 +151,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.fb89e23b574ba6a65095.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0d425f52ae7a8e628654.js"
defer=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d9b3b214074605052c26.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d99641aeb40abfb78dcb.module.js"
defer=""
crossorigin="anonymous"
type="module"
Diff for link.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d9b3b214074605052c26.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d99641aeb40abfb78dcb.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -156,13 +156,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.fb89e23b574ba6a65095.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0d425f52ae7a8e628654.js"
defer=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d9b3b214074605052c26.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d99641aeb40abfb78dcb.module.js"
defer=""
crossorigin="anonymous"
type="module"
Diff for withRouter.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d9b3b214074605052c26.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d99641aeb40abfb78dcb.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -151,13 +151,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.fb89e23b574ba6a65095.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0d425f52ae7a8e628654.js"
defer=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d9b3b214074605052c26.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d99641aeb40abfb78dcb.module.js"
defer=""
crossorigin="anonymous"
type="module"
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
buildDuration | 13.2s | 13.2s | -12ms |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.js gzip | 5.11 kB | 5.11 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..9881.js gzip | 13.7 kB | N/A | N/A |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
de003c3a9d30..eb8e.js gzip | N/A | 13.7 kB | N/A |
Overall change | 67.4 kB | 67.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.17 kB | 4.17 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.5 kB | N/A | N/A |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
de003c3a9d30..dule.js gzip | N/A | 12.5 kB | N/A |
Overall change | 62.1 kB | 62.1 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.9 kB | 2.9 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.87 kB | 9.87 kB | ✓ |
Client Pages Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.module.js gzip | 757 B | 757 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.47 kB | 2.47 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.41 kB | 7.41 kB | ✓ |
Client Build Manifests
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_error.js gzip | 77.8 kB | 77.7 kB | -3 B |
hooks.html gzip | 1.05 kB | 1.05 kB | ✓ |
index.js gzip | 78 kB | 78 kB | -3 B |
link.js gzip | 80.4 kB | 80.4 kB | -2 B |
routerDirect.js gzip | 78 kB | 78 kB | -3 B |
withRouter.js gzip | 78.1 kB | 78.1 kB | -3 B |
Overall change | 393 kB | 393 kB | -14 B |
Commit: d5e6110
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking on a review from @timneutkens
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
buildDuration | 13.3s | 13.3s | |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons) Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.js gzip | 5.11 kB | 5.11 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..5e9b.js gzip | 13.7 kB | 13.7 kB | -2 B |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 67.4 kB | 67.4 kB | -2 B |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.17 kB | 4.17 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.5 kB | 12.5 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 62.1 kB | 62.1 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.9 kB | 2.9 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.87 kB | 9.87 kB | ✓ |
Client Pages Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.module.js gzip | 757 B | 757 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.47 kB | 2.47 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.41 kB | 7.41 kB | ✓ |
Client Build Manifests
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes Overall increase ⚠️
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
index.html gzip | 1.02 kB | 1.02 kB | |
link.html gzip | 1.03 kB | 1.03 kB | |
withRouter.html gzip | 1.02 kB | 1.02 kB | ✓ |
Overall change | 3.06 kB | 3.07 kB |
Diffs
Diff for de003c3a9d30..89.module.js
@@ -2052,7 +2052,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
if (!options._h && this.onlyAHashChange(as)) {
this.asPath = as
Router.events.emit('hashChangeStart', as)
- this.changeState(method, url, addBasePath(as))
+ this.changeState(method, url, addBasePath(as), options)
this.scrollToHash(as)
Router.events.emit('hashChangeComplete', as)
return resolve(true)
Diff for de003c3a9d30..9bfc85db8.js
@@ -1732,7 +1732,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
_this2.asPath = as
Router.events.emit('hashChangeStart', as)
- _this2.changeState(method, url, addBasePath(as))
+ _this2.changeState(method, url, addBasePath(as), options)
_this2.scrollToHash(as)
Diff for index.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9ab3fbe53b1e24e1cc89.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f1c8d2e4d6dfbad95613.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -151,13 +151,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9c09c7d5ed09bfc85db8.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9d19eb95b8ae8a9c588e.js"
defer=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9ab3fbe53b1e24e1cc89.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f1c8d2e4d6dfbad95613.module.js"
defer=""
crossorigin="anonymous"
type="module"
Diff for link.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9ab3fbe53b1e24e1cc89.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f1c8d2e4d6dfbad95613.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -156,13 +156,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9c09c7d5ed09bfc85db8.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9d19eb95b8ae8a9c588e.js"
defer=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9ab3fbe53b1e24e1cc89.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f1c8d2e4d6dfbad95613.module.js"
defer=""
crossorigin="anonymous"
type="module"
Diff for withRouter.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9ab3fbe53b1e24e1cc89.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f1c8d2e4d6dfbad95613.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -151,13 +151,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9c09c7d5ed09bfc85db8.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9d19eb95b8ae8a9c588e.js"
defer=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9ab3fbe53b1e24e1cc89.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f1c8d2e4d6dfbad95613.module.js"
defer=""
crossorigin="anonymous"
type="module"
Serverless Mode (Increase detected ⚠️ )
General Overall increase ⚠️
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
buildDuration | 13.8s | 13.9s | |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.js gzip | 5.11 kB | 5.11 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..5e9b.js gzip | 13.7 kB | N/A | N/A |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
de003c3a9d30..0e29.js gzip | N/A | 13.7 kB | N/A |
Overall change | 67.4 kB | 67.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.17 kB | 4.17 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.5 kB | N/A | N/A |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
de003c3a9d30..dule.js gzip | N/A | 12.5 kB | N/A |
Overall change | 62.1 kB | 62.1 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.9 kB | 2.9 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.87 kB | 9.87 kB | ✓ |
Client Pages Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.module.js gzip | 757 B | 757 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.47 kB | 2.47 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.41 kB | 7.41 kB | ✓ |
Client Build Manifests
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_error.js gzip | 76.1 kB | 76.1 kB | |
hooks.html gzip | 1.05 kB | 1.05 kB | |
index.js gzip | 76.3 kB | 76.3 kB | |
link.js gzip | 78.3 kB | 78.3 kB | ✓ |
routerDirect.js gzip | 76.4 kB | 76.4 kB | |
withRouter.js gzip | 76.5 kB | 76.5 kB | |
Overall change | 385 kB | 385 kB |
Commit: 7aad614
Hi @timneutkens, this is a tiny change. Can you please approve? |
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
buildDuration | 14.4s | 14.2s | -156ms |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons) Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.js gzip | 5.1 kB | 5.1 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..e54b.js gzip | 13.7 kB | 13.7 kB | -2 B |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 67.4 kB | 67.4 kB | -2 B |
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.16 kB | 4.16 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.5 kB | 12.5 kB | -1 B |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 62.1 kB | 62.1 kB | -1 B |
Legacy Client Bundles (polyfills)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.9 kB | 2.9 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.87 kB | 9.87 kB | ✓ |
Client Pages Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.module.js gzip | 757 B | 757 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.47 kB | 2.47 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.41 kB | 7.41 kB | ✓ |
Client Build Manifests
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
index.html gzip | 1.02 kB | 1.02 kB | -2 B |
link.html gzip | 1.03 kB | 1.03 kB | -1 B |
withRouter.html gzip | 1.01 kB | 1.02 kB | |
Overall change | 3.07 kB | 3.06 kB | -2 B |
Diffs
Diff for de003c3a9d30..e4.module.js
@@ -2052,7 +2052,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
if (!options._h && this.onlyAHashChange(as)) {
this.asPath = as
Router.events.emit('hashChangeStart', as)
- this.changeState(method, url, addBasePath(as))
+ this.changeState(method, url, addBasePath(as), options)
this.scrollToHash(as)
Router.events.emit('hashChangeComplete', as)
return resolve(true)
Diff for de003c3a9d30..0b02858bf.js
@@ -1732,7 +1732,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
_this2.asPath = as
Router.events.emit('hashChangeStart', as)
- _this2.changeState(method, url, addBasePath(as))
+ _this2.changeState(method, url, addBasePath(as), options)
_this2.scrollToHash(as)
Diff for index.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -151,13 +151,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f292cf66b770b02858bf.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4e7513263e507392a811.js"
defer=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
defer=""
crossorigin="anonymous"
type="module"
Diff for link.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -156,13 +156,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f292cf66b770b02858bf.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4e7513263e507392a811.js"
defer=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
defer=""
crossorigin="anonymous"
type="module"
Diff for withRouter.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -151,13 +151,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f292cf66b770b02858bf.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4e7513263e507392a811.js"
defer=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
defer=""
crossorigin="anonymous"
type="module"
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
buildDuration | 14.6s | 15s | |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.js gzip | 5.1 kB | 5.1 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..e54b.js gzip | 13.7 kB | N/A | N/A |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
de003c3a9d30..dab8.js gzip | N/A | 13.7 kB | N/A |
Overall change | 67.4 kB | 67.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.16 kB | 4.16 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.5 kB | N/A | N/A |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
de003c3a9d30..dule.js gzip | N/A | 12.5 kB | N/A |
Overall change | 62.1 kB | 62.1 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.9 kB | 2.9 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.87 kB | 9.87 kB | ✓ |
Client Pages Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.module.js gzip | 757 B | 757 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.47 kB | 2.47 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.41 kB | 7.41 kB | ✓ |
Client Build Manifests
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_error.js gzip | 77.8 kB | 77.8 kB | -3 B |
hooks.html gzip | 1.05 kB | 1.05 kB | ✓ |
index.js gzip | 78 kB | 78 kB | -2 B |
link.js gzip | 80.4 kB | 80.4 kB | -2 B |
routerDirect.js gzip | 78.1 kB | 78.1 kB | -2 B |
withRouter.js gzip | 78.1 kB | 78.1 kB | -3 B |
Overall change | 393 kB | 393 kB | -12 B |
Commit: 8f7f98d
It’s not a tiny change, you’re exposing completely new behavior for something that is likely to break (history state). We’ll review when possible but I’m not sure it will be landed. |
@timneutkens Well, note that the Therefore, I would consider this PR a bug fix. Plus, I need this fix in order to get my modal that has tabs with hashed routes to work. |
@rscotten ah your description in the PR made it seems like something different! 🙏 Can you add integration tests for this change to
Note that this is undesired behavior. |
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
buildDuration | 14s | 14.9s | |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons) Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.js gzip | 5.1 kB | 5.1 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..e54b.js gzip | 13.7 kB | 13.7 kB | -2 B |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 67.4 kB | 67.4 kB | -2 B |
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.16 kB | 4.16 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.5 kB | 12.5 kB | -1 B |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 62.1 kB | 62.1 kB | -1 B |
Legacy Client Bundles (polyfills)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.9 kB | 2.9 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.87 kB | 9.87 kB | ✓ |
Client Pages Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.module.js gzip | 757 B | 757 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.47 kB | 2.47 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.41 kB | 7.41 kB | ✓ |
Client Build Manifests
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
index.html gzip | 1.02 kB | 1.02 kB | -2 B |
link.html gzip | 1.03 kB | 1.03 kB | -1 B |
withRouter.html gzip | 1.01 kB | 1.02 kB | |
Overall change | 3.07 kB | 3.06 kB | -2 B |
Diffs
Diff for de003c3a9d30..e4.module.js
@@ -2052,7 +2052,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
if (!options._h && this.onlyAHashChange(as)) {
this.asPath = as
Router.events.emit('hashChangeStart', as)
- this.changeState(method, url, addBasePath(as))
+ this.changeState(method, url, addBasePath(as), options)
this.scrollToHash(as)
Router.events.emit('hashChangeComplete', as)
return resolve(true)
Diff for de003c3a9d30..0b02858bf.js
@@ -1732,7 +1732,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
_this2.asPath = as
Router.events.emit('hashChangeStart', as)
- _this2.changeState(method, url, addBasePath(as))
+ _this2.changeState(method, url, addBasePath(as), options)
_this2.scrollToHash(as)
Diff for index.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -151,13 +151,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f292cf66b770b02858bf.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4e7513263e507392a811.js"
defer=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
defer=""
crossorigin="anonymous"
type="module"
Diff for link.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -156,13 +156,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f292cf66b770b02858bf.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4e7513263e507392a811.js"
defer=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
defer=""
crossorigin="anonymous"
type="module"
Diff for withRouter.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -151,13 +151,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f292cf66b770b02858bf.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4e7513263e507392a811.js"
defer=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
defer=""
crossorigin="anonymous"
type="module"
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
buildDuration | 15s | 15.4s | |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.js gzip | 5.1 kB | 5.1 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..e54b.js gzip | 13.7 kB | N/A | N/A |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
de003c3a9d30..dab8.js gzip | N/A | 13.7 kB | N/A |
Overall change | 67.4 kB | 67.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.16 kB | 4.16 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.5 kB | N/A | N/A |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
de003c3a9d30..dule.js gzip | N/A | 12.5 kB | N/A |
Overall change | 62.1 kB | 62.1 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.9 kB | 2.9 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.87 kB | 9.87 kB | ✓ |
Client Pages Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.module.js gzip | 757 B | 757 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.47 kB | 2.47 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.41 kB | 7.41 kB | ✓ |
Client Build Manifests
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_error.js gzip | 77.9 kB | 77.9 kB | -3 B |
hooks.html gzip | 1.05 kB | 1.05 kB | ✓ |
index.js gzip | 78.1 kB | 78.1 kB | -1 B |
link.js gzip | 80.6 kB | 80.6 kB | -3 B |
routerDirect.js gzip | 78.2 kB | 78.2 kB | -2 B |
withRouter.js gzip | 78.3 kB | 78.3 kB | -2 B |
Overall change | 394 kB | 394 kB | -11 B |
Commit: 8d44581
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
buildDuration | 13.8s | 14s | |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons) Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.js gzip | 5.1 kB | 5.1 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..e54b.js gzip | 13.7 kB | 13.7 kB | -2 B |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 67.4 kB | 67.4 kB | -2 B |
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.16 kB | 4.16 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.5 kB | 12.5 kB | -1 B |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 62.1 kB | 62.1 kB | -1 B |
Legacy Client Bundles (polyfills)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.9 kB | 2.9 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.87 kB | 9.87 kB | ✓ |
Client Pages Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.module.js gzip | 757 B | 757 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.47 kB | 2.47 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.41 kB | 7.41 kB | ✓ |
Client Build Manifests
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
index.html gzip | 1.02 kB | 1.02 kB | -2 B |
link.html gzip | 1.03 kB | 1.03 kB | -1 B |
withRouter.html gzip | 1.01 kB | 1.02 kB | |
Overall change | 3.07 kB | 3.06 kB | -2 B |
Diffs
Diff for de003c3a9d30..e4.module.js
@@ -2052,7 +2052,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
if (!options._h && this.onlyAHashChange(as)) {
this.asPath = as
Router.events.emit('hashChangeStart', as)
- this.changeState(method, url, addBasePath(as))
+ this.changeState(method, url, addBasePath(as), options)
this.scrollToHash(as)
Router.events.emit('hashChangeComplete', as)
return resolve(true)
Diff for de003c3a9d30..0b02858bf.js
@@ -1732,7 +1732,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
_this2.asPath = as
Router.events.emit('hashChangeStart', as)
- _this2.changeState(method, url, addBasePath(as))
+ _this2.changeState(method, url, addBasePath(as), options)
_this2.scrollToHash(as)
Diff for index.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -151,13 +151,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f292cf66b770b02858bf.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4e7513263e507392a811.js"
defer=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
defer=""
crossorigin="anonymous"
type="module"
Diff for link.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -156,13 +156,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f292cf66b770b02858bf.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4e7513263e507392a811.js"
defer=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
defer=""
crossorigin="anonymous"
type="module"
Diff for withRouter.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -151,13 +151,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f292cf66b770b02858bf.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4e7513263e507392a811.js"
defer=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
defer=""
crossorigin="anonymous"
type="module"
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
buildDuration | 14.4s | 14.6s | |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.js gzip | 5.1 kB | 5.1 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..e54b.js gzip | 13.7 kB | N/A | N/A |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
de003c3a9d30..dab8.js gzip | N/A | 13.7 kB | N/A |
Overall change | 67.4 kB | 67.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.16 kB | 4.16 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.5 kB | N/A | N/A |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
de003c3a9d30..dule.js gzip | N/A | 12.5 kB | N/A |
Overall change | 62.1 kB | 62.1 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.9 kB | 2.9 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.87 kB | 9.87 kB | ✓ |
Client Pages Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.module.js gzip | 757 B | 757 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.47 kB | 2.47 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.41 kB | 7.41 kB | ✓ |
Client Build Manifests
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_error.js gzip | 77.9 kB | 77.9 kB | -3 B |
hooks.html gzip | 1.05 kB | 1.05 kB | ✓ |
index.js gzip | 78.1 kB | 78.1 kB | -1 B |
link.js gzip | 80.6 kB | 80.6 kB | -3 B |
routerDirect.js gzip | 78.2 kB | 78.2 kB | -2 B |
withRouter.js gzip | 78.3 kB | 78.3 kB | -2 B |
Overall change | 394 kB | 394 kB | -11 B |
Commit: cda302f
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
buildDuration | 15.4s | 21.8s | |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons) Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.js gzip | 5.1 kB | 5.1 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..e54b.js gzip | 13.7 kB | 13.7 kB | -2 B |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 67.4 kB | 67.4 kB | -2 B |
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.16 kB | 4.16 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.5 kB | 12.5 kB | -1 B |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 62.1 kB | 62.1 kB | -1 B |
Legacy Client Bundles (polyfills)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.9 kB | 2.9 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.87 kB | 9.87 kB | ✓ |
Client Pages Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.module.js gzip | 757 B | 757 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.47 kB | 2.47 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.41 kB | 7.41 kB | ✓ |
Client Build Manifests
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
index.html gzip | 1.02 kB | 1.02 kB | -2 B |
link.html gzip | 1.03 kB | 1.03 kB | -1 B |
withRouter.html gzip | 1.01 kB | 1.02 kB | |
Overall change | 3.07 kB | 3.06 kB | -2 B |
Diffs
Diff for de003c3a9d30..e4.module.js
@@ -2052,7 +2052,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
if (!options._h && this.onlyAHashChange(as)) {
this.asPath = as
Router.events.emit('hashChangeStart', as)
- this.changeState(method, url, addBasePath(as))
+ this.changeState(method, url, addBasePath(as), options)
this.scrollToHash(as)
Router.events.emit('hashChangeComplete', as)
return resolve(true)
Diff for de003c3a9d30..0b02858bf.js
@@ -1732,7 +1732,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
_this2.asPath = as
Router.events.emit('hashChangeStart', as)
- _this2.changeState(method, url, addBasePath(as))
+ _this2.changeState(method, url, addBasePath(as), options)
_this2.scrollToHash(as)
Diff for index.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -151,13 +151,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f292cf66b770b02858bf.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4e7513263e507392a811.js"
defer=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
defer=""
crossorigin="anonymous"
type="module"
Diff for link.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -156,13 +156,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f292cf66b770b02858bf.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4e7513263e507392a811.js"
defer=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
defer=""
crossorigin="anonymous"
type="module"
Diff for withRouter.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -151,13 +151,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.f292cf66b770b02858bf.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4e7513263e507392a811.js"
defer=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.c5cfe57ad45f291e53e4.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f5232d5a35ad9d4b103.module.js"
defer=""
crossorigin="anonymous"
type="module"
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
buildDuration | 17.7s | 16.1s | -1.6s |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.js gzip | 5.1 kB | 5.1 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..e54b.js gzip | 13.7 kB | N/A | N/A |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
de003c3a9d30..dab8.js gzip | N/A | 13.7 kB | N/A |
Overall change | 67.4 kB | 67.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.16 kB | 4.16 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.5 kB | N/A | N/A |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
de003c3a9d30..dule.js gzip | N/A | 12.5 kB | N/A |
Overall change | 62.1 kB | 62.1 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.9 kB | 2.9 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.87 kB | 9.87 kB | ✓ |
Client Pages Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.module.js gzip | 757 B | 757 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.47 kB | 2.47 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.41 kB | 7.41 kB | ✓ |
Client Build Manifests
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_error.js gzip | 77.9 kB | 77.9 kB | -3 B |
hooks.html gzip | 1.05 kB | 1.05 kB | ✓ |
index.js gzip | 78.1 kB | 78.1 kB | -1 B |
link.js gzip | 80.6 kB | 80.6 kB | -3 B |
routerDirect.js gzip | 78.2 kB | 78.2 kB | -2 B |
withRouter.js gzip | 78.3 kB | 78.3 kB | -2 B |
Overall change | 394 kB | 394 kB | -11 B |
Commit: 70a2ec0
@timneutkens Integration tests added :) |
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
buildDuration | 14.4s | 14.6s | |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons) Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.js gzip | 5.11 kB | 5.11 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..8249.js gzip | 13.7 kB | 13.7 kB | -1 B |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 67.5 kB | 67.5 kB | -1 B |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.17 kB | 4.17 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.5 kB | 12.5 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 62.1 kB | 62.1 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.js gzip | 1.34 kB | 1.34 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.9 kB | 2.9 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.87 kB | 9.87 kB | ✓ |
Client Pages Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.module.js gzip | 769 B | 769 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.47 kB | 2.47 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.42 kB | 7.42 kB | ✓ |
Client Build Manifests
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
index.html gzip | 1.02 kB | 1.02 kB | -3 B |
link.html gzip | 1.03 kB | 1.03 kB | -1 B |
withRouter.html gzip | 1.02 kB | 1.02 kB | -2 B |
Overall change | 3.08 kB | 3.07 kB | -6 B |
Diffs
Diff for de003c3a9d30..6c.module.js
@@ -2054,7 +2054,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
if (!options._h && this.onlyAHashChange(as)) {
this.asPath = as
Router.events.emit('hashChangeStart', as)
- this.changeState(method, url, addBasePath(as))
+ this.changeState(method, url, addBasePath(as), options)
this.scrollToHash(as)
Router.events.emit('hashChangeComplete', as)
return resolve(true)
Diff for de003c3a9d30..ee55473f0.js
@@ -1734,7 +1734,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
_this2.asPath = as
Router.events.emit('hashChangeStart', as)
- _this2.changeState(method, url, addBasePath(as))
+ _this2.changeState(method, url, addBasePath(as), options)
_this2.scrollToHash(as)
Diff for index.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -151,13 +151,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.89c4b00ceddee55473f0.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.329e15c764091f4552b5.js"
async=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
async=""
crossorigin="anonymous"
type="module"
Diff for link.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -156,13 +156,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.89c4b00ceddee55473f0.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.329e15c764091f4552b5.js"
async=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
async=""
crossorigin="anonymous"
type="module"
Diff for withRouter.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -151,13 +151,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.89c4b00ceddee55473f0.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.329e15c764091f4552b5.js"
async=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
async=""
crossorigin="anonymous"
type="module"
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
buildDuration | 15.4s | 15.2s | -157ms |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.js gzip | 5.11 kB | 5.11 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..8249.js gzip | 13.7 kB | N/A | N/A |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
de003c3a9d30..fffc.js gzip | N/A | 13.7 kB | N/A |
Overall change | 67.5 kB | 67.5 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.17 kB | 4.17 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.5 kB | N/A | N/A |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
de003c3a9d30..dule.js gzip | N/A | 12.5 kB | N/A |
Overall change | 62.1 kB | 62.1 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.js gzip | 1.34 kB | 1.34 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.9 kB | 2.9 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.87 kB | 9.87 kB | ✓ |
Client Pages Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.module.js gzip | 769 B | 769 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.47 kB | 2.47 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.42 kB | 7.42 kB | ✓ |
Client Build Manifests
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_error.js gzip | 70.9 kB | 70.9 kB | |
hooks.html gzip | 1.06 kB | 1.05 kB | -2 B |
index.js gzip | 71.3 kB | 71.3 kB | |
link.js gzip | 80.6 kB | 80.6 kB | |
routerDirect.js gzip | 78.2 kB | 78.2 kB | |
withRouter.js gzip | 78.3 kB | 78.3 kB | ✓ |
Overall change | 380 kB | 380 kB |
Commit: 1583752
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
buildDuration | 10.1s | 10.1s | |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons) Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.js gzip | 5.11 kB | 5.11 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..8249.js gzip | 13.7 kB | 13.7 kB | -1 B |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 67.5 kB | 67.5 kB | -1 B |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.17 kB | 4.17 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.5 kB | 12.5 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 62.1 kB | 62.1 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.js gzip | 1.34 kB | 1.34 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.9 kB | 2.9 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.87 kB | 9.87 kB | ✓ |
Client Pages Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.module.js gzip | 769 B | 769 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.47 kB | 2.47 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.42 kB | 7.42 kB | ✓ |
Client Build Manifests
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
index.html gzip | 1.02 kB | 1.02 kB | -3 B |
link.html gzip | 1.03 kB | 1.03 kB | -1 B |
withRouter.html gzip | 1.02 kB | 1.02 kB | -2 B |
Overall change | 3.08 kB | 3.07 kB | -6 B |
Diffs
Diff for de003c3a9d30..6c.module.js
@@ -2054,7 +2054,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
if (!options._h && this.onlyAHashChange(as)) {
this.asPath = as
Router.events.emit('hashChangeStart', as)
- this.changeState(method, url, addBasePath(as))
+ this.changeState(method, url, addBasePath(as), options)
this.scrollToHash(as)
Router.events.emit('hashChangeComplete', as)
return resolve(true)
Diff for de003c3a9d30..ee55473f0.js
@@ -1734,7 +1734,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
_this2.asPath = as
Router.events.emit('hashChangeStart', as)
- _this2.changeState(method, url, addBasePath(as))
+ _this2.changeState(method, url, addBasePath(as), options)
_this2.scrollToHash(as)
Diff for index.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -151,13 +151,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.89c4b00ceddee55473f0.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.329e15c764091f4552b5.js"
async=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
async=""
crossorigin="anonymous"
type="module"
Diff for link.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -156,13 +156,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.89c4b00ceddee55473f0.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.329e15c764091f4552b5.js"
async=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
async=""
crossorigin="anonymous"
type="module"
Diff for withRouter.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -151,13 +151,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.89c4b00ceddee55473f0.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.329e15c764091f4552b5.js"
async=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
async=""
crossorigin="anonymous"
type="module"
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
buildDuration | 10.7s | 10.7s | |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.js gzip | 5.11 kB | 5.11 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..8249.js gzip | 13.7 kB | N/A | N/A |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
de003c3a9d30..fffc.js gzip | N/A | 13.7 kB | N/A |
Overall change | 67.5 kB | 67.5 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.17 kB | 4.17 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.5 kB | N/A | N/A |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
de003c3a9d30..dule.js gzip | N/A | 12.5 kB | N/A |
Overall change | 62.1 kB | 62.1 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.js gzip | 1.34 kB | 1.34 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.9 kB | 2.9 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.87 kB | 9.87 kB | ✓ |
Client Pages Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.module.js gzip | 769 B | 769 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.47 kB | 2.47 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.42 kB | 7.42 kB | ✓ |
Client Build Manifests
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_error.js gzip | 70.9 kB | 70.9 kB | |
hooks.html gzip | 1.06 kB | 1.05 kB | -2 B |
index.js gzip | 71.3 kB | 71.3 kB | |
link.js gzip | 80.6 kB | 80.6 kB | |
routerDirect.js gzip | 78.2 kB | 78.2 kB | |
withRouter.js gzip | 78.3 kB | 78.3 kB | ✓ |
Overall change | 380 kB | 380 kB |
Commit: f379e07
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
buildDuration | 13.1s | 12.9s | -198ms |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons) Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.js gzip | 5.11 kB | 5.11 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..8249.js gzip | 13.7 kB | 13.7 kB | -1 B |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 67.5 kB | 67.5 kB | -1 B |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.17 kB | 4.17 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.5 kB | 12.5 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 62.1 kB | 62.1 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.js gzip | 1.34 kB | 1.34 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.9 kB | 2.9 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.87 kB | 9.87 kB | ✓ |
Client Pages Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.module.js gzip | 769 B | 769 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.47 kB | 2.47 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.42 kB | 7.42 kB | ✓ |
Client Build Manifests
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes Overall decrease ✓
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
index.html gzip | 1.02 kB | 1.02 kB | -3 B |
link.html gzip | 1.03 kB | 1.03 kB | -1 B |
withRouter.html gzip | 1.02 kB | 1.02 kB | -2 B |
Overall change | 3.08 kB | 3.07 kB | -6 B |
Diffs
Diff for de003c3a9d30..6c.module.js
@@ -2054,7 +2054,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
if (!options._h && this.onlyAHashChange(as)) {
this.asPath = as
Router.events.emit('hashChangeStart', as)
- this.changeState(method, url, addBasePath(as))
+ this.changeState(method, url, addBasePath(as), options)
this.scrollToHash(as)
Router.events.emit('hashChangeComplete', as)
return resolve(true)
Diff for de003c3a9d30..ee55473f0.js
@@ -1734,7 +1734,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
_this2.asPath = as
Router.events.emit('hashChangeStart', as)
- _this2.changeState(method, url, addBasePath(as))
+ _this2.changeState(method, url, addBasePath(as), options)
_this2.scrollToHash(as)
Diff for index.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -151,13 +151,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.89c4b00ceddee55473f0.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.329e15c764091f4552b5.js"
async=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
async=""
crossorigin="anonymous"
type="module"
Diff for link.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -156,13 +156,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.89c4b00ceddee55473f0.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.329e15c764091f4552b5.js"
async=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
async=""
crossorigin="anonymous"
type="module"
Diff for withRouter.html
@@ -39,7 +39,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
+ href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
as="script"
crossorigin="anonymous"
/>
@@ -151,13 +151,13 @@
type="module"
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.89c4b00ceddee55473f0.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.329e15c764091f4552b5.js"
async=""
crossorigin="anonymous"
nomodule=""
></script
><script
- src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.496ede6c86451709e76c.module.js"
+ src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
async=""
crossorigin="anonymous"
type="module"
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
buildDuration | 13.1s | 13s | -48ms |
nodeModulesSize | 48.9 MB | 48.9 MB |
Client Bundles (main, webpack, commons)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.js gzip | 5.11 kB | 5.11 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..54d3.js gzip | 4.68 kB | 4.68 kB | ✓ |
commons.HASH.js gzip | 4.06 kB | 4.06 kB | ✓ |
de003c3a9d30..8249.js gzip | 13.7 kB | N/A | N/A |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
de003c3a9d30..fffc.js gzip | N/A | 13.7 kB | N/A |
Overall change | 67.5 kB | 67.5 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.17 kB | 4.17 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
4952ddcd88e7..dule.js gzip | 5.56 kB | 5.56 kB | ✓ |
de003c3a9d30..dule.js gzip | 12.5 kB | N/A | N/A |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
de003c3a9d30..dule.js gzip | N/A | 12.5 kB | N/A |
Overall change | 62.1 kB | 62.1 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 4.76 kB | 4.76 kB | ✓ |
Overall change | 4.76 kB | 4.76 kB | ✓ |
Client Pages
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.js gzip | 1.34 kB | 1.34 kB | ✓ |
_error.js gzip | 4.07 kB | 4.07 kB | ✓ |
hooks.js gzip | 779 B | 779 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.9 kB | 2.9 kB | ✓ |
routerDirect.js gzip | 283 B | 283 B | ✓ |
withRouter.js gzip | 282 B | 282 B | ✓ |
Overall change | 9.87 kB | 9.87 kB | ✓ |
Client Pages Modern
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_app.module.js gzip | 769 B | 769 B | ✓ |
_error.module.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks.module.js gzip | 371 B | 371 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 2.47 kB | 2.47 kB | ✓ |
routerDirect..dule.js gzip | 273 B | 273 B | ✓ |
withRouter.m..dule.js gzip | 272 B | 272 B | ✓ |
Overall change | 7.42 kB | 7.42 kB | ✓ |
Client Build Manifests
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
zeit/next.js canary | rscotten/next.js add-options-to-href-change | Change | |
---|---|---|---|
_error.js gzip | 70.9 kB | 70.9 kB | |
hooks.html gzip | 1.06 kB | 1.05 kB | -2 B |
index.js gzip | 71.3 kB | 71.3 kB | |
link.js gzip | 80.6 kB | 80.6 kB | |
routerDirect.js gzip | 78.2 kB | 78.2 kB | |
withRouter.js gzip | 78.3 kB | 78.3 kB | ✓ |
Overall change | 380 kB | 380 kB |
Commit: dc62b85
Thank you, @ijjk !! :) |
This PR adds the
window.history.state.options
object tothis.changeState
when there's only a hash change.This allows the developer to pass state into the browser history for hash changes and consume that state in the client app.