-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed pathname check in router #10547
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4be2b2d
Fixed pathname check in router
dijs e104aef
Updated change and added trial test
dijs 670d0d5
Merge remote-tracking branch 'upstream/canary' into patch-1
ijjk 5065037
Update test
ijjk b1c12e4
Merge branch 'canary' into patch-1
ijjk e167f25
Merge branch 'canary' into patch-1
ijjk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's parse it and grab the
pathname
to make sure we're getting the pathname correctly and let's also move thee.state.as === this.asPath
check above thepathname
one so that if theasPath
mismatches we avoid parsing thepathname
unnecessarilyCan you also add a test in
test/integration/production/index.test.js
similar to theshould navigate to external site and back
test in that file?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the code changes, but I am having a really hard time getting the test enviornment to work on my system. I installed
chromedriver
but the tests are failing with your version only supports v81... Also, every time I runyarn testonly
it completely crushes my machine with all thenode
processes. I added a test, but I am sure the expectations need to be updated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, went ahead and updated the test the rest of the way. Thanks for the PR!