-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Prerender in Emulated Serverless Mode #10660
Conversation
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
buildDuration | 9.6s | 9.8s | |
nodeModulesSize | 56.2 MB | 56.2 MB | ✓ |
Client Bundles (main, webpack, commons)
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
main-HASH.js gzip | 5.05 kB | 5.05 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..b61f.js gzip | 12.3 kB | 12.3 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57.2 kB | 57.2 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.14 kB | 4.14 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 9.22 kB | 9.22 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 53.2 kB | 53.2 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 18.9 kB | 18.9 kB | ✓ |
Overall change | 18.9 kB | 18.9 kB | ✓ |
Client Pages
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
_app.js gzip | 1.06 kB | 1.06 kB | ✓ |
_error.js gzip | 2.98 kB | 2.98 kB | ✓ |
hooks.js gzip | 664 B | 664 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 1.9 kB | 1.9 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 7.38 kB | 7.38 kB | ✓ |
Client Pages Modern
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
_app.module.js gzip | 577 B | 577 B | ✓ |
_error.module.js gzip | 2.08 kB | 2.08 kB | ✓ |
hooks.module.js gzip | 370 B | 370 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 1.48 kB | 1.48 kB | ✓ |
routerDirect..dule.js gzip | 271 B | 271 B | ✓ |
withRouter.m..dule.js gzip | 270 B | 270 B | ✓ |
Overall change | 5.26 kB | 5.26 kB | ✓ |
Client Build Manifests
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
_error.js gzip | 290 kB | 290 kB | -46 B |
404.html gzip | 1.33 kB | 1.33 kB | ✓ |
hooks.html gzip | 963 B | 963 B | ✓ |
index.js gzip | 290 kB | 290 kB | -504 B |
link.js gzip | 298 kB | 298 kB | |
routerDirect.js gzip | 296 kB | 298 kB | |
withRouter.js gzip | 298 kB | 296 kB | -1.38 kB |
Overall change | 1.47 MB | 1.47 MB |
Commit: 064c826
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
buildDuration | 10.4s | 11.3s | |
nodeModulesSize | 56.2 MB | 56.2 MB | ✓ |
Client Bundles (main, webpack, commons)
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
main-HASH.js gzip | 5.05 kB | 5.05 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..b61f.js gzip | 12.3 kB | 12.3 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57.2 kB | 57.2 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.14 kB | 4.14 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 9.22 kB | 9.22 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 53.2 kB | 53.2 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 18.9 kB | 18.9 kB | ✓ |
Overall change | 18.9 kB | 18.9 kB | ✓ |
Client Pages
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
_app.js gzip | 1.06 kB | 1.06 kB | ✓ |
_error.js gzip | 2.98 kB | 2.98 kB | ✓ |
hooks.js gzip | 664 B | 664 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 1.9 kB | 1.9 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 7.38 kB | 7.38 kB | ✓ |
Client Pages Modern
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
_app.module.js gzip | 577 B | 577 B | ✓ |
_error.module.js gzip | 2.08 kB | 2.08 kB | ✓ |
hooks.module.js gzip | 370 B | 370 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 1.48 kB | 1.48 kB | ✓ |
routerDirect..dule.js gzip | 271 B | 271 B | ✓ |
withRouter.m..dule.js gzip | 270 B | 270 B | ✓ |
Overall change | 5.26 kB | 5.26 kB | ✓ |
Client Build Manifests
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
_error.js gzip | 290 kB | 289 kB | -789 B |
404.html gzip | 1.33 kB | 1.33 kB | ✓ |
hooks.html gzip | 963 B | 963 B | ✓ |
index.js gzip | 289 kB | 289 kB | -70 B |
link.js gzip | 298 kB | 298 kB | -73 B |
routerDirect.js gzip | 296 kB | 297 kB | |
withRouter.js gzip | 296 kB | 297 kB | |
Overall change | 1.47 MB | 1.47 MB |
Commit: 064c826
…nto test/emulated-serverless
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
buildDuration | 11.4s | 11.2s | -162ms |
nodeModulesSize | 56.2 MB | 56.2 MB | ✓ |
Client Bundles (main, webpack, commons)
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
main-HASH.js gzip | 5.05 kB | 5.05 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..b61f.js gzip | 12.3 kB | 12.3 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57.2 kB | 57.2 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
main-HASH.module.js gzip | 4.14 kB | 4.14 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 9.22 kB | 9.22 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 53.2 kB | 53.2 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 18.9 kB | 18.9 kB | ✓ |
Overall change | 18.9 kB | 18.9 kB | ✓ |
Client Pages
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
_app.js gzip | 1.06 kB | 1.06 kB | ✓ |
_error.js gzip | 2.98 kB | 2.98 kB | ✓ |
hooks.js gzip | 664 B | 664 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 1.9 kB | 1.9 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 7.38 kB | 7.38 kB | ✓ |
Client Pages Modern
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
_app.module.js gzip | 577 B | 577 B | ✓ |
_error.module.js gzip | 2.08 kB | 2.08 kB | ✓ |
hooks.module.js gzip | 370 B | 370 B | ✓ |
index.module.js gzip | 212 B | 212 B | ✓ |
link.module.js gzip | 1.48 kB | 1.48 kB | ✓ |
routerDirect..dule.js gzip | 271 B | 271 B | ✓ |
withRouter.m..dule.js gzip | 270 B | 270 B | ✓ |
Overall change | 5.26 kB | 5.26 kB | ✓ |
Client Build Manifests
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
zeit/next.js canary | Timer/next.js test/emulated-serverless | Change | |
---|---|---|---|
_error.js gzip | 290 kB | 290 kB | -599 B |
404.html gzip | 1.33 kB | 1.33 kB | ✓ |
hooks.html gzip | 963 B | 963 B | ✓ |
index.js gzip | 289 kB | 289 kB | -32 B |
link.js gzip | 297 kB | 298 kB | |
routerDirect.js gzip | 297 kB | 298 kB | |
withRouter.js gzip | 297 kB | 298 kB | |
Overall change | 1.47 MB | 1.47 MB |
Commit: 5b88b0c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't catch #10598 since we need to send the x-now-route-matches
header to test right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as discussed in Slack
This adds an emulated serverless mode test case.
Related #10598.