Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for static 404 and pages/404 #10811
Add docs for static 404 and pages/404 #10811
Changes from 2 commits
5a8ca82
afbf18a
712754f
03aaf87
5f14ac3
57153f7
44abf47
0899633
182129e
68ec4b5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.js
(even though it could be TS, I think people will understand):pages/404.js
pages/_error.js
is only used in production for non-404 errors" but this paragraph says "takes priority over_error
for 404s" - so 404 may be rendered by_error
? In that case, the earlier sentence was incorrect?specifically
is used twice, I think the second one can be removed.getStaticProps
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I reworked it using the above mentioned structure. Let me know if this seems better