Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes security issues #11234

Closed
wants to merge 1 commit into from
Closed

Fixes security issues #11234

wants to merge 1 commit into from

Conversation

Maetes
Copy link

@Maetes Maetes commented Mar 20, 2020

Got issues from an old version of this package. Simply change the version fix this issue. Tested around but can't find a crash because of this change.

Got issues from an old version of this package. Simply change the version fix this issue. Tested around but can't find a crash because of this change.
@Maetes Maetes requested a review from Timer as a code owner March 20, 2020 18:43
@matamatanot
Copy link
Contributor

https://github.com/isaacs/node-mkdirp/blob/master/CHANGELOG.md

Return a promise instead of taking a callback.

It is a BREAKING CHANGE.

This library maybe unnecessary.
Use fs.mkdir(dir, { recursive: true }, (mkdirError) => {}

rel: Refactor migrate on mkdir by evilebottnawi · Pull Request #499 · webpack/webpack-dev-middleware

@Maetes
Copy link
Author

Maetes commented Mar 21, 2020

https://github.com/isaacs/node-mkdirp/blob/master/CHANGELOG.md

Return a promise instead of taking a callback.

It is a BREAKING CHANGE.

This library maybe unnecessary.
Use fs.mkdir(dir, { recursive: true }, (mkdirError) => {}

rel: Refactor migrate on mkdir by evilebottnawi · Pull Request #499 · webpack/webpack-dev-middleware

totally agree with you. Then it is with a high probability unnecessary...

@Maetes Maetes closed this Mar 21, 2020
@matamatanot
Copy link
Contributor

@universecoders

rel: #11251

@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants