Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ssr-caching example #12180

Merged
merged 7 commits into from
May 22, 2020
Merged

Fix ssr-caching example #12180

merged 7 commits into from
May 22, 2020

Conversation

xliusstk
Copy link
Contributor

cacheable-response.get expects a get(req, res) method signature:
https://www.npmjs.com/package/cacheable-response#get

Before the change:

curl -s  -v http://localhost:3000/blog/first 2>&1 | grep HTTP/1.1
> GET /blog/first HTTP/1.1
< HTTP/1.1 404 Not Found

After the change:

curl -s  -v http://localhost:3000/blog/first 2>&1 | grep HTTP/1.1
> GET /blog/first HTTP/1.1
< HTTP/1.1 200 OK

This is a partial fix of #12019 to make the example work. However it doesn't fix the error

(node:62360) UnhandledPromiseRejectionWarning: Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
``` , which will need a change at server/next-server.ts

See related issue:
https://github.com/zeit/next.js/discussions/11525 
https://github.com/zeit/next.js/issues/11665

@ijjk
Copy link
Member

ijjk commented Apr 24, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
buildDuration 12.5s 13s ⚠️ +493ms
nodeModulesSize 55.2 MB 55.2 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.207 2.208 0
/ avg req/sec 1132.68 1132.43 -0.25
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.271 1.261 -0.01
/error-in-render avg req/sec 1967.72 1983.3 ⚠️ +15.58
Client Bundles (main, webpack, commons)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..45d6.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39 kB 39 kB ✓
Overall change 56.7 kB 56.7 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.87 kB 6.87 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.85 kB 7.85 kB ✓
Client Pages Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
index.html gzip 929 B 929 B ✓
link.html gzip 939 B 939 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
buildDuration 14s 13.5s -478ms
nodeModulesSize 55.2 MB 55.2 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..45d6.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39 kB 39 kB ✓
Overall change 56.7 kB 56.7 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.87 kB 6.87 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.85 kB 7.85 kB ✓
Client Pages Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_error.js 558 kB 558 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 558 kB 558 kB ✓
link.js 595 kB 595 kB ✓
routerDirect.js 587 kB 587 kB ✓
withRouter.js 587 kB 587 kB ✓
Overall change 2.89 MB 2.89 MB ✓

@xliusstk xliusstk marked this pull request as ready for review April 24, 2020 19:44
@ijjk
Copy link
Member

ijjk commented Apr 24, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
buildDuration 11s 11.5s ⚠️ +450ms
nodeModulesSize 55.2 MB 55.2 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.997 2.089 ⚠️ +0.09
/ avg req/sec 1252.05 1196.96 -55.09
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.209 1.127 -0.08
/error-in-render avg req/sec 2068.51 2218.63 ⚠️ +150.12
Client Bundles (main, webpack, commons)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..45d6.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39 kB 39 kB ✓
Overall change 56.7 kB 56.7 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.87 kB 6.87 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.85 kB 7.85 kB ✓
Client Pages Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
index.html gzip 929 B 929 B ✓
link.html gzip 939 B 939 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
buildDuration 11.8s 11.7s -84ms
nodeModulesSize 55.2 MB 55.2 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..45d6.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39 kB 39 kB ✓
Overall change 56.7 kB 56.7 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.87 kB 6.87 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.85 kB 7.85 kB ✓
Client Pages Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_error.js 558 kB 558 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 558 kB 558 kB ✓
link.js 595 kB 595 kB ✓
routerDirect.js 587 kB 587 kB ✓
withRouter.js 587 kB 587 kB ✓
Overall change 2.89 MB 2.89 MB ✓

@ijjk
Copy link
Member

ijjk commented Apr 24, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
buildDuration 13s 12.8s -212ms
nodeModulesSize 55.2 MB 55.2 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.193 2.209 ⚠️ +0.02
/ avg req/sec 1140.15 1131.97 -8.18
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.283 1.219 -0.06
/error-in-render avg req/sec 1948.08 2050.8 ⚠️ +102.72
Client Bundles (main, webpack, commons)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..45d6.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39 kB 39 kB ✓
Overall change 56.7 kB 56.7 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.87 kB 6.87 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.85 kB 7.85 kB ✓
Client Pages Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
index.html gzip 929 B 929 B ✓
link.html gzip 939 B 939 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
buildDuration 13.4s 13.6s ⚠️ +178ms
nodeModulesSize 55.2 MB 55.2 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..45d6.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39 kB 39 kB ✓
Overall change 56.7 kB 56.7 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.87 kB 6.87 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.85 kB 7.85 kB ✓
Client Pages Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_error.js 558 kB 558 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 558 kB 558 kB ✓
link.js 595 kB 595 kB ✓
routerDirect.js 587 kB 587 kB ✓
withRouter.js 587 kB 587 kB ✓
Overall change 2.89 MB 2.89 MB ✓

Timer
Timer requested changes May 2, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix this example all the way please!

@Timer Timer added the examples Issue/PR related to examples label May 18, 2020
@ijjk
Copy link
Member

ijjk commented May 22, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
buildDuration 12.7s 12.8s ⚠️ +35ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.243 2.204 -0.04
/ avg req/sec 1114.63 1134.22 ⚠️ +19.59
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.449 1.406 -0.04
/error-in-render avg req/sec 1725.81 1777.72 ⚠️ +51.91
Client Bundles (main, webpack, commons)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
index.html gzip 928 B 928 B ✓
link.html gzip 937 B 937 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
buildDuration 14s 14.2s ⚠️ +273ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@Timer Timer added this to the 9.4.3 milestone May 22, 2020
Timer
Timer approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed linting.

@ijjk
Copy link
Member

ijjk commented May 22, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
buildDuration 12.4s 12.1s -336ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.209 2.135 -0.07
/ avg req/sec 1131.78 1170.92 ⚠️ +39.14
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.431 1.341 -0.09
/error-in-render avg req/sec 1747.19 1864.14 ⚠️ +116.95
Client Bundles (main, webpack, commons)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
index.html gzip 928 B 928 B ✓
link.html gzip 937 B 937 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
buildDuration 13.5s 13.3s -271ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@ijjk
Copy link
Member

ijjk commented May 22, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
buildDuration 12.4s 12.3s -108ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Page Load Tests Overall decrease ⚠️
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.04 2.117 ⚠️ +0.08
/ avg req/sec 1225.5 1181.06 -44.44
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.276 1.297 ⚠️ +0.02
/error-in-render avg req/sec 1958.64 1926.82 -31.82
Client Bundles (main, webpack, commons)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
index.html gzip 928 B 928 B ✓
link.html gzip 937 B 937 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
buildDuration 13.4s 13.3s -100ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary xliusstk/next.js feat/fix-ssr-caching-example Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@kodiakhq kodiakhq bot merged commit 6c5efd7 into vercel:canary May 22, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@xliusstk @rokinsky
Fix ssr-caching example (vercel#12180)
5cc0b1a 
cacheable-response.get expects a get(req, res) method signature:
https://www.npmjs.com/package/cacheable-response#get

Before the change:
```
curl -s  -v http://localhost:3000/blog/first 2>&1 | grep HTTP/1.1
> GET /blog/first HTTP/1.1
< HTTP/1.1 404 Not Found
```
After the change:
```
curl -s  -v http://localhost:3000/blog/first 2>&1 | grep HTTP/1.1
> GET /blog/first HTTP/1.1
< HTTP/1.1 200 OK
```

This is a partial fix of vercel#12019 to make the example work. However it doesn't fix the error 
```
(node:62360) UnhandledPromiseRejectionWarning: Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
``` , which will need a change at server/next-server.ts

See related issue:
vercel#11525 
vercel#11665
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kachkaev kachkaev kachkaev left review comments

@timneutkens timneutkens timneutkens approved these changes

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
9.4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@xliusstk @ijjk @kachkaev @Timer @timneutkens