Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cssLoaderOptions #15810

Closed
wants to merge 1 commit into from
Closed

feat: cssLoaderOptions #15810

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 3, 2020

resolve #10584
related with #10339 (comment)

@ghost ghost requested review from ijjk, lfades, Timer and timneutkens as code owners August 3, 2020 00:45
@ijjk ijjk added the type: next label Aug 3, 2020
@ijjk
Copy link
Member

ijjk commented Aug 3, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary TroyTae/next.js css-loader-options Change
buildDuration 11.9s 11.3s -604ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +459 B
Page Load Tests Overall increase ✓
vercel/next.js canary TroyTae/next.js css-loader-options Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.199 2.113 -0.09
/ avg req/sec 1136.78 1182.97 +46.19
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.343 1.313 -0.03
/error-in-render avg req/sec 1862.14 1904.26 +42.12
Client Bundles (main, webpack, commons)
vercel/next.js canary TroyTae/next.js css-loader-options Change
677f882d2ed8..39a4.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-06588f2..f65e.js gzip 6.73 kB 6.73 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary TroyTae/next.js css-loader-options Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-62e1f09..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary TroyTae/next.js css-loader-options Change
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Pages
vercel/next.js canary TroyTae/next.js css-loader-options Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary TroyTae/next.js css-loader-options Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-d5979..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-91516ae..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary TroyTae/next.js css-loader-options Change
_buildManifest.js gzip 274 B 274 B ✓
_buildManife..dule.js gzip 282 B 282 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary TroyTae/next.js css-loader-options Change
index.html gzip 946 B 946 B ✓
link.html gzip 952 B 952 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary TroyTae/next.js css-loader-options Change
buildDuration 12.4s 12.6s ⚠️ +189ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +459 B
Client Bundles (main, webpack, commons)
vercel/next.js canary TroyTae/next.js css-loader-options Change
677f882d2ed8..39a4.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-06588f2..f65e.js gzip 6.73 kB 6.73 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary TroyTae/next.js css-loader-options Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-62e1f09..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary TroyTae/next.js css-loader-options Change
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Pages
vercel/next.js canary TroyTae/next.js css-loader-options Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary TroyTae/next.js css-loader-options Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-d5979..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-91516ae..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary TroyTae/next.js css-loader-options Change
_buildManifest.js gzip 274 B 274 B ✓
_buildManife..dule.js gzip 282 B 282 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary TroyTae/next.js css-loader-options Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.2 MB 5.2 MB ✓
Commit: 35e3be2

Timer
Timer requested changes Aug 3, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please open a formal RFC requesting new behavior before sending a PR adding it. Thanks!

@ghost
Copy link
Author

ghost commented Aug 3, 2020 •
edited by ghost
Loading

@Timer
Oops sorry, how can I make RFC?
There is no explain in contribute.md.

Update:
I create discussion in here: #15818

@timneutkens
Copy link
Member

Going to close this PR until #15818 is discussed.

@timneutkens timneutkens closed this Aug 3, 2020
@yura3d yura3d mentioned this pull request Feb 18, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow users to configure options of css-loader
3 participants
@ijjk @timneutkens @Timer