Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose configured default locale in GS(S)P methods #18216

Merged
merged 4 commits into from
Oct 27, 2020
Merged

Expose configured default locale in GS(S)P methods #18216

merged 4 commits into from
Oct 27, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 25, 2020

This exposes the default locale configured in next.config.js to getStaticProps, getStaticPaths, and getServerSideProps. Documentation has also been updated in this PR to reflect this value being exposed along with tests ensuring it is exposed everywhere as expected

x-ref: #17370

@ijjk
Copy link
Member Author

ijjk commented Oct 25, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
buildDuration 13.2s 13s -153ms
nodeModulesSize 91.3 MB 91.3 MB ⚠️ +369 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.422 2.382 -0.04
/ avg req/sec 1032.4 1049.59 +17.19
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.298 1.319 ⚠️ +0.02
/error-in-render avg req/sec 1926.13 1895.14 ⚠️ -30.99
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
677f882d2ed8..574c.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3dd37a4..54de.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
677f882d2ed8..dule.js gzip 7.02 kB 7.02 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-082aff9..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 994 B 994 B ✓
Overall change 3 kB 3 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
buildDuration 14.9s 14.8s -78ms
nodeModulesSize 91.3 MB 91.3 MB ⚠️ +369 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
677f882d2ed8..574c.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3dd37a4..54de.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
677f882d2ed8..dule.js gzip 7.02 kB 7.02 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-082aff9..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
_error.js 1.06 MB 1.06 MB ⚠️ +78 B
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.06 MB ⚠️ +78 B
link.js 1.1 MB 1.1 MB ⚠️ +78 B
routerDirect.js 1.1 MB 1.1 MB ⚠️ +78 B
withRouter.js 1.1 MB 1.1 MB ⚠️ +78 B
Overall change 5.42 MB 5.42 MB ⚠️ +390 B
Commit: afdff44

@ijjk ijjk marked this pull request as ready for review October 25, 2020 05:53
Timer
Timer approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ijjk
Copy link
Member Author

ijjk commented Oct 27, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
buildDuration 12.2s 11.8s -347ms
nodeModulesSize 91.3 MB 91.3 MB ⚠️ +369 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.257 2.245 -0.01
/ avg req/sec 1107.86 1113.55 +5.69
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.238 1.372 ⚠️ +0.13
/error-in-render avg req/sec 2020.08 1821.51 ⚠️ -198.57
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
677f882d2ed8..d3ae.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-2927f4e..281e.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
677f882d2ed8..dule.js gzip 7.01 kB 7.01 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-1382a2d..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 994 B 994 B ✓
Overall change 3 kB 3 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
buildDuration 13.7s 13.4s -253ms
nodeModulesSize 91.3 MB 91.3 MB ⚠️ +369 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
677f882d2ed8..d3ae.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-2927f4e..281e.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
677f882d2ed8..dule.js gzip 7.01 kB 7.01 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-1382a2d..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js i18n/gsp-default-locale Change
_error.js 1.06 MB 1.06 MB ⚠️ +78 B
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.06 MB ⚠️ +78 B
link.js 1.11 MB 1.11 MB ⚠️ +78 B
routerDirect.js 1.1 MB 1.1 MB ⚠️ +78 B
withRouter.js 1.1 MB 1.1 MB ⚠️ +78 B
Overall change 5.43 MB 5.43 MB ⚠️ +390 B
Commit: 2ab6e82

@Timer Timer merged commit 379f4c6 into vercel:canary Oct 27, 2020
@Timer Timer deleted the i18n/gsp-default-locale branch October 27, 2020 09:43
This was referenced Oct 28, 2020
Open
Open
Open
This was referenced Mar 7, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 17, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 12, 2022
Closed
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Jan 23, 2022
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ijjk @Timer @timneutkens