Add layout prop to Image component #18491

styfle · 2020-10-29T16:48:59Z

This PR introduces a new layout property.

This allows 3 possible values (fixed, intrinsic, or responsive) which solve many use cases we have seen since 10.0.0 and will hopefully avoid usage of unsized.

Fixes #18351

packages/next/client/image.tsx

atcastle · 2020-10-29T17:27:35Z

When I'm trying out the integration apps, the layout-intrinsic page isn't behaving like I'd expect. When I increase the image size, then adjust the viewport I'm seeing it squeeze horizontally instead of maintain its aspect ratio.

Co-authored-by: Joe Haddad <[email protected]>

packages/next/client/image.tsx

Co-authored-by: Joe Haddad <[email protected]>

styfle · 2020-10-29T20:10:57Z

@atcastle Nice catch! Please take another look 👍

ijjk · 2020-10-29T20:20:53Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
buildDuration	12.9s	13.5s	⚠️ +626ms
nodeModulesSize	86.7 MB	91.3 MB	⚠️ +4.66 MB

Page Load Tests Overall increase ✓

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.412	2.471	⚠️ +0.06
/ avg req/sec	1036.39	1011.65	⚠️ -24.74
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.461	1.328	-0.13
/error-in-render avg req/sec	1710.73	1882.41	+171.68

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
677f882d2ed8..3aa9.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2bc1e97..bed6.js gzip	7.35 kB	7.35 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
677f882d2ed8..dule.js gzip	7.03 kB	7.03 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-8cad9cc..dule.js gzip	6.33 kB	6.33 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	995 B	995 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
buildDuration	15.2s	14.9s	-297ms
nodeModulesSize	91.3 MB	86.7 MB	-4.66 MB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
677f882d2ed8..3aa9.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2bc1e97..bed6.js gzip	7.35 kB	7.35 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
677f882d2ed8..dule.js gzip	7.03 kB	7.03 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-8cad9cc..dule.js gzip	6.33 kB	6.33 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
_error.js	1.06 MB	1.06 MB	✓
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	✓
link.js	1.11 MB	1.11 MB	✓
routerDirect.js	1.1 MB	1.1 MB	✓
withRouter.js	1.1 MB	1.1 MB	✓
Overall change	5.43 MB	5.43 MB	✓

Commit: b40b890

pacocoursey

Could be unrelated to this PR, but the wrapper div has additional height from the following usage:

          <Image
            id="basic-image"
            src="/test.jpg"
            unsized
          />

Do we even need a wrapper div for this case?

test/integration/image-component/default/pages/layout-responsive.js

styfle · 2020-10-29T22:32:16Z

Thanks all!

I added tests for these layouts so we won't regress.

In regard to the unsized property...we are leaving it as-is in this PR because it is not meant for layouts.

See #18471 for the future of that property.

ijjk · 2020-10-29T22:58:08Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
buildDuration	13.3s	13.3s	-2ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +4.07 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.591	2.544	-0.05
/ avg req/sec	964.97	982.88	+17.91
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.327	1.406	⚠️ +0.08
/error-in-render avg req/sec	1884.08	1777.75	⚠️ -106.33

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
677f882d2ed8..3aa9.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2bc1e97..bed6.js gzip	7.35 kB	7.35 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
677f882d2ed8..dule.js gzip	7.03 kB	7.03 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-8cad9cc..dule.js gzip	6.33 kB	6.33 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	995 B	995 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
buildDuration	14.8s	14.9s	⚠️ +63ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +4.07 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
677f882d2ed8..3aa9.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2bc1e97..bed6.js gzip	7.35 kB	7.35 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
677f882d2ed8..dule.js gzip	7.03 kB	7.03 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-8cad9cc..dule.js gzip	6.33 kB	6.33 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
_error.js	1.06 MB	1.06 MB	✓
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	✓
link.js	1.11 MB	1.11 MB	✓
routerDirect.js	1.1 MB	1.1 MB	✓
withRouter.js	1.1 MB	1.1 MB	✓
Overall change	5.43 MB	5.43 MB	✓

Commit: 25060cc

Timer

Looks fantastic!

ijjk · 2020-10-30T14:24:04Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
buildDuration	14.7s	14.6s	-131ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +4.07 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.835	2.851	⚠️ +0.02
/ avg req/sec	881.84	876.91	⚠️ -4.93
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.762	1.761	0
/error-in-render avg req/sec	1419.17	1419.66	+0.49

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
677f882d2ed8..3aa9.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2bc1e97..bed6.js gzip	7.35 kB	7.35 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
677f882d2ed8..dule.js gzip	7.03 kB	7.03 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-8cad9cc..dule.js gzip	6.33 kB	6.33 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	995 B	995 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
buildDuration	16.5s	16.5s	-25ms
nodeModulesSize	91.3 MB	91.3 MB	⚠️ +4.07 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
677f882d2ed8..3aa9.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2bc1e97..bed6.js gzip	7.35 kB	7.35 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
677f882d2ed8..dule.js gzip	7.03 kB	7.03 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-8cad9cc..dule.js gzip	6.33 kB	6.33 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-41ceea0..6b62.js gzip	1.35 kB	1.35 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-2d41a89..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.4 kB	5.4 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	vercel/next.js 18351-img-layout-options	Change
_error.js	1.06 MB	1.06 MB	✓
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	✓
link.js	1.11 MB	1.11 MB	✓
routerDirect.js	1.1 MB	1.1 MB	✓
withRouter.js	1.1 MB	1.1 MB	✓
Overall change	5.43 MB	5.43 MB	✓

Commit: 74295f4

styfle added 2 commits October 29, 2020 11:50

Add layout prop to Image component

f04857b

Add layout implementations

8d01c05

ijjk added the type: next label Oct 29, 2020

This comment has been minimized.

Sign in to view

Timer reviewed Oct 29, 2020

View reviewed changes

packages/next/client/image.tsx Show resolved Hide resolved

Change default to fixed per Timer

b76ad27

Co-authored-by: Joe Haddad <[email protected]>

This comment has been minimized.

Sign in to view

Add larger image and fix intrinsic

a089fa3

Timer reviewed Oct 29, 2020

View reviewed changes

packages/next/client/image.tsx Outdated Show resolved Hide resolved

Use svg

fff0206

This comment has been minimized.

Sign in to view

Back to intrinsic default

b40b890

Co-authored-by: Joe Haddad <[email protected]>

pacocoursey reviewed Oct 29, 2020

View reviewed changes

test/integration/image-component/default/pages/layout-responsive.js Show resolved Hide resolved

atcastle previously approved these changes Oct 29, 2020

View reviewed changes

pacocoursey previously approved these changes Oct 29, 2020

View reviewed changes

styfle added 2 commits October 29, 2020 18:30

Add tests for 3 new layouts

4aa0e71

Add ratio test

a6041d6

styfle dismissed stale reviews from pacocoursey and atcastle via a6041d6 October 29, 2020 22:30

styfle marked this pull request as ready for review October 29, 2020 22:30

styfle requested review from ijjk, lfades and timneutkens as code owners October 29, 2020 22:30

Merge branch 'canary' into 18351-img-layout-options

608a10d

This comment has been minimized.

Sign in to view

Update docs

25060cc

styfle requested a review from chibicode as a code owner October 29, 2020 22:47

ijjk added the type: documentation label Oct 29, 2020

styfle requested review from pacocoursey and Timer October 29, 2020 22:47

Timer approved these changes Oct 30, 2020

View reviewed changes

Merge branch 'canary' into 18351-img-layout-options

74295f4

Timer mentioned this pull request Oct 30, 2020

Proposal: NextImage should automatically determine width/height for local images #18497

Closed

styfle merged commit afa04d2 into canary Oct 30, 2020

styfle deleted the 18351-img-layout-options branch October 30, 2020 14:33

nocategory mentioned this pull request Oct 30, 2020

Update Next.js to v10 nocategory/portfolio#6

Merged

3 tasks

Timer added the hacktoberfest-accepted label Nov 1, 2020

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add layout prop to Image component #18491

Add layout prop to Image component #18491

styfle commented Oct 29, 2020 •

edited

Loading

This comment has been minimized.

atcastle commented Oct 29, 2020 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

styfle commented Oct 29, 2020

ijjk commented Oct 29, 2020

pacocoursey left a comment •

edited

Loading

styfle commented Oct 29, 2020

This comment has been minimized.

This comment has been minimized.

ijjk commented Oct 29, 2020

Timer left a comment

ijjk commented Oct 30, 2020

Add layout prop to Image component #18491

Add layout prop to Image component #18491

Conversation

styfle commented Oct 29, 2020 • edited Loading

This comment has been minimized.

atcastle commented Oct 29, 2020 • edited Loading

This comment has been minimized.

This comment has been minimized.

styfle commented Oct 29, 2020

ijjk commented Oct 29, 2020

Stats from current PR

pacocoursey left a comment • edited Loading

Choose a reason for hiding this comment

styfle commented Oct 29, 2020

This comment has been minimized.

This comment has been minimized.

ijjk commented Oct 29, 2020

Stats from current PR

Timer left a comment

Choose a reason for hiding this comment

ijjk commented Oct 30, 2020

Stats from current PR

styfle commented Oct 29, 2020 •

edited

Loading

atcastle commented Oct 29, 2020 •

edited

Loading

pacocoursey left a comment •

edited

Loading