Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with-styletron example to not use DebugEngine #20233

Merged
merged 6 commits into from
Dec 29, 2020

Conversation

tajo
Copy link
Contributor

@tajo tajo commented Dec 16, 2020

DebugEngine stopped working with v9.5 since the devtool is strictly set to eval and this option is not customizable. Unfortunately there is currently no way to fix this.

[DebugEngine stopped working](styletron/styletron#366) with v9.5 since the devtool is strictly set to eval and this option is not customizable. Unfortunately there is no currently no fix.
@ijjk ijjk added the examples Issue/PR related to examples label Dec 16, 2020
@vercel vercel bot temporarily deployed to Preview December 16, 2020 17:24 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 16, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary tajo/next.js patch-1 Change
buildDuration 8.2s 8.5s ⚠️ +309ms
nodeModulesSize 82.4 MB 82.4 MB
Page Load Tests Overall increase ✓
vercel/next.js canary tajo/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.047 1.998 -0.05
/ avg req/sec 1221.25 1251.33 +30.08
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.065 1.076 ⚠️ +0.01
/error-in-render avg req/sec 2348.21 2323.57 ⚠️ -24.64
Client Bundles (main, webpack, commons)
vercel/next.js canary tajo/next.js patch-1 Change
677f882d2ed8..0679.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-008bb91..b823.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59.1 kB 59.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary tajo/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary tajo/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary tajo/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Rendered Page Sizes
vercel/next.js canary tajo/next.js patch-1 Change
index.html gzip 615 B 615 B
link.html gzip 621 B 621 B
withRouter.html gzip 609 B 609 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General
vercel/next.js canary tajo/next.js patch-1 Change
buildDuration 9.7s 10.1s ⚠️ +414ms
nodeModulesSize 82.4 MB 82.4 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary tajo/next.js patch-1 Change
677f882d2ed8..0679.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-008bb91..b823.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59.1 kB 59.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary tajo/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary tajo/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary tajo/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Serverless bundles
vercel/next.js canary tajo/next.js patch-1 Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.16 MB 5.16 MB
Commit: e626a2c

timneutkens
timneutkens previously approved these changes Dec 17, 2020
@vercel vercel bot temporarily deployed to Preview December 17, 2020 09:35 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 17, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary tajo/next.js patch-1 Change
buildDuration 8.5s 8.5s ⚠️ +5ms
nodeModulesSize 82.4 MB 82.4 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary tajo/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 1.969 1.987 ⚠️ +0.02
/ avg req/sec 1269.4 1257.9 ⚠️ -11.5
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.067 1.125 ⚠️ +0.06
/error-in-render avg req/sec 2343.52 2222.25 ⚠️ -121.27
Client Bundles (main, webpack, commons)
vercel/next.js canary tajo/next.js patch-1 Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-086d1b7..8537.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary tajo/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary tajo/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary tajo/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Rendered Page Sizes
vercel/next.js canary tajo/next.js patch-1 Change
index.html gzip 613 B 613 B
link.html gzip 619 B 619 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General
vercel/next.js canary tajo/next.js patch-1 Change
buildDuration 10.7s 10s -729ms
nodeModulesSize 82.4 MB 82.4 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary tajo/next.js patch-1 Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-086d1b7..8537.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary tajo/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary tajo/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary tajo/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Serverless bundles
vercel/next.js canary tajo/next.js patch-1 Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.16 MB 5.16 MB
Commit: b5d0aae

Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also delete the code the the styletron.js file?

@vercel vercel bot temporarily deployed to Preview December 29, 2020 00:40 Inactive
@vercel vercel bot temporarily deployed to Preview December 29, 2020 00:48 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 29, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary tajo/next.js patch-1 Change
buildDuration 8.8s 8.7s -33ms
nodeModulesSize 82.7 MB 82.7 MB
Page Load Tests Overall increase ✓
vercel/next.js canary tajo/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 1.758 1.688 -0.07
/ avg req/sec 1421.84 1480.7 +58.86
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.121 1.085 -0.04
/error-in-render avg req/sec 2231.1 2303.82 +72.72
Client Bundles (main, webpack, commons)
vercel/next.js canary tajo/next.js patch-1 Change
677f882d2ed8..68d0.js gzip 12.7 kB 12.7 kB
framework.HASH.js gzip 39 kB 39 kB
main-22f99c0..0c03.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary tajo/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary tajo/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.05 kB 8.05 kB
Client Build Manifests
vercel/next.js canary tajo/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Rendered Page Sizes
vercel/next.js canary tajo/next.js patch-1 Change
index.html gzip 614 B 614 B
link.html gzip 620 B 620 B
withRouter.html gzip 609 B 609 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General
vercel/next.js canary tajo/next.js patch-1 Change
buildDuration 10.4s 10.3s -75ms
nodeModulesSize 82.7 MB 82.7 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary tajo/next.js patch-1 Change
677f882d2ed8..68d0.js gzip 12.7 kB 12.7 kB
framework.HASH.js gzip 39 kB 39 kB
main-22f99c0..0c03.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary tajo/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary tajo/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.05 kB 8.05 kB
Client Build Manifests
vercel/next.js canary tajo/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Serverless bundles
vercel/next.js canary tajo/next.js patch-1 Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.16 MB 5.16 MB
Commit: 586a100

@vercel vercel bot temporarily deployed to Preview December 29, 2020 01:00 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 29, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary tajo/next.js patch-1 Change
buildDuration 8.8s 8.8s ⚠️ +17ms
nodeModulesSize 82.7 MB 82.7 MB
Page Load Tests Overall increase ✓
vercel/next.js canary tajo/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 1.837 1.79 -0.05
/ avg req/sec 1360.59 1396.29 +35.7
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.234 1.165 -0.07
/error-in-render avg req/sec 2025.34 2146.2 +120.86
Client Bundles (main, webpack, commons)
vercel/next.js canary tajo/next.js patch-1 Change
677f882d2ed8..68d0.js gzip 12.7 kB 12.7 kB
framework.HASH.js gzip 39 kB 39 kB
main-22f99c0..0c03.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary tajo/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary tajo/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.05 kB 8.05 kB
Client Build Manifests
vercel/next.js canary tajo/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Rendered Page Sizes
vercel/next.js canary tajo/next.js patch-1 Change
index.html gzip 614 B 614 B
link.html gzip 620 B 620 B
withRouter.html gzip 609 B 609 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General
vercel/next.js canary tajo/next.js patch-1 Change
buildDuration 10.5s 10.8s ⚠️ +261ms
nodeModulesSize 82.7 MB 82.7 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary tajo/next.js patch-1 Change
677f882d2ed8..68d0.js gzip 12.7 kB 12.7 kB
framework.HASH.js gzip 39 kB 39 kB
main-22f99c0..0c03.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary tajo/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary tajo/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.05 kB 8.05 kB
Client Build Manifests
vercel/next.js canary tajo/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Serverless bundles
vercel/next.js canary tajo/next.js patch-1 Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.16 MB 5.16 MB
Commit: 0a83863

@tajo
Copy link
Contributor Author

tajo commented Dec 29, 2020

Shouldn't we also delete the code the the styletron.js file?

Should be good to go now.

@tajo tajo requested a review from Timer December 29, 2020 16:11
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! Hopefully we can see Styletron add support for eval-source-map soon.

@vercel vercel bot temporarily deployed to Preview December 29, 2020 16:16 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 29, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary tajo/next.js patch-1 Change
buildDuration 9.8s 9.7s -177ms
nodeModulesSize 82.7 MB 82.7 MB
Page Load Tests Overall increase ✓
vercel/next.js canary tajo/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 1.962 1.944 -0.02
/ avg req/sec 1273.96 1285.73 +11.77
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.266 1.233 -0.03
/error-in-render avg req/sec 1974.71 2027.25 +52.54
Client Bundles (main, webpack, commons)
vercel/next.js canary tajo/next.js patch-1 Change
677f882d2ed8..68d0.js gzip 12.7 kB 12.7 kB
framework.HASH.js gzip 39 kB 39 kB
main-8d1eb02..37d1.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary tajo/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary tajo/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.05 kB 8.05 kB
Client Build Manifests
vercel/next.js canary tajo/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Rendered Page Sizes
vercel/next.js canary tajo/next.js patch-1 Change
index.html gzip 614 B 614 B
link.html gzip 619 B 619 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General
vercel/next.js canary tajo/next.js patch-1 Change
buildDuration 11.5s 11.9s ⚠️ +432ms
nodeModulesSize 82.7 MB 82.7 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary tajo/next.js patch-1 Change
677f882d2ed8..68d0.js gzip 12.7 kB 12.7 kB
framework.HASH.js gzip 39 kB 39 kB
main-8d1eb02..37d1.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary tajo/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary tajo/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.05 kB 8.05 kB
Client Build Manifests
vercel/next.js canary tajo/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Serverless bundles
vercel/next.js canary tajo/next.js patch-1 Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.16 MB 5.16 MB
Commit: 3291540

@kodiakhq kodiakhq bot merged commit 2433c11 into vercel:canary Dec 29, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants