Ignore emacs lockfiles #20497

lfender6445 · 2020-12-26T17:29:47Z

Bug report

When using next dev with emacs, as you develop, emacs creates symbolic link files starting with .# as lock files. Next.js seems to attempt to load these but fails, spewing out errors constantly.

Prevents dev server from crashing when emacs creates lockfiles

tested with:

GNU Emacs 27.1
OSX 11.1
Node v15.4.0

ijjk · 2020-12-26T17:43:25Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
buildDuration	8.7s	8.8s	⚠️ +56ms
nodeModulesSize	82.6 MB	82.6 MB	⚠️ +237 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.798	1.718	-0.08
/ avg req/sec	1390.62	1455.32	+64.7
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.061	1.123	⚠️ +0.06
/error-in-render avg req/sec	2355.63	2225.26	⚠️ -130.37

Client Bundles (main, webpack, commons)

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e0d2962..b163.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-85785..a9f3.js gzip	3.44 kB	3.44 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.05 kB	8.05 kB	✓

Client Build Manifests

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
index.html gzip	612 B	612 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
buildDuration	10.3s	10.4s	⚠️ +11ms
nodeModulesSize	82.6 MB	82.6 MB	⚠️ +237 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e0d2962..b163.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-85785..a9f3.js gzip	3.44 kB	3.44 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.05 kB	8.05 kB	✓

Client Build Manifests

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.16 MB	5.16 MB	✓

Commit: 8f9cf04

lfender6445 · 2020-12-27T15:51:59Z

Hmm, not sure whats going on with failing build, appears unrelated

packages/next/build/webpack-config.ts

- also updates gitignore Fixes: vercel#15278

ijjk · 2020-12-29T15:37:27Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
buildDuration	9.8s	9.6s	-197ms
nodeModulesSize	82.7 MB	82.7 MB	⚠️ +421 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.877	1.908	⚠️ +0.03
/ avg req/sec	1331.84	1310.27	⚠️ -21.57
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.203	1.209	⚠️ +0.01
/error-in-render avg req/sec	2078.63	2067.17	⚠️ -11.46

Client Bundles (main, webpack, commons)

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
677f882d2ed8..68d0.js gzip	12.7 kB	12.7 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-8d1eb02..37d1.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-85785..a9f3.js gzip	3.44 kB	3.44 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.05 kB	8.05 kB	✓

Client Build Manifests

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
index.html gzip	614 B	614 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
buildDuration	11.2s	11.4s	⚠️ +208ms
nodeModulesSize	82.7 MB	82.7 MB	⚠️ +421 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
677f882d2ed8..68d0.js gzip	12.7 kB	12.7 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-8d1eb02..37d1.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-85785..a9f3.js gzip	3.44 kB	3.44 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.05 kB	8.05 kB	✓

Client Build Manifests

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.16 MB	5.16 MB	✓

Commit: e9de075

Timer

LGTM, thanks!

ijjk · 2020-12-29T15:57:57Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
buildDuration	7.8s	7.8s	⚠️ +22ms
nodeModulesSize	82.7 MB	82.7 MB	⚠️ +421 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.617	1.63	⚠️ +0.01
/ avg req/sec	1545.94	1533.73	⚠️ -12.21
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.032	1.025	-0.01
/error-in-render avg req/sec	2421.96	2438.38	+16.42

Client Bundles (main, webpack, commons)

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
677f882d2ed8..68d0.js gzip	12.7 kB	12.7 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-8d1eb02..37d1.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-85785..a9f3.js gzip	3.44 kB	3.44 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.05 kB	8.05 kB	✓

Client Build Manifests

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
index.html gzip	614 B	614 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
buildDuration	9.3s	9.1s	-193ms
nodeModulesSize	82.7 MB	82.7 MB	⚠️ +421 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
677f882d2ed8..68d0.js gzip	12.7 kB	12.7 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-8d1eb02..37d1.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-85785..a9f3.js gzip	3.44 kB	3.44 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.05 kB	8.05 kB	✓

Client Build Manifests

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	lfender6445/next.js emacs-lockfile-fix	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.16 MB	5.16 MB	✓

Commit: 0c4bd1f

lfender6445 requested review from ijjk, lfades, Timer and timneutkens as code owners December 26, 2020 17:29

ijjk added the type: next label Dec 26, 2020

vercel bot temporarily deployed to Preview December 26, 2020 17:29 Inactive

lfender6445 mentioned this pull request Dec 26, 2020

Development server errors due to emacs file lock facebook/create-react-app#9056

Open

lfender6445 force-pushed the emacs-lockfile-fix branch from ff95e96 to f21ad40 Compare December 26, 2020 17:33

vercel bot temporarily deployed to Preview December 26, 2020 17:33 Inactive

lfender6445 mentioned this pull request Dec 26, 2020

next dev constantly errors when using emacs, failing to load emacs lock files #15278

Closed

lfender6445 force-pushed the emacs-lockfile-fix branch from f21ad40 to 8f9cf04 Compare December 26, 2020 17:35

vercel bot temporarily deployed to Preview December 26, 2020 17:35 Inactive

Timer requested changes Dec 28, 2020

View reviewed changes

packages/next/build/webpack-config.ts Show resolved Hide resolved

lfender6445 force-pushed the emacs-lockfile-fix branch from 8f9cf04 to 43c7e6c Compare December 29, 2020 15:26

vercel bot temporarily deployed to Preview December 29, 2020 15:27 Inactive

Ignore emacs lockfiles

e9de075

- also updates gitignore Fixes: vercel#15278

lfender6445 force-pushed the emacs-lockfile-fix branch from 43c7e6c to e9de075 Compare December 29, 2020 15:28

vercel bot temporarily deployed to Preview December 29, 2020 15:28 Inactive

Timer approved these changes Dec 29, 2020

View reviewed changes

Merge branch 'canary' into emacs-lockfile-fix

0c4bd1f

vercel bot temporarily deployed to Preview December 29, 2020 15:50 Inactive

kodiakhq bot merged commit f2f9090 into vercel:canary Dec 29, 2020

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ignore emacs lockfiles #20497

Ignore emacs lockfiles #20497

lfender6445 commented Dec 26, 2020 •

edited

Loading

ijjk commented Dec 26, 2020

lfender6445 commented Dec 27, 2020

ijjk commented Dec 29, 2020

Timer left a comment

ijjk commented Dec 29, 2020

Ignore emacs lockfiles #20497

Ignore emacs lockfiles #20497

Conversation

lfender6445 commented Dec 26, 2020 • edited Loading

ijjk commented Dec 26, 2020

Stats from current PR

lfender6445 commented Dec 27, 2020

ijjk commented Dec 29, 2020

Stats from current PR

Timer left a comment

Choose a reason for hiding this comment

ijjk commented Dec 29, 2020

Stats from current PR

lfender6445 commented Dec 26, 2020 •

edited

Loading