Fix aspath for getInitialProps #20572

kaykdm · 2020-12-29T13:43:57Z

Fixes: #20370

AsPath is incorrect on Server if you use rewrites and getInitialProps. On the server, asPath is the rewritten asPath while on the client asPath ist as given in the request URL.

The same issue was used to happen on getServersideProps, but it was fixed in this PR (#17121).
getInitialProps needs same fix except when the target is serverless, which has correct asPath value.

Additional tests have been added in the getInitialProps suite to ensure correct asPath with rewrites.

ijjk · 2020-12-29T13:51:20Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	7.8s	7.8s	⚠️ +52ms
nodeModulesSize	82.7 MB	82.7 MB	⚠️ +388 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.558	1.57	⚠️ +0.01
/ avg req/sec	1604.51	1592.3	⚠️ -12.21
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.004	0.982	-0.02
/error-in-render avg req/sec	2491.16	2545.69	+54.53

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
677f882d2ed8..68d0.js gzip	12.7 kB	12.7 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-8d1eb02..37d1.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-85785..a9f3.js gzip	3.44 kB	3.44 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.05 kB	8.05 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
index.html gzip	614 B	614 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	9.2s	9.2s	⚠️ +3ms
nodeModulesSize	82.7 MB	82.7 MB	⚠️ +388 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
677f882d2ed8..68d0.js gzip	12.7 kB	12.7 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-8d1eb02..37d1.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-85785..a9f3.js gzip	3.44 kB	3.44 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.05 kB	8.05 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.16 MB	5.16 MB	✓

Commit: ad3b35d

kaykdm · 2020-12-29T14:06:46Z

~~Let me know if you want me to write a test for it~~
tests have been added

ijjk · 2021-01-06T01:20:07Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	9.4s	9.6s	⚠️ +141ms
nodeModulesSize	80.6 MB	80.6 MB	⚠️ +388 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.948	1.888	-0.06
/ avg req/sec	1283.38	1324.28	+40.9
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.4	1.422	⚠️ +0.02
/error-in-render avg req/sec	1786.16	1758.61	⚠️ -27.55

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
677f882d2ed8..396f.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d74fce9..a1a1.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.3 kB	59.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-b6fc6bc..222c.js gzip	1.28 kB	1.28 kB	✓
_error-e2ffa..0f3f.js gzip	3.46 kB	3.46 kB	✓
hooks-010c20..8411.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-705099c..c35d.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	11s	11.1s	⚠️ +47ms
nodeModulesSize	80.6 MB	80.6 MB	⚠️ +388 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
677f882d2ed8..396f.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d74fce9..a1a1.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.3 kB	59.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-b6fc6bc..222c.js gzip	1.28 kB	1.28 kB	✓
_error-e2ffa..0f3f.js gzip	3.46 kB	3.46 kB	✓
hooks-010c20..8411.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-705099c..c35d.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.17 MB	5.17 MB	✓

Commit: 6fa33b8

ijjk · 2021-01-15T09:55:09Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	10.4s	10.5s	⚠️ +44ms
nodeModulesSize	77.5 MB	77.5 MB	⚠️ +388 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.052	2.052	✓
/ avg req/sec	1218.22	1218.3	+0.08
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.31	1.247	-0.06
/error-in-render avg req/sec	1908.53	2004.72	+96.19

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
677f882d2ed8..b025.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-b70be25..6967.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-af..9390.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
index.html gzip	613 B	613 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	12.3s	12.3s	⚠️ +6ms
nodeModulesSize	77.5 MB	77.5 MB	⚠️ +388 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
677f882d2ed8..b025.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-b70be25..6967.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-af..9390.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.18 MB	5.18 MB	✓

Commit: 991dbc7

ijjk · 2021-01-23T12:16:36Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	8.8s	8.6s	-230ms
nodeModulesSize	73.3 MB	73.3 MB	⚠️ +388 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.717	1.744	⚠️ +0.03
/ avg req/sec	1456.14	1433.59	⚠️ -22.55
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.078	1.11	⚠️ +0.03
/error-in-render avg req/sec	2318.31	2252.48	⚠️ -65.83

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	10.3s	10.3s	⚠️ +48ms
nodeModulesSize	73.3 MB	73.3 MB	⚠️ +388 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.19 MB	5.19 MB	✓

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	10.6s	10.4s	-208ms
nodeModulesSize	73.3 MB	73.3 MB	⚠️ +388 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.697	1.705	⚠️ +0.01
/ avg req/sec	1473.6	1465.92	⚠️ -7.68
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.077	1.067	-0.01
/error-in-render avg req/sec	2320.28	2343.38	+23.1

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
597-c48889ef..1870.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
index.html gzip	588 B	588 B	✓
link.html gzip	593 B	593 B	✓
withRouter.html gzip	581 B	581 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "16iOliAJHAjjivVS_DjpR",
+        "buildId": "4HM0eNuvaCdlqcO6EtvJl",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/16iOliAJHAjjivVS_DjpR/_buildManifest.js"
+      src="/_next/static/4HM0eNuvaCdlqcO6EtvJl/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/16iOliAJHAjjivVS_DjpR/_ssgManifest.js"
+      src="/_next/static/4HM0eNuvaCdlqcO6EtvJl/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "16iOliAJHAjjivVS_DjpR",
+        "buildId": "4HM0eNuvaCdlqcO6EtvJl",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/16iOliAJHAjjivVS_DjpR/_buildManifest.js"
+      src="/_next/static/4HM0eNuvaCdlqcO6EtvJl/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/16iOliAJHAjjivVS_DjpR/_ssgManifest.js"
+      src="/_next/static/4HM0eNuvaCdlqcO6EtvJl/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "16iOliAJHAjjivVS_DjpR",
+        "buildId": "4HM0eNuvaCdlqcO6EtvJl",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/16iOliAJHAjjivVS_DjpR/_buildManifest.js"
+      src="/_next/static/4HM0eNuvaCdlqcO6EtvJl/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/16iOliAJHAjjivVS_DjpR/_ssgManifest.js"
+      src="/_next/static/4HM0eNuvaCdlqcO6EtvJl/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 27b7dd1

kaykdm · 2021-01-23T12:27:15Z

~~I think this is fixed in this~~

ijjk

Changes and tests look good, thanks for the PR!

ijjk · 2021-01-25T15:54:35Z

Failing test suites

Commit: 906f2ab

test/integration/dist-dir/test/index.test.js

distDir > should handle null/undefined distDir

Expand output

● distDir › should handle null/undefined distDir

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 88

  63 |     await fs.writeFile(nextConfig, origNextConfig)
  64 | 
> 65 |     expect(stderr.length).toBe(0)
     |                           ^
  66 |   })
  67 | })
  68 | 

  at Object.<anonymous> (integration/dist-dir/test/index.test.js:65:27)

test/integration/production-build-dir/test/index.test.js

Production Custom Build Directory > With basic usage > should render the page

Expand output

● Production Custom Build Directory › With basic usage › should render the page

expect(received).toBe(expected) // Object.is equality

Expected: ""
Received: "Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
"

  20 |         stderr: true,
  21 |       })
> 22 |       expect(result.stderr).toBe('')
     |                             ^
  23 | 
  24 |       const app = nextServer({
  25 |         dir: join(__dirname, '../build'),

  at Object.<anonymous> (integration/production-build-dir/test/index.test.js:22:29)

test/integration/cli/test/index.test.js

CLI Usage > build > should warn when unknown argument provided

Expand output

● CLI Usage › build › should warn when unknown argument provided

expect(received).toEqual(expected) // deep equality

- Expected  - 0
+ Received  + 2

+ Browserslist: caniuse-lite is outdated. Please run:
+ npx browserslist@latest --update-db
  Unknown or unexpected option: --random
  ↵

  79 |         stderr: true,
  80 |       })
> 81 |       expect(stderr).toEqual('Unknown or unexpected option: --random\n')
     |                      ^
  82 |     })
  83 |     test('should not throw UnhandledPromiseRejectionWarning', async () => {
  84 |       const { stderr } = await runNextCommand(['build', '--random'], {

  at Object.<anonymous> (integration/cli/test/index.test.js:81:22)

ijjk · 2021-01-25T15:57:02Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	11.8s	11.8s	⚠️ +43ms
nodeModulesSize	73.3 MB	73.3 MB	⚠️ +388 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.452	2.43	-0.02
/ avg req/sec	1019.48	1028.82	+9.34
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.666	1.71	⚠️ +0.04
/error-in-render avg req/sec	1500.64	1461.74	⚠️ -38.9

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	13.5s	13.8s	⚠️ +262ms
nodeModulesSize	73.3 MB	73.3 MB	⚠️ +388 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.19 MB	5.19 MB	✓

Webpack 5 Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	14.1s	14.3s	⚠️ +244ms
nodeModulesSize	73.3 MB	73.3 MB	⚠️ +388 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.279	2.357	⚠️ +0.08
/ avg req/sec	1097.19	1060.82	⚠️ -36.37
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.666	1.639	-0.03
/error-in-render avg req/sec	1500.63	1525.76	+25.13

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
597-c48889ef..1870.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
index.html gzip	588 B	588 B	✓
link.html gzip	593 B	593 B	✓
withRouter.html gzip	581 B	581 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "1QFNHfTeyZWN1jkKZnjy5",
+        "buildId": "d5_eZ9KlnwzRj--jE1QV0",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/1QFNHfTeyZWN1jkKZnjy5/_buildManifest.js"
+      src="/_next/static/d5_eZ9KlnwzRj--jE1QV0/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/1QFNHfTeyZWN1jkKZnjy5/_ssgManifest.js"
+      src="/_next/static/d5_eZ9KlnwzRj--jE1QV0/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "1QFNHfTeyZWN1jkKZnjy5",
+        "buildId": "d5_eZ9KlnwzRj--jE1QV0",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/1QFNHfTeyZWN1jkKZnjy5/_buildManifest.js"
+      src="/_next/static/d5_eZ9KlnwzRj--jE1QV0/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/1QFNHfTeyZWN1jkKZnjy5/_ssgManifest.js"
+      src="/_next/static/d5_eZ9KlnwzRj--jE1QV0/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "1QFNHfTeyZWN1jkKZnjy5",
+        "buildId": "d5_eZ9KlnwzRj--jE1QV0",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/1QFNHfTeyZWN1jkKZnjy5/_buildManifest.js"
+      src="/_next/static/d5_eZ9KlnwzRj--jE1QV0/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/1QFNHfTeyZWN1jkKZnjy5/_ssgManifest.js"
+      src="/_next/static/d5_eZ9KlnwzRj--jE1QV0/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 906f2ab

ijjk · 2021-01-25T17:21:55Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	8.6s	8.7s	⚠️ +76ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +388 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.853	1.79	-0.06
/ avg req/sec	1349.27	1396.84	+47.57
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.134	1.114	-0.02
/error-in-render avg req/sec	2204.08	2243.55	+39.47

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	10.4s	11.3s	⚠️ +937ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +388 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.19 MB	5.19 MB	✓

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	11.3s	10.8s	-467ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +388 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.843	1.884	⚠️ +0.04
/ avg req/sec	1356.4	1326.64	⚠️ -29.76
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.142	1.098	-0.04
/error-in-render avg req/sec	2188.69	2276.77	+88.08

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
597-c48889ef..1870.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
index.html gzip	588 B	588 B	✓
link.html gzip	593 B	593 B	✓
withRouter.html gzip	581 B	581 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "FN56-qPmPfTkCcn_GFQYY",
+        "buildId": "jFfHDSZeP1saE-_ZUwTi2",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/FN56-qPmPfTkCcn_GFQYY/_buildManifest.js"
+      src="/_next/static/jFfHDSZeP1saE-_ZUwTi2/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/FN56-qPmPfTkCcn_GFQYY/_ssgManifest.js"
+      src="/_next/static/jFfHDSZeP1saE-_ZUwTi2/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "FN56-qPmPfTkCcn_GFQYY",
+        "buildId": "jFfHDSZeP1saE-_ZUwTi2",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/FN56-qPmPfTkCcn_GFQYY/_buildManifest.js"
+      src="/_next/static/jFfHDSZeP1saE-_ZUwTi2/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/FN56-qPmPfTkCcn_GFQYY/_ssgManifest.js"
+      src="/_next/static/jFfHDSZeP1saE-_ZUwTi2/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "FN56-qPmPfTkCcn_GFQYY",
+        "buildId": "jFfHDSZeP1saE-_ZUwTi2",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/FN56-qPmPfTkCcn_GFQYY/_buildManifest.js"
+      src="/_next/static/jFfHDSZeP1saE-_ZUwTi2/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/FN56-qPmPfTkCcn_GFQYY/_ssgManifest.js"
+      src="/_next/static/jFfHDSZeP1saE-_ZUwTi2/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 24f3459

ijjk · 2021-01-25T17:47:07Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	11.2s	11.6s	⚠️ +336ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +388 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.297	2.287	-0.01
/ avg req/sec	1088.2	1093	+4.8
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.648	1.621	-0.03
/error-in-render avg req/sec	1516.74	1541.79	+25.05

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	13.6s	13s	-532ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +388 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.19 MB	5.19 MB	✓

Webpack 5 Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	13.6s	13.5s	-162ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +388 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.289	2.333	⚠️ +0.04
/ avg req/sec	1092.37	1071.46	⚠️ -20.91
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.587	1.614	⚠️ +0.03
/error-in-render avg req/sec	1575.34	1548.67	⚠️ -26.67

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
597-c48889ef..1870.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
index.html gzip	588 B	588 B	✓
link.html gzip	593 B	593 B	✓
withRouter.html gzip	581 B	581 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "0-UU4-2yfhgybFGKzQwtC",
+        "buildId": "7xRR6BdDtMXkQTlmbP1Dc",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/0-UU4-2yfhgybFGKzQwtC/_buildManifest.js"
+      src="/_next/static/7xRR6BdDtMXkQTlmbP1Dc/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/0-UU4-2yfhgybFGKzQwtC/_ssgManifest.js"
+      src="/_next/static/7xRR6BdDtMXkQTlmbP1Dc/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "0-UU4-2yfhgybFGKzQwtC",
+        "buildId": "7xRR6BdDtMXkQTlmbP1Dc",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/0-UU4-2yfhgybFGKzQwtC/_buildManifest.js"
+      src="/_next/static/7xRR6BdDtMXkQTlmbP1Dc/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/0-UU4-2yfhgybFGKzQwtC/_ssgManifest.js"
+      src="/_next/static/7xRR6BdDtMXkQTlmbP1Dc/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "0-UU4-2yfhgybFGKzQwtC",
+        "buildId": "7xRR6BdDtMXkQTlmbP1Dc",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/0-UU4-2yfhgybFGKzQwtC/_buildManifest.js"
+      src="/_next/static/7xRR6BdDtMXkQTlmbP1Dc/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/0-UU4-2yfhgybFGKzQwtC/_ssgManifest.js"
+      src="/_next/static/7xRR6BdDtMXkQTlmbP1Dc/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: fbf49d7

ijjk · 2021-01-25T17:56:20Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	10.9s	11s	⚠️ +62ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +388 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.14	2.228	⚠️ +0.09
/ avg req/sec	1167.99	1122.22	⚠️ -45.77
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.31	1.331	⚠️ +0.02
/error-in-render avg req/sec	1909.06	1877.68	⚠️ -31.38

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	13s	12.9s	-85ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +388 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.19 MB	5.19 MB	✓

Webpack 5 Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	13s	13.2s	⚠️ +255ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +388 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.106	2.09	-0.02
/ avg req/sec	1186.85	1195.92	+9.07
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.336	1.346	⚠️ +0.01
/error-in-render avg req/sec	1870.78	1856.89	⚠️ -13.89

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
597-c48889ef..1870.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
index.html gzip	588 B	588 B	✓
link.html gzip	593 B	593 B	✓
withRouter.html gzip	581 B	581 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "xhm_w4xs-7gFWGE8je0wn",
+        "buildId": "Zxb2PUo9j-SItOhXoKw8z",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/xhm_w4xs-7gFWGE8je0wn/_buildManifest.js"
+      src="/_next/static/Zxb2PUo9j-SItOhXoKw8z/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/xhm_w4xs-7gFWGE8je0wn/_ssgManifest.js"
+      src="/_next/static/Zxb2PUo9j-SItOhXoKw8z/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "xhm_w4xs-7gFWGE8je0wn",
+        "buildId": "Zxb2PUo9j-SItOhXoKw8z",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/xhm_w4xs-7gFWGE8je0wn/_buildManifest.js"
+      src="/_next/static/Zxb2PUo9j-SItOhXoKw8z/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/xhm_w4xs-7gFWGE8je0wn/_ssgManifest.js"
+      src="/_next/static/Zxb2PUo9j-SItOhXoKw8z/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "xhm_w4xs-7gFWGE8je0wn",
+        "buildId": "Zxb2PUo9j-SItOhXoKw8z",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/xhm_w4xs-7gFWGE8je0wn/_buildManifest.js"
+      src="/_next/static/Zxb2PUo9j-SItOhXoKw8z/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/xhm_w4xs-7gFWGE8je0wn/_ssgManifest.js"
+      src="/_next/static/Zxb2PUo9j-SItOhXoKw8z/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 1a6b843

ijjk · 2021-01-25T18:01:54Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	12.1s	12.1s	⚠️ +7ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +388 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.326	2.349	⚠️ +0.02
/ avg req/sec	1074.62	1064.49	⚠️ -10.13
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.767	1.615	-0.15
/error-in-render avg req/sec	1414.58	1548.1	+133.52

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	14.2s	14.4s	⚠️ +157ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +388 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.19 MB	5.19 MB	✓

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	14.5s	14.4s	-186ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +388 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.393	2.432	⚠️ +0.04
/ avg req/sec	1044.81	1027.76	⚠️ -17.05
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.692	1.63	-0.06
/error-in-render avg req/sec	1477.64	1533.3	+55.66

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
597-c48889ef..1870.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
index.html gzip	588 B	588 B	✓
link.html gzip	593 B	593 B	✓
withRouter.html gzip	581 B	581 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "LWAwe2W-l9wno9xMbl7gF",
+        "buildId": "wRetqvBlVSn89fw6r7IHF",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/LWAwe2W-l9wno9xMbl7gF/_buildManifest.js"
+      src="/_next/static/wRetqvBlVSn89fw6r7IHF/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/LWAwe2W-l9wno9xMbl7gF/_ssgManifest.js"
+      src="/_next/static/wRetqvBlVSn89fw6r7IHF/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "LWAwe2W-l9wno9xMbl7gF",
+        "buildId": "wRetqvBlVSn89fw6r7IHF",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/LWAwe2W-l9wno9xMbl7gF/_buildManifest.js"
+      src="/_next/static/wRetqvBlVSn89fw6r7IHF/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/LWAwe2W-l9wno9xMbl7gF/_ssgManifest.js"
+      src="/_next/static/wRetqvBlVSn89fw6r7IHF/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "LWAwe2W-l9wno9xMbl7gF",
+        "buildId": "wRetqvBlVSn89fw6r7IHF",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/LWAwe2W-l9wno9xMbl7gF/_buildManifest.js"
+      src="/_next/static/wRetqvBlVSn89fw6r7IHF/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/LWAwe2W-l9wno9xMbl7gF/_ssgManifest.js"
+      src="/_next/static/wRetqvBlVSn89fw6r7IHF/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: e3e5ced

ijjk · 2021-01-25T18:12:19Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	10.4s	10.5s	⚠️ +127ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +388 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.043	2.049	⚠️ +0.01
/ avg req/sec	1223.49	1220.38	⚠️ -3.11
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.305	1.326	⚠️ +0.02
/error-in-render avg req/sec	1915.56	1885.46	⚠️ -30.1

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	12.7s	12.3s	-380ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +388 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.19 MB	5.19 MB	✓

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
buildDuration	12.7s	12.6s	-141ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +388 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.078	2.085	⚠️ +0.01
/ avg req/sec	1203.04	1199.15	⚠️ -3.89
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.35	1.273	-0.08
/error-in-render avg req/sec	1852.54	1963.89	+111.35

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
597-c48889ef..1870.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	kaykdm/next.js fix/gip-aspath	Change
index.html gzip	587 B	587 B	✓
link.html gzip	591 B	591 B	✓
withRouter.html gzip	580 B	580 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "qaonJyEQbrHX1YyC5ky5J",
+        "buildId": "V2hsiHlzBDCJ5S0BvsgIV",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/qaonJyEQbrHX1YyC5ky5J/_buildManifest.js"
+      src="/_next/static/V2hsiHlzBDCJ5S0BvsgIV/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/qaonJyEQbrHX1YyC5ky5J/_ssgManifest.js"
+      src="/_next/static/V2hsiHlzBDCJ5S0BvsgIV/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "qaonJyEQbrHX1YyC5ky5J",
+        "buildId": "V2hsiHlzBDCJ5S0BvsgIV",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/qaonJyEQbrHX1YyC5ky5J/_buildManifest.js"
+      src="/_next/static/V2hsiHlzBDCJ5S0BvsgIV/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/qaonJyEQbrHX1YyC5ky5J/_ssgManifest.js"
+      src="/_next/static/V2hsiHlzBDCJ5S0BvsgIV/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "qaonJyEQbrHX1YyC5ky5J",
+        "buildId": "V2hsiHlzBDCJ5S0BvsgIV",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/qaonJyEQbrHX1YyC5ky5J/_buildManifest.js"
+      src="/_next/static/V2hsiHlzBDCJ5S0BvsgIV/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/qaonJyEQbrHX1YyC5ky5J/_ssgManifest.js"
+      src="/_next/static/V2hsiHlzBDCJ5S0BvsgIV/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 2447299

kaykdm requested review from ijjk, lfades, Timer and timneutkens as code owners December 29, 2020 13:43

ijjk added the type: next label Dec 29, 2020

vercel bot temporarily deployed to Preview December 29, 2020 13:44 Inactive

kaykdm changed the title ~~Fix aspath for GIP~~ Fix aspath for getInitialProps Dec 30, 2020

Kanta Kodama added 2 commits January 14, 2021 17:56

Fix aspath for GIP

c08c77a

add test

991dbc7

kaykdm force-pushed the fix/gip-aspath branch from 6fa33b8 to 991dbc7 Compare January 15, 2021 09:46

Merge branch 'canary' into fix/gip-aspath

27b7dd1

kaykdm closed this Jan 23, 2021

kaykdm reopened this Jan 23, 2021

kaykdm marked this pull request as draft January 23, 2021 13:54

ijjk marked this pull request as ready for review January 25, 2021 15:43

ijjk approved these changes Jan 25, 2021

View reviewed changes

Merge branch 'canary' into fix/gip-aspath

906f2ab

Timer and others added 2 commits January 25, 2021 12:09

Merge branch 'canary' into fix/gip-aspath

5c21e6a

Merge branch 'canary' into fix/gip-aspath

24f3459

kodiakhq bot added 2 commits January 25, 2021 17:35

Merge branch 'canary' into fix/gip-aspath

fbf49d7

Merge branch 'canary' into fix/gip-aspath

1a6b843

Merge branch 'canary' into fix/gip-aspath

e3e5ced

Merge branch 'canary' into fix/gip-aspath

2447299

kodiakhq bot merged commit 47cb4cf into vercel:canary Jan 25, 2021

kaykdm deleted the fix/gip-aspath branch January 26, 2021 01:01

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix aspath for getInitialProps #20572

Fix aspath for getInitialProps #20572

kaykdm commented Dec 29, 2020 •

edited

Loading

ijjk commented Dec 29, 2020

kaykdm commented Dec 29, 2020 •

edited

Loading

ijjk commented Jan 6, 2021

ijjk commented Jan 15, 2021

ijjk commented Jan 23, 2021

Diffs

kaykdm commented Jan 23, 2021 •

edited

Loading

ijjk left a comment

ijjk commented Jan 25, 2021 •

edited

Loading

ijjk commented Jan 25, 2021

Diffs

ijjk commented Jan 25, 2021

Diffs

ijjk commented Jan 25, 2021

Diffs

ijjk commented Jan 25, 2021

Diffs

ijjk commented Jan 25, 2021

Diffs

ijjk commented Jan 25, 2021

Diffs

Fix aspath for getInitialProps #20572

Fix aspath for getInitialProps #20572

Conversation

kaykdm commented Dec 29, 2020 • edited Loading

ijjk commented Dec 29, 2020

Stats from current PR

kaykdm commented Dec 29, 2020 • edited Loading

ijjk commented Jan 6, 2021

Stats from current PR

ijjk commented Jan 15, 2021

Stats from current PR

ijjk commented Jan 23, 2021

Stats from current PR

Diffs

kaykdm commented Jan 23, 2021 • edited Loading

ijjk left a comment

Choose a reason for hiding this comment

ijjk commented Jan 25, 2021 • edited Loading

Failing test suites

ijjk commented Jan 25, 2021

Stats from current PR

Diffs

ijjk commented Jan 25, 2021

Stats from current PR

Diffs

ijjk commented Jan 25, 2021

Stats from current PR

Diffs

ijjk commented Jan 25, 2021

Stats from current PR

Diffs

ijjk commented Jan 25, 2021

Stats from current PR

Diffs

ijjk commented Jan 25, 2021

Stats from current PR

Diffs

kaykdm commented Dec 29, 2020 •

edited

Loading

kaykdm commented Dec 29, 2020 •

edited

Loading

kaykdm commented Jan 23, 2021 •

edited

Loading

ijjk commented Jan 25, 2021 •

edited

Loading