Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): require test files be full name or extension #20605

Merged
merged 2 commits into from
Dec 30, 2020
Merged

fix(build): require test files be full name or extension #20605

merged 2 commits into from
Dec 30, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Dec 30, 2020

Fixes #19935

@vercel vercel bot temporarily deployed to Preview December 30, 2020 14:47 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 30, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
buildDuration 10.8s 10.9s ⚠️ +52ms
nodeModulesSize 83 MB 83 MB ⚠️ +452 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.124 2.205 ⚠️ +0.08
/ avg req/sec 1176.97 1133.91 ⚠️ -43.06
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.357 1.364 ⚠️ +0.01
/error-in-render avg req/sec 1842.83 1832.65 ⚠️ -10.18
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
677f882d2ed8..0acf.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-29e0222..8425.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.1 kB 59.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-21c7af4..bddc.js gzip 1.6 kB 1.6 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.04 kB 8.04 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
_buildManifest.js gzip 320 B 320 B ✓
Overall change 320 B 320 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 609 B 609 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
buildDuration 13.1s 13.1s ⚠️ +65ms
nodeModulesSize 83 MB 83 MB ⚠️ +452 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
677f882d2ed8..0acf.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-29e0222..8425.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.1 kB 59.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-21c7af4..bddc.js gzip 1.6 kB 1.6 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.04 kB 8.04 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
_buildManifest.js gzip 320 B 320 B ✓
Overall change 320 B 320 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: 004b145

@vercel vercel bot temporarily deployed to Preview December 30, 2020 15:27 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 30, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
buildDuration 10.8s 10.8s ⚠️ +40ms
nodeModulesSize 83 MB 83 MB ⚠️ +452 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.111 2.109 0
/ avg req/sec 1184 1185.47 +1.47
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.374 1.326 -0.05
/error-in-render avg req/sec 1819.23 1885.32 +66.09
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
677f882d2ed8..0acf.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-29e0222..8425.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.1 kB 59.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-21c7af4..bddc.js gzip 1.6 kB 1.6 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.04 kB 8.04 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
_buildManifest.js gzip 320 B 320 B ✓
Overall change 320 B 320 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 609 B 609 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
buildDuration 13.4s 12.8s -524ms
nodeModulesSize 83 MB 83 MB ⚠️ +452 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
677f882d2ed8..0acf.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-29e0222..8425.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.1 kB 59.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-21c7af4..bddc.js gzip 1.6 kB 1.6 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.04 kB 8.04 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
_buildManifest.js gzip 320 B 320 B ✓
Overall change 320 B 320 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/lookbehind-folder-or-extension Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: d227139

@kodiakhq kodiakhq bot merged commit 3246274 into vercel:canary Dec 30, 2020
@Timer Timer deleted the hotfix/lookbehind-folder-or-extension branch December 30, 2020 16:05
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type checking skipped for files with names like pages/contest.tsx
2 participants
@Timer @ijjk