Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(next/image): reduce byte waste for 3x screens #20610

Merged
merged 4 commits into from
Dec 30, 2020
Merged

feat(next/image): reduce byte waste for 3x screens #20610

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c895f8e
feat(next/image): reduce byte waste for 3x screens
Timer Dec 30, 2020
8369620
update tests
Timer Dec 30, 2020
4a8f7aa
Merge remote-tracking branch 'upstream/canary' into feat/reduce-byte-…
Timer Dec 30, 2020
54a2700
fix more sizes
Timer Dec 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/next/client/image.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,15 @@ function getWidths(

const widths = [
...new Set(
[width, width * 2, width * 3].map(
// > This means that most OLED screens that say they are 3x resolution,
// > are actually 3x in the green color, but only 1.5x in the red and
// > blue colors. Showing a 3x resolution image in the app vs a 2x
// > resolution image will be visually the same, though the 3x image
// > takes significantly more data. Even true 3x resolution screens are
// > wasteful as the human eye cannot see that level of detail without
// > something like a magnifying glass.
// https://blog.twitter.com/engineering/en_us/topics/infrastructure/2019/capping-image-fidelity-on-ultra-high-resolution-devices.html
[width, width * 2 /*, width * 3*/].map(
(w) => allSizes.find((p) => p >= w) || allSizes[allSizes.length - 1]
)
),
Expand Down