Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(source map): correctly generate source maps #20672

Merged
merged 2 commits into from
Jan 1, 2021
Merged

fix(source map): correctly generate source maps #20672

merged 2 commits into from
Jan 1, 2021

Conversation

Timer
Copy link
Member

@Timer Timer commented Jan 1, 2021

Fixes #20500

@ijjk ijjk added the type: next label Jan 1, 2021
@ijjk
Copy link
Member

ijjk commented Jan 1, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/source-maps Change
buildDuration 11.3s 11.4s ⚠️ +117ms
nodeModulesSize 83 MB 83 MB -137 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js hotfix/source-maps Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.257 2.212 -0.04
/ avg req/sec 1107.78 1130.22 +22.44
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.65 1.647 0
/error-in-render avg req/sec 1514.87 1518.18 +3.31
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/source-maps Change
677f882d2ed8..dbe2.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-212f85f..f23b.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/source-maps Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/source-maps Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-b862cd7..dba8.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/source-maps Change
_buildManifest.js gzip 321 B 323 B ⚠️ +2 B
Overall change 321 B 323 B ⚠️ +2 B
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/source-maps Change
index.html gzip 616 B 613 B -3 B
link.html gzip 621 B 620 B -1 B
withRouter.html gzip 610 B 607 B -3 B
Overall change 1.85 kB 1.84 kB -7 B
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/source-maps Change
buildDuration 13.2s 13.4s ⚠️ +198ms
nodeModulesSize 83 MB 83 MB -137 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/source-maps Change
677f882d2ed8..dbe2.js gzip 13 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-212f85f..f23b.js gzip 6.59 kB N/A N/A
webpack-7193..1446.js gzip 751 B N/A N/A
677f882d2ed8..42af.js gzip N/A 13 kB N/A
main-bec4e5d..f123.js gzip N/A 6.59 kB N/A
webpack-50be..df5b.js gzip N/A 751 B N/A
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/source-maps Change
polyfills-67..b7d1.js gzip 31.2 kB N/A N/A
polyfills-81..14d7.js gzip N/A 31.2 kB N/A
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/source-maps Change
_app-6220e08..9a40.js gzip 1.28 kB N/A N/A
_error-4b0b5..2c91.js gzip 3.44 kB N/A N/A
hooks-5f309a..7282.js gzip 887 B N/A N/A
index-57f580..c562.js gzip 227 B N/A N/A
link-b862cd7..dba8.js gzip 1.64 kB N/A N/A
routerDirect..bd82.js gzip 303 B N/A N/A
withRouter-2..e384.js gzip 302 B N/A N/A
_app-b6fc6bc..222c.js gzip N/A 1.28 kB N/A
_error-cfcb6..fe1c.js gzip N/A 3.44 kB N/A
hooks-010c20..8411.js gzip N/A 887 B N/A
index-bbee2f..528b.js gzip N/A 227 B N/A
link-705099c..c35d.js gzip N/A 1.64 kB N/A
routerDirect..bf84.js gzip N/A 303 B N/A
withRouter-a..5826.js gzip N/A 302 B N/A
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/source-maps Change
_buildManifest.js gzip 321 B 323 B ⚠️ +2 B
Overall change 321 B 323 B ⚠️ +2 B
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/source-maps Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: 392e31c

@ijjk
Copy link
Member

ijjk commented Jan 1, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/source-maps Change
buildDuration 10.5s 10.4s -108ms
nodeModulesSize 83 MB 83 MB -137 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js hotfix/source-maps Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.053 2.036 -0.02
/ avg req/sec 1218.01 1227.72 +9.71
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.318 1.271 -0.05
/error-in-render avg req/sec 1896.37 1967.25 +70.88
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/source-maps Change
677f882d2ed8..dbe2.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-212f85f..f23b.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/source-maps Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/source-maps Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-b862cd7..dba8.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/source-maps Change
_buildManifest.js gzip 321 B 323 B ⚠️ +2 B
Overall change 321 B 323 B ⚠️ +2 B
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/source-maps Change
index.html gzip 616 B 613 B -3 B
link.html gzip 621 B 620 B -1 B
withRouter.html gzip 610 B 607 B -3 B
Overall change 1.85 kB 1.84 kB -7 B
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/source-maps Change
buildDuration 12.4s 12.4s ⚠️ +18ms
nodeModulesSize 83 MB 83 MB -137 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/source-maps Change
677f882d2ed8..dbe2.js gzip 13 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-212f85f..f23b.js gzip 6.59 kB N/A N/A
webpack-7193..1446.js gzip 751 B N/A N/A
677f882d2ed8..42af.js gzip N/A 13 kB N/A
main-bec4e5d..f123.js gzip N/A 6.59 kB N/A
webpack-50be..df5b.js gzip N/A 751 B N/A
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/source-maps Change
polyfills-67..b7d1.js gzip 31.2 kB N/A N/A
polyfills-81..14d7.js gzip N/A 31.2 kB N/A
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/source-maps Change
_app-6220e08..9a40.js gzip 1.28 kB N/A N/A
_error-4b0b5..2c91.js gzip 3.44 kB N/A N/A
hooks-5f309a..7282.js gzip 887 B N/A N/A
index-57f580..c562.js gzip 227 B N/A N/A
link-b862cd7..dba8.js gzip 1.64 kB N/A N/A
routerDirect..bd82.js gzip 303 B N/A N/A
withRouter-2..e384.js gzip 302 B N/A N/A
_app-b6fc6bc..222c.js gzip N/A 1.28 kB N/A
_error-cfcb6..fe1c.js gzip N/A 3.44 kB N/A
hooks-010c20..8411.js gzip N/A 887 B N/A
index-bbee2f..528b.js gzip N/A 227 B N/A
link-705099c..c35d.js gzip N/A 1.64 kB N/A
routerDirect..bf84.js gzip N/A 303 B N/A
withRouter-a..5826.js gzip N/A 302 B N/A
Overall change 8.08 kB 8.08 kB ✓
Client Build Manifests Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/source-maps Change
_buildManifest.js gzip 321 B 323 B ⚠️ +2 B
Overall change 321 B 323 B ⚠️ +2 B
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/source-maps Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: d91534c

@kodiakhq kodiakhq bot merged commit 2c75fa0 into vercel:canary Jan 1, 2021
@ijjk ijjk deleted the hotfix/source-maps branch January 1, 2021 20:30
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Production source maps show webpack-generated files rather than source files in 10.0.4
2 participants
@Timer @ijjk