Wrong index path revalidation timer #20818

AriFreyr · 2021-01-06T16:29:31Z

Hello friends

Ran into this bug on our production site, prerenderManifest stores revalidation info for the index as "/": { .. }, but the code tries to access this information as "/index".

This leads to our index page always having s-max-age: 1

ijjk · 2021-01-07T19:41:06Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
buildDuration	10.7s	10.8s	⚠️ +130ms
nodeModulesSize	80.8 MB	80.8 MB	⚠️ +159 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.242	2.154	-0.09
/ avg req/sec	1115.06	1160.61	+45.55
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.525	1.545	⚠️ +0.02
/error-in-render avg req/sec	1639.63	1618.04	⚠️ -21.59

Client Bundles (main, webpack, commons)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
677f882d2ed8..89aa.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-dba4ec1..27c0.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_app-b6fc6bc..222c.js gzip	1.28 kB	1.28 kB	✓
_error-e2ffa..0f3f.js gzip	3.46 kB	3.46 kB	✓
hooks-010c20..8411.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-d979103..c5ff.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
index.html gzip	614 B	614 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	606 B	606 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
buildDuration	12.5s	12.5s	⚠️ +57ms
nodeModulesSize	80.8 MB	80.8 MB	⚠️ +159 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
677f882d2ed8..89aa.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-dba4ec1..27c0.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_app-b6fc6bc..222c.js gzip	1.28 kB	1.28 kB	✓
_error-e2ffa..0f3f.js gzip	3.46 kB	3.46 kB	✓
hooks-010c20..8411.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-d979103..c5ff.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.18 MB	5.18 MB	✓

Commit: 50a3105

timneutkens

Could you add an integration test to test/integration/ for this behavior?

AriFreyr · 2021-01-11T19:36:12Z

Could you add an integration test to test/integration/ for this behavior?

Yes! I added a test that will fail without this fix

ijjk · 2021-01-11T19:44:46Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
buildDuration	9.9s	10s	⚠️ +42ms
nodeModulesSize	80.8 MB	80.8 MB	⚠️ +159 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2	2.021	⚠️ +0.02
/ avg req/sec	1249.98	1236.87	⚠️ -13.11
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.253	1.248	0
/error-in-render avg req/sec	1994.94	2003.64	+8.7

Client Bundles (main, webpack, commons)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
677f882d2ed8..b025.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e66dcae..6635.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
index.html gzip	615 B	615 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
buildDuration	12.4s	12.1s	-266ms
nodeModulesSize	80.8 MB	80.8 MB	⚠️ +159 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
677f882d2ed8..b025.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e66dcae..6635.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.18 MB	5.18 MB	✓

Commit: 508cf2b

ijjk · 2021-01-11T20:04:18Z

Failing test suites

Commit: 508cf2b

test/integration/prerender/test/index.test.js

SSG Prerender > dev mode > should use correct caching headers for a revalidate page
SSG Prerender > enumlated serverless mode > outputs a prerender-manifest correctly
SSG Prerender > production mode > outputs a prerender-manifest correctly
SSG Prerender > serverless mode > outputs a prerender-manifest correctly

Expand output

● SSG Prerender › dev mode › should use correct caching headers for a revalidate page

expect(received).toBe(expected) // Object.is equality

Expected: "s-maxage=2, stale-while-revalidate"
Received: null

  524 |   it('should use correct caching headers for a revalidate page', async () => {
  525 |     const initialRes = await fetchViaHTTP(appPort, '/')
> 526 |     expect(initialRes.headers.get('cache-control')).toBe(
      |                                                     ^
  527 |       's-maxage=2, stale-while-revalidate'
  528 |     )
  529 |   })

  at Object.<anonymous> (integration/prerender/test/index.test.js:526:53)

● SSG Prerender › serverless mode › outputs a prerender-manifest correctly

expect(received).toEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

@@ -1,9 +1,9 @@
  Object {
    "/": Object {
      "dataRoute": "/_next/data/WhRCcfPsOs6n7DC5vnpu4/index.json",
-     "initialRevalidateSeconds": 1,
+     "initialRevalidateSeconds": 2,
      "srcRoute": null,
    },
    "/another": Object {
      "dataRoute": "/_next/data/WhRCcfPsOs6n7DC5vnpu4/another.json",
      "initialRevalidateSeconds": 1,

  1434 | 
  1435 |       expect(manifest.version).toBe(2)
> 1436 |       expect(manifest.routes).toEqual(expectedManifestRoutes())
       |                               ^
  1437 |       expect(manifest.dynamicRoutes).toEqual({
  1438 |         '/api-docs/[...slug]': {
  1439 |           dataRoute: `/_next/data/${buildId}/api-docs/[...slug].json`,

  at Object.<anonymous> (integration/prerender/test/index.test.js:1436:31)

● SSG Prerender › enumlated serverless mode › outputs a prerender-manifest correctly

expect(received).toEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

@@ -1,9 +1,9 @@
  Object {
    "/": Object {
      "dataRoute": "/_next/data/dWNNKXPd87_f3C_iyFRdh/index.json",
-     "initialRevalidateSeconds": 1,
+     "initialRevalidateSeconds": 2,
      "srcRoute": null,
    },
    "/another": Object {
      "dataRoute": "/_next/data/dWNNKXPd87_f3C_iyFRdh/another.json",
      "initialRevalidateSeconds": 1,

  1434 | 
  1435 |       expect(manifest.version).toBe(2)
> 1436 |       expect(manifest.routes).toEqual(expectedManifestRoutes())
       |                               ^
  1437 |       expect(manifest.dynamicRoutes).toEqual({
  1438 |         '/api-docs/[...slug]': {
  1439 |           dataRoute: `/_next/data/${buildId}/api-docs/[...slug].json`,

  at Object.<anonymous> (integration/prerender/test/index.test.js:1436:31)

● SSG Prerender › production mode › outputs a prerender-manifest correctly

expect(received).toEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

@@ -1,9 +1,9 @@
  Object {
    "/": Object {
      "dataRoute": "/_next/data/Vtw9Ox4vmtXACOVYFgp8w/index.json",
-     "initialRevalidateSeconds": 1,
+     "initialRevalidateSeconds": 2,
      "srcRoute": null,
    },
    "/another": Object {
      "dataRoute": "/_next/data/Vtw9Ox4vmtXACOVYFgp8w/another.json",
      "initialRevalidateSeconds": 1,

  1434 | 
  1435 |       expect(manifest.version).toBe(2)
> 1436 |       expect(manifest.routes).toEqual(expectedManifestRoutes())
       |                               ^
  1437 |       expect(manifest.dynamicRoutes).toEqual({
  1438 |         '/api-docs/[...slug]': {
  1439 |           dataRoute: `/_next/data/${buildId}/api-docs/[...slug].json`,

  at Object.<anonymous> (integration/prerender/test/index.test.js:1436:31)

ijjk · 2021-01-11T20:40:16Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
buildDuration	10.1s	10.2s	⚠️ +107ms
nodeModulesSize	80.8 MB	80.8 MB	⚠️ +159 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.996	2.072	⚠️ +0.08
/ avg req/sec	1252.65	1206.41	⚠️ -46.24
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.337	1.294	-0.04
/error-in-render avg req/sec	1869.8	1932.74	+62.94

Client Bundles (main, webpack, commons)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
677f882d2ed8..b025.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e66dcae..6635.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
index.html gzip	615 B	615 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
buildDuration	12.7s	12.3s	-406ms
nodeModulesSize	80.8 MB	80.8 MB	⚠️ +159 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
677f882d2ed8..b025.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e66dcae..6635.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.18 MB	5.18 MB	✓

Commit: 91192e5

ijjk · 2021-01-11T20:49:27Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
buildDuration	8.7s	8.7s	-24ms
nodeModulesSize	80.8 MB	80.8 MB	⚠️ +159 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.72	1.729	⚠️ +0.01
/ avg req/sec	1453.45	1445.6	⚠️ -7.85
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.139	1.084	-0.05
/error-in-render avg req/sec	2194.2	2305.79	+111.59

Client Bundles (main, webpack, commons)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
677f882d2ed8..b025.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e66dcae..6635.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
index.html gzip	615 B	615 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
buildDuration	10.3s	10.4s	⚠️ +185ms
nodeModulesSize	80.8 MB	80.8 MB	⚠️ +159 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
677f882d2ed8..b025.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e66dcae..6635.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.18 MB	5.18 MB	✓

Commit: 75357d6

ijjk · 2021-01-12T11:05:01Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
buildDuration	9.6s	10s	⚠️ +439ms
nodeModulesSize	80.9 MB	80.9 MB	⚠️ +159 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2	1.813	-0.19
/ avg req/sec	1250.22	1378.87	+128.65
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.197	1.186	-0.01
/error-in-render avg req/sec	2089.11	2107.4	+18.29

Client Bundles (main, webpack, commons)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
677f882d2ed8..b025.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e66dcae..6635.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
index.html gzip	615 B	615 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
buildDuration	11.7s	10.9s	-831ms
nodeModulesSize	80.9 MB	80.9 MB	⚠️ +159 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
677f882d2ed8..b025.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e66dcae..6635.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.18 MB	5.18 MB	✓

Commit: c292401

ijjk · 2021-01-12T12:25:51Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
buildDuration	8.8s	8.8s	-83ms
nodeModulesSize	80.9 MB	80.9 MB	⚠️ +159 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.769	1.753	-0.02
/ avg req/sec	1412.99	1426.53	+13.54
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.124	1.12	0
/error-in-render avg req/sec	2224.87	2233.05	+8.18

Client Bundles (main, webpack, commons)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
677f882d2ed8..b025.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e66dcae..6635.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
index.html gzip	615 B	615 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
buildDuration	10.5s	10.5s	⚠️ +52ms
nodeModulesSize	80.9 MB	76.2 MB	-4.69 MB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
677f882d2ed8..b025.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e66dcae..6635.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.18 MB	5.18 MB	✓

Commit: 0d7d4e5

timneutkens · 2021-01-13T14:53:54Z

Thanks!

ijjk · 2021-01-13T16:03:53Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
buildDuration	10.4s	10.5s	⚠️ +41ms
nodeModulesSize	80.9 MB	80.9 MB	⚠️ +159 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.052	2.111	⚠️ +0.06
/ avg req/sec	1218.33	1184.36	⚠️ -33.97
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.322	1.346	⚠️ +0.02
/error-in-render avg req/sec	1890.78	1857.22	⚠️ -33.56

Client Bundles (main, webpack, commons)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
677f882d2ed8..b025.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e66dcae..6635.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
index.html gzip	615 B	615 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
buildDuration	12.8s	12.4s	-396ms
nodeModulesSize	80.9 MB	80.9 MB	⚠️ +159 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
677f882d2ed8..b025.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e66dcae..6635.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	AriFreyr/next.js index_path_revalidation	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.18 MB	5.18 MB	✓

Commit: ba923fd

AriFreyr added 2 commits January 6, 2021 16:20

use route for prerender manifest path

515c930

delete test artifact

e2a3f4f

AriFreyr requested review from ijjk, lfades, Timer and timneutkens as code owners January 6, 2021 16:29

ijjk added the type: next label Jan 6, 2021

Merge branch 'canary' into index_path_revalidation

50a3105

timneutkens requested changes Jan 11, 2021

View reviewed changes

add integration test for maxage header

508cf2b

Update index.test.js

91192e5

Cache headers are not set in dev mode

75357d6

fix prettier

c292401

Merge branch 'canary' into index_path_revalidation

0d7d4e5

timneutkens approved these changes Jan 13, 2021

View reviewed changes

Merge branch 'canary' into index_path_revalidation

ba923fd

kodiakhq bot merged commit 69ff95f into vercel:canary Jan 13, 2021

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wrong index path revalidation timer #20818

Wrong index path revalidation timer #20818

AriFreyr commented Jan 6, 2021

ijjk commented Jan 7, 2021

timneutkens left a comment

AriFreyr commented Jan 11, 2021

ijjk commented Jan 11, 2021

ijjk commented Jan 11, 2021

ijjk commented Jan 11, 2021

ijjk commented Jan 11, 2021

ijjk commented Jan 12, 2021

ijjk commented Jan 12, 2021

timneutkens commented Jan 13, 2021

ijjk commented Jan 13, 2021

Wrong index path revalidation timer #20818

Wrong index path revalidation timer #20818

Conversation

AriFreyr commented Jan 6, 2021

ijjk commented Jan 7, 2021

Stats from current PR

timneutkens left a comment

Choose a reason for hiding this comment

AriFreyr commented Jan 11, 2021

ijjk commented Jan 11, 2021

Stats from current PR

ijjk commented Jan 11, 2021

Failing test suites

ijjk commented Jan 11, 2021

Stats from current PR

ijjk commented Jan 11, 2021

Stats from current PR

ijjk commented Jan 12, 2021

Stats from current PR

ijjk commented Jan 12, 2021

Stats from current PR

timneutkens commented Jan 13, 2021

ijjk commented Jan 13, 2021

Stats from current PR