Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add isReady field test for TS #20821

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

Timer
Copy link
Member

@Timer Timer commented Jan 6, 2021

@ijjk
Copy link
Member

ijjk commented Jan 6, 2021

Stats from current PR

Default Server Mode
General
vercel/next.js canary Timer/next.js test/add-is-ready-ts-test Change
buildDuration 10.6s 10.7s ⚠️ +99ms
nodeModulesSize 80.8 MB 80.8 MB
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js test/add-is-ready-ts-test Change
/ failed reqs 0 0
/ total time (seconds) 2.089 2.101 ⚠️ +0.01
/ avg req/sec 1196.74 1189.74 ⚠️ -7
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.423 1.416 -0.01
/error-in-render avg req/sec 1756.63 1765.78 +9.15
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js test/add-is-ready-ts-test Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-8b99f8a..8ccf.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js test/add-is-ready-ts-test Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary Timer/next.js test/add-is-ready-ts-test Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB
hooks-010c20..8411.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary Timer/next.js test/add-is-ready-ts-test Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Rendered Page Sizes
vercel/next.js canary Timer/next.js test/add-is-ready-ts-test Change
index.html gzip 613 B 613 B
link.html gzip 618 B 618 B
withRouter.html gzip 606 B 606 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General
vercel/next.js canary Timer/next.js test/add-is-ready-ts-test Change
buildDuration 12.7s 12.8s ⚠️ +164ms
nodeModulesSize 80.8 MB 80.8 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js test/add-is-ready-ts-test Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-8b99f8a..8ccf.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js test/add-is-ready-ts-test Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary Timer/next.js test/add-is-ready-ts-test Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB
hooks-010c20..8411.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary Timer/next.js test/add-is-ready-ts-test Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Serverless bundles
vercel/next.js canary Timer/next.js test/add-is-ready-ts-test Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.18 MB 5.18 MB
Commit: ce41f15

@Timer Timer merged commit b580bea into vercel:canary Jan 6, 2021
@Timer Timer deleted the test/add-is-ready-ts-test branch January 6, 2021 18:14
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants