Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve with firebase cloud messaging #20868

Merged
merged 3 commits into from
Jan 11, 2021
Merged

Improve with firebase cloud messaging #20868

merged 3 commits into from
Jan 11, 2021

Conversation

VictorAssis
Copy link
Contributor

Fix #20826.

Remove unnecessary dependencies and custom server to implement Firebase Cloud Messaging.

@ijjk ijjk added the examples Issue/PR related to examples label Jan 7, 2021
@ijjk
Copy link
Member

ijjk commented Jan 7, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
buildDuration 10.9s 10.6s -229ms
nodeModulesSize 80.8 MB 80.8 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.111 2.055 -0.06
/ avg req/sec 1184.23 1216.56 +32.33
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.415 1.367 -0.05
/error-in-render avg req/sec 1766.23 1828.36 +62.13
Client Bundles (main, webpack, commons)
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
index.html gzip 614 B 614 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
buildDuration 12.8s 12.4s -381ms
nodeModulesSize 80.8 MB 80.8 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: 33dabe0

@ijjk
Copy link
Member

ijjk commented Jan 7, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
buildDuration 9.3s 9.5s ⚠️ +195ms
nodeModulesSize 80.8 MB 80.8 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.837 1.972 ⚠️ +0.14
/ avg req/sec 1361.1 1267.94 ⚠️ -93.16
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.198 1.213 ⚠️ +0.02
/error-in-render avg req/sec 2086.76 2060.31 ⚠️ -26.45
Client Bundles (main, webpack, commons)
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
index.html gzip 614 B 614 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
buildDuration 11.4s 11.4s ⚠️ +5ms
nodeModulesSize 80.8 MB 80.8 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary VictorAssis/next.js improve-with-firebase-cloud-messaging Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: e164b1b

@timneutkens timneutkens merged commit 86bb064 into vercel:canary Jan 11, 2021
@timneutkens
Copy link
Member

Thanks!

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lachlanjc lachlanjc lachlanjc left review comments

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom server is not necessary in with-firebase-cloud-messaging
4 participants
@VictorAssis @ijjk @timneutkens @lachlanjc