Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(examples): make with-graphql-hooks run correctly again #20929

Merged
merged 2 commits into from
Jan 11, 2021
Merged

fix(examples): make with-graphql-hooks run correctly again #20929

merged 2 commits into from
Jan 11, 2021

Conversation

ludofischer
Copy link
Contributor

Fixes #20474

  • Switch API url to working URL used in apollo example
  • Update deps
  • Move styled jsx out of the way to avoid demonstrating too many
    unfamiliar concepts at once

dev, build and start work now.

@ijjk ijjk added the examples Issue/PR related to examples label Jan 9, 2021
@ludofischer ludofischer mentioned this pull request Jan 9, 2021
Closed
@ijjk
Copy link
Member

ijjk commented Jan 9, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
buildDuration 10.4s 10.6s ⚠️ +151ms
nodeModulesSize 80.8 MB 80.8 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.061 2.064 0
/ avg req/sec 1213.28 1211.44 ⚠️ -1.84
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.313 1.349 ⚠️ +0.04
/error-in-render avg req/sec 1904.66 1853.02 ⚠️ -51.64
Client Bundles (main, webpack, commons)
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
index.html gzip 614 B 614 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
buildDuration 12.9s 12.6s -363ms
nodeModulesSize 80.8 MB 80.8 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: 475c9ce

@ludofischer ludofischer changed the title Make with-graphql-hooks start and run correctly again fix(examples): make with-graphql-hooks run correctly again Jan 10, 2021
@ijjk
Copy link
Member

ijjk commented Jan 10, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
buildDuration 11.3s 11.3s ⚠️ +8ms
nodeModulesSize 80.9 MB 80.9 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.216 2.262 ⚠️ +0.05
/ avg req/sec 1127.93 1105.44 ⚠️ -22.49
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.453 1.445 -0.01
/error-in-render avg req/sec 1720.92 1729.88 +8.96
Client Bundles (main, webpack, commons)
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
index.html gzip 614 B 614 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
buildDuration 13.5s 13.2s -258ms
nodeModulesSize 80.9 MB 80.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: c12e466

timneutkens
timneutkens reviewed Jan 11, 2021
View reviewed changes
examples/with-graphql-hooks/components/#app.js# Outdated
@@ -0,0 +1,44 @@
export default function App({ children }) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file seems to be accidentally committed 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it.

@ludofischer
fix(examples): make with-graphql-hooks run correctly again
12e9393 
Fixes #20474

* Switch API url to working URL used in apollo example
* Update deps
* Move styled jsx out of the way to avoid demonstrating too many
  unfamiliar concepts at once

dev, build and start work now.
@ijjk
Copy link
Member

ijjk commented Jan 11, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
buildDuration 10.3s 9.9s -340ms
nodeModulesSize 80.8 MB 80.9 MB ⚠️ +10.1 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.03 2.016 -0.01
/ avg req/sec 1231.76 1239.78 +8.02
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.283 1.249 -0.03
/error-in-render avg req/sec 1949.19 2001.7 +52.51
Client Bundles (main, webpack, commons)
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
index.html gzip 614 B 614 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
buildDuration 12s 11.9s -99ms
nodeModulesSize 80.9 MB 80.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: 12e9393

@timneutkens
Copy link
Member

Thanks!

@ijjk
Copy link
Member

ijjk commented Jan 11, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
buildDuration 12.1s 12.3s ⚠️ +142ms
nodeModulesSize 80.9 MB 80.9 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.528 2.491 -0.04
/ avg req/sec 988.76 1003.62 +14.86
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.697 1.771 ⚠️ +0.07
/error-in-render avg req/sec 1472.81 1411.84 ⚠️ -60.97
Client Bundles (main, webpack, commons)
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
index.html gzip 614 B 614 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
buildDuration 14.5s 14.5s -6ms
nodeModulesSize 80.9 MB 80.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary ludofischer/next.js fix-with-graphql-hooks Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: 9f1e57b

@kodiakhq kodiakhq bot merged commit b3a6313 into vercel:canary Jan 11, 2021
@ludofischer ludofischer deleted the fix-with-graphql-hooks branch January 11, 2021 16:20
@leerob leerob mentioned this pull request Feb 7, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example with-graphql-hooks broken request
3 participants
@ludofischer @ijjk @timneutkens