Update PostCSS plugin list in README #20956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giraffesyo
requested review from
chibicode,
ijjk,
lfades,
Timer and
timneutkens
as code owners
giraffesyo
changed the title
Stats from current PRDefault Server Mode (Increase detected
|
| vercel/next.js canary | giraffesyo/next.js patch-2 | Change | |
|---|---|---|---|
| buildDuration | 8.1s | 8s | -111ms |
| nodeModulesSize | 80.9 MB | 80.9 MB | ✓ |
Page Load Tests Overall increase ✓
| vercel/next.js canary | giraffesyo/next.js patch-2 | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 1.705 | 1.627 | -0.08 |
| / avg req/sec | 1466.35 | 1536.27 | +69.92 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.052 | 1.042 | -0.01 |
| /error-in-render avg req/sec | 2376.25 | 2400.3 | +24.05 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | giraffesyo/next.js patch-2 | Change | |
|---|---|---|---|
| 677f882d2ed8..89aa.js gzip | 13.1 kB | 13.1 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-dba4ec1..27c0.js gzip | 6.63 kB | 6.63 kB | ✓ |
| webpack-50be..df5b.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | giraffesyo/next.js patch-2 | Change | |
|---|---|---|---|
| polyfills-81..14d7.js gzip | 31.2 kB | 31.2 kB | ✓ |
| Overall change | 31.2 kB | 31.2 kB | ✓ |
Client Pages
| vercel/next.js canary | giraffesyo/next.js patch-2 | Change | |
|---|---|---|---|
| _app-b6fc6bc..222c.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-e2ffa..0f3f.js gzip | 3.46 kB | 3.46 kB | ✓ |
| hooks-010c20..8411.js gzip | 887 B | 887 B | ✓ |
| index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
| link-d979103..c5ff.js gzip | 1.64 kB | 1.64 kB | ✓ |
| routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
| withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
| Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | giraffesyo/next.js patch-2 | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 323 B | 323 B | ✓ |
| Overall change | 323 B | 323 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | giraffesyo/next.js patch-2 | Change | |
|---|---|---|---|
| index.html gzip | 614 B | 614 B | ✓ |
| link.html gzip | 619 B | 619 B | ✓ |
| withRouter.html gzip | 606 B | 606 B | ✓ |
| Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode
General
| vercel/next.js canary | giraffesyo/next.js patch-2 | Change | |
|---|---|---|---|
| buildDuration | 9.9s | 9.9s | -3ms |
| nodeModulesSize | 80.9 MB | 80.9 MB | ✓ |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | giraffesyo/next.js patch-2 | Change | |
|---|---|---|---|
| 677f882d2ed8..89aa.js gzip | 13.1 kB | 13.1 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-dba4ec1..27c0.js gzip | 6.63 kB | 6.63 kB | ✓ |
| webpack-50be..df5b.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | giraffesyo/next.js patch-2 | Change | |
|---|---|---|---|
| polyfills-81..14d7.js gzip | 31.2 kB | 31.2 kB | ✓ |
| Overall change | 31.2 kB | 31.2 kB | ✓ |
Client Pages
| vercel/next.js canary | giraffesyo/next.js patch-2 | Change | |
|---|---|---|---|
| _app-b6fc6bc..222c.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-e2ffa..0f3f.js gzip | 3.46 kB | 3.46 kB | ✓ |
| hooks-010c20..8411.js gzip | 887 B | 887 B | ✓ |
| index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
| link-d979103..c5ff.js gzip | 1.64 kB | 1.64 kB | ✓ |
| routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
| withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
| Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | giraffesyo/next.js patch-2 | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 323 B | 323 B | ✓ |
| Overall change | 323 B | 323 B | ✓ |
Serverless bundles
| vercel/next.js canary | giraffesyo/next.js patch-2 | Change | |
|---|---|---|---|
| _error.js | 1 MB | 1 MB | ✓ |
| 404.html | 2.67 kB | 2.67 kB | ✓ |
| hooks.html | 1.92 kB | 1.92 kB | ✓ |
| index.js | 1 MB | 1 MB | ✓ |
| link.js | 1.06 MB | 1.06 MB | ✓ |
| routerDirect.js | 1.05 MB | 1.05 MB | ✓ |
| withRouter.js | 1.05 MB | 1.05 MB | ✓ |
| Overall change | 5.18 MB | 5.18 MB | ✓ |
timneutkens
approved these changes
Jan 11, 2021
|
Thanks! |
|
I’m not quite sure about this change. Using the |
|
Hey @kripod, this PR didn't update the list of packages in use in the example. That was updated in #19278. I believe the intention is that the install instructions in the tailwindcss docs recommend installing |
|
Hello @giraffesyo, thank you for pointing this out. My comment should possibly be addressed to Tailwind CSS maintainers, then. |
|
@kripod No problem. I took a look over at |
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 22, 2021
I realized while looking over this that the `autoprefixer` plugin isn't being used by postcss because it's not included in the `postcss.config.js`. Additionally, since `postcss-preset-env` doesn't support PostCSS 8 yet, and it includes PostCSS 7 as a dependency, I've removed that package. There is an open issue to add PostCSS 8 support to `postcss-preset-env` [here](csstools/postcss-preset-env#191). @kripod's comments on my other PR #20956 are what prompted me to check this out. On a side note, it looks like all the CMS examples use Tailwind CSS v1 still, so that's something someone (possibly myself) could tackle later.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readme on this example mentioned plugins that aren't part of the example anymore since it was updated for v2. This PR updates the list of PostCSS plugins.