Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent unpredictable dependency hosting by explicitly resolve module path on webpack.ProvidePlugin #20971

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Prevent unpredictable dependency hosting by explicitly resolve module path on webpack.ProvidePlugin #20971

merged 1 commit into from
Jan 11, 2021

Commits on Jan 11, 2021

  1. Handle Plug'n'Play properly while using webpack.ProvidePlugin 

    ProvidePlugin replaces certain identifiers with another modules. As a
result, 'buffer' and 'process' modules are added as implicit
dependencies to all Next.js plugins. Which is OK for "node_modules"
strategy, but problematic with "Plug'n'Play" strategy.

This patch let Next.js properly handles such cases with Yarn PnP mode
and PNPM's PnP mode.

References:
  nextauthjs/next-auth#1034
    @simnalamburt
    simnalamburt committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    06c8ec8 View commit details
    Browse the repository at this point in the history