Minimal mode normalizing #21083

ijjk · 2021-01-13T20:53:34Z

This ensures normalizing is working as expected in minimal mode

…alizing

ijjk · 2021-01-13T21:03:41Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
buildDuration	11.4s	11.5s	⚠️ +97ms
nodeModulesSize	80.9 MB	80.9 MB	⚠️ +1.16 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.536	2.531	0
/ avg req/sec	985.69	987.89	+2.2
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.72	1.7	-0.02
/error-in-render avg req/sec	1453.17	1470.67	+17.5

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
677f882d2ed8..b025.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e66dcae..6635.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
index.html gzip	615 B	615 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
buildDuration	13.5s	13.8s	⚠️ +321ms
nodeModulesSize	80.9 MB	80.9 MB	⚠️ +1.16 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
677f882d2ed8..b025.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e66dcae..6635.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.18 MB	5.18 MB	✓

Commit: feac982

ijjk · 2021-01-16T15:28:29Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
buildDuration	9.5s	9.7s	⚠️ +217ms
nodeModulesSize	77.5 MB	77.5 MB	⚠️ +1.16 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.977	1.921	-0.06
/ avg req/sec	1264.27	1301.55	+37.28
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.235	1.221	-0.01
/error-in-render avg req/sec	2024.6	2046.73	+22.13

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
677f882d2ed8..43e3.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-712e20f..aa05.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
polyfills-af..9390.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
index.html gzip	615 B	615 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
buildDuration	11.4s	11.5s	⚠️ +96ms
nodeModulesSize	77.5 MB	77.5 MB	⚠️ +1.16 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
677f882d2ed8..43e3.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-712e20f..aa05.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
polyfills-af..9390.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	ijjk/next.js minimal-mode-normalizing	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.18 MB	5.18 MB	✓

Commit: 7554451

ijjk added 9 commits January 11, 2021 13:03

add logs

3c283f8

Merge remote-tracking branch 'upstream/canary' into minimal-mode-norm…

77b53de

…alizing

log route-matches

b7813ed

Save changes and test

d0b621e

Merge remote-tracking branch 'upstream/canary' into minimal-mode-norm…

cc4f178

…alizing

Prioritize matched-path locale

5d8d0f1

Ensure rewrite params are normalized

6d77247

Remove extra logs

977d98a

Merge remote-tracking branch 'upstream/canary' into minimal-mode-norm…

feac982

…alizing

ijjk added the type: next label Jan 13, 2021

ijjk marked this pull request as ready for review January 15, 2021 16:39

ijjk requested review from lfades, Timer and timneutkens as code owners January 15, 2021 16:39

timneutkens approved these changes Jan 16, 2021

View reviewed changes

Merge branch 'canary' into minimal-mode-normalizing

7554451

timneutkens merged commit cfa9326 into vercel:canary Jan 16, 2021

timneutkens deleted the minimal-mode-normalizing branch January 16, 2021 15:46

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minimal mode normalizing #21083

Minimal mode normalizing #21083

ijjk commented Jan 13, 2021

ijjk commented Jan 13, 2021

ijjk commented Jan 16, 2021

Minimal mode normalizing #21083

Minimal mode normalizing #21083

Conversation

ijjk commented Jan 13, 2021

ijjk commented Jan 13, 2021

Stats from current PR

ijjk commented Jan 16, 2021

Stats from current PR