Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add types to name-default-components.ts #21291

Merged
merged 9 commits into from
Jan 26, 2021
Merged

refactor: add types to name-default-components.ts #21291

merged 9 commits into from
Jan 26, 2021

Conversation

tarunama
Copy link
Contributor

@tarunama tarunama commented Jan 18, 2021 •
edited
Loading

  • Add.type to variables and function, arguments

@ijjk
Copy link
Member

ijjk commented Jan 18, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
buildDuration 8.5s 8.5s -36ms
nodeModulesSize 77.6 MB 77.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.696 1.624 -0.07
/ avg req/sec 1474.39 1539.43 +65.04
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.117 1.08 -0.04
/error-in-render avg req/sec 2237.4 2313.9 +76.5
Client Bundles (main, webpack, commons)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9e3e4e6..2023.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
index.html gzip 614 B 614 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
buildDuration 10.6s 10.1s -475ms
nodeModulesSize 77.6 MB 77.6 MB -10 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9e3e4e6..2023.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
buildDuration 10.6s 10.8s ⚠️ +166ms
nodeModulesSize 77.6 MB 77.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.745 1.631 -0.11
/ avg req/sec 1432.3 1532.67 +100.37
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.131 1.092 -0.04
/error-in-render avg req/sec 2210.27 2290.36 +80.09
Client Bundles (main, webpack, commons)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
597-3bd7d6bd..868b.js gzip 13 kB 13 kB ✓
778-d412f8e7..3ee1.js gzip 6.56 kB 6.56 kB ✓
838-adcbad39..6e83.js gzip 31.1 kB 31.1 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-6a6a792..6877.js gzip 96 B 96 B ✓
webpack-e302..54e9.js gzip 954 B 954 B ✓
Overall change 91 kB 91 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
polyfills-a0..538c.js gzip 88 B 88 B ✓
Overall change 88 B 88 B ✓
Client Pages
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
index.html gzip 585 B 585 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "0bQ7XQR2DwQsNLSQ4sk5o",
+        "buildId": "_EdB091wYzifuUsSCuMcp",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/0bQ7XQR2DwQsNLSQ4sk5o/_buildManifest.js"
+      src="/_next/static/_EdB091wYzifuUsSCuMcp/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/0bQ7XQR2DwQsNLSQ4sk5o/_ssgManifest.js"
+      src="/_next/static/_EdB091wYzifuUsSCuMcp/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "0bQ7XQR2DwQsNLSQ4sk5o",
+        "buildId": "_EdB091wYzifuUsSCuMcp",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/0bQ7XQR2DwQsNLSQ4sk5o/_buildManifest.js"
+      src="/_next/static/_EdB091wYzifuUsSCuMcp/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/0bQ7XQR2DwQsNLSQ4sk5o/_ssgManifest.js"
+      src="/_next/static/_EdB091wYzifuUsSCuMcp/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "0bQ7XQR2DwQsNLSQ4sk5o",
+        "buildId": "_EdB091wYzifuUsSCuMcp",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/0bQ7XQR2DwQsNLSQ4sk5o/_buildManifest.js"
+      src="/_next/static/_EdB091wYzifuUsSCuMcp/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/0bQ7XQR2DwQsNLSQ4sk5o/_ssgManifest.js"
+      src="/_next/static/_EdB091wYzifuUsSCuMcp/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 4050f6d

tarunama
tarunama commented Jan 19, 2021
View reviewed changes
packages/next-codemod/transforms/name-default-component.ts Outdated

const returnsJSX = (node) =>
const isJSX = (node): boolean =>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change variable name for readability.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

returnsJSX is correct here. Note that return is searched for first: .find(j.ReturnStatement)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see ! Thank you !

@ijjk
Copy link
Member

ijjk commented Jan 19, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
buildDuration 10.7s 11s ⚠️ +337ms
nodeModulesSize 77.6 MB 77.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.177 2.164 -0.01
/ avg req/sec 1148.2 1155.32 +7.12
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.4 1.374 -0.03
/error-in-render avg req/sec 1785.61 1820.07 +34.46
Client Bundles (main, webpack, commons)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9e3e4e6..2023.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
index.html gzip 614 B 614 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
buildDuration 12.7s 12.5s -187ms
nodeModulesSize 77.6 MB 77.6 MB -10 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9e3e4e6..2023.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
buildDuration 13.7s 13.5s -112ms
nodeModulesSize 77.6 MB 77.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.243 2.242 0
/ avg req/sec 1114.41 1115.05 +0.64
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.479 1.364 -0.11
/error-in-render avg req/sec 1690.57 1833.35 +142.78
Client Bundles (main, webpack, commons)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
597-3bd7d6bd..868b.js gzip 13 kB 13 kB ✓
778-d412f8e7..3ee1.js gzip 6.56 kB 6.56 kB ✓
838-adcbad39..6e83.js gzip 31.1 kB 31.1 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-6a6a792..6877.js gzip 96 B 96 B ✓
webpack-e302..54e9.js gzip 954 B 954 B ✓
Overall change 91 kB 91 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
polyfills-a0..538c.js gzip 88 B 88 B ✓
Overall change 88 B 88 B ✓
Client Pages
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
index.html gzip 585 B 585 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "hvQDnDwWrsSZIeUhkZRQ_",
+        "buildId": "Ui0iAnN8riJBxkcwCwjKA",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/hvQDnDwWrsSZIeUhkZRQ_/_buildManifest.js"
+      src="/_next/static/Ui0iAnN8riJBxkcwCwjKA/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/hvQDnDwWrsSZIeUhkZRQ_/_ssgManifest.js"
+      src="/_next/static/Ui0iAnN8riJBxkcwCwjKA/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "hvQDnDwWrsSZIeUhkZRQ_",
+        "buildId": "Ui0iAnN8riJBxkcwCwjKA",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/hvQDnDwWrsSZIeUhkZRQ_/_buildManifest.js"
+      src="/_next/static/Ui0iAnN8riJBxkcwCwjKA/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/hvQDnDwWrsSZIeUhkZRQ_/_ssgManifest.js"
+      src="/_next/static/Ui0iAnN8riJBxkcwCwjKA/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "hvQDnDwWrsSZIeUhkZRQ_",
+        "buildId": "Ui0iAnN8riJBxkcwCwjKA",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/hvQDnDwWrsSZIeUhkZRQ_/_buildManifest.js"
+      src="/_next/static/Ui0iAnN8riJBxkcwCwjKA/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/hvQDnDwWrsSZIeUhkZRQ_/_ssgManifest.js"
+      src="/_next/static/Ui0iAnN8riJBxkcwCwjKA/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 8241c80

@ijjk
Copy link
Member

ijjk commented Jan 21, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
buildDuration 11s 11.4s ⚠️ +372ms
nodeModulesSize 73.3 MB 73.3 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.332 2.299 -0.03
/ avg req/sec 1071.84 1087.53 +15.69
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.616 1.62 0
/error-in-render avg req/sec 1546.73 1543.3 ⚠️ -3.43
Client Bundles (main, webpack, commons)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
index.html gzip 616 B 616 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 609 B 609 B ✓
Overall change 1.85 kB 1.85 kB ✓
Serverless Mode
General
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
buildDuration 13s 13s ⚠️ +29ms
nodeModulesSize 73.3 MB 73.3 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
buildDuration 13.7s 13.7s ⚠️ +30ms
nodeModulesSize 73.3 MB 73.3 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.344 2.212 -0.13
/ avg req/sec 1066.72 1130.38 +63.66
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.596 1.524 -0.07
/error-in-render avg req/sec 1566.35 1640.87 +74.52
Client Bundles (main, webpack, commons)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
597-3bd7d6bd..868b.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
index.html gzip 585 B 585 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 579 B 579 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "-ToBqVi92M7wpcBt97ZfO",
+        "buildId": "8zA4BaNnmS4cNqPIp0sYY",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/-ToBqVi92M7wpcBt97ZfO/_buildManifest.js"
+      src="/_next/static/8zA4BaNnmS4cNqPIp0sYY/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/-ToBqVi92M7wpcBt97ZfO/_ssgManifest.js"
+      src="/_next/static/8zA4BaNnmS4cNqPIp0sYY/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "-ToBqVi92M7wpcBt97ZfO",
+        "buildId": "8zA4BaNnmS4cNqPIp0sYY",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/-ToBqVi92M7wpcBt97ZfO/_buildManifest.js"
+      src="/_next/static/8zA4BaNnmS4cNqPIp0sYY/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/-ToBqVi92M7wpcBt97ZfO/_ssgManifest.js"
+      src="/_next/static/8zA4BaNnmS4cNqPIp0sYY/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "-ToBqVi92M7wpcBt97ZfO",
+        "buildId": "8zA4BaNnmS4cNqPIp0sYY",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/-ToBqVi92M7wpcBt97ZfO/_buildManifest.js"
+      src="/_next/static/8zA4BaNnmS4cNqPIp0sYY/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/-ToBqVi92M7wpcBt97ZfO/_ssgManifest.js"
+      src="/_next/static/8zA4BaNnmS4cNqPIp0sYY/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 1bf0ab7

@ijjk
Copy link
Member

ijjk commented Jan 22, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
buildDuration 9.8s 9.4s -461ms
nodeModulesSize 73.3 MB 73.3 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.988 1.925 -0.06
/ avg req/sec 1257.43 1298.53 +41.1
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.278 1.18 -0.1
/error-in-render avg req/sec 1955.58 2119.14 +163.56
Client Bundles (main, webpack, commons)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
677f882d2ed8..bb74.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
buildDuration 11.3s 11.7s ⚠️ +372ms
nodeModulesSize 73.3 MB 73.3 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
677f882d2ed8..bb74.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
buildDuration 11.8s 11.7s -105ms
nodeModulesSize 73.3 MB 73.3 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.896 1.958 ⚠️ +0.06
/ avg req/sec 1318.58 1276.64 ⚠️ -41.94
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.166 1.195 ⚠️ +0.03
/error-in-render avg req/sec 2143.92 2091.85 ⚠️ -52.07
Client Bundles (main, webpack, commons)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
597-168f5a87..2380.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
index.html gzip 588 B 588 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 583 B 583 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "p1K6W7ioQCqvKzJ82yDRV",
+        "buildId": "6QOfYQonbwcMv-g10euzT",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/p1K6W7ioQCqvKzJ82yDRV/_buildManifest.js"
+      src="/_next/static/6QOfYQonbwcMv-g10euzT/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/p1K6W7ioQCqvKzJ82yDRV/_ssgManifest.js"
+      src="/_next/static/6QOfYQonbwcMv-g10euzT/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "p1K6W7ioQCqvKzJ82yDRV",
+        "buildId": "6QOfYQonbwcMv-g10euzT",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/p1K6W7ioQCqvKzJ82yDRV/_buildManifest.js"
+      src="/_next/static/6QOfYQonbwcMv-g10euzT/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/p1K6W7ioQCqvKzJ82yDRV/_ssgManifest.js"
+      src="/_next/static/6QOfYQonbwcMv-g10euzT/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "p1K6W7ioQCqvKzJ82yDRV",
+        "buildId": "6QOfYQonbwcMv-g10euzT",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/p1K6W7ioQCqvKzJ82yDRV/_buildManifest.js"
+      src="/_next/static/6QOfYQonbwcMv-g10euzT/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/p1K6W7ioQCqvKzJ82yDRV/_ssgManifest.js"
+      src="/_next/static/6QOfYQonbwcMv-g10euzT/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 5c1cbfd

@ijjk
Copy link
Member

ijjk commented Jan 26, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
buildDuration 8.8s 8.8s -24ms
nodeModulesSize 74.9 MB 74.9 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.744 1.765 ⚠️ +0.02
/ avg req/sec 1433.82 1416.24 ⚠️ -17.58
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.091 1.111 ⚠️ +0.02
/error-in-render avg req/sec 2291.5 2250.22 ⚠️ -41.28
Client Bundles (main, webpack, commons)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
buildDuration 10.9s 10.4s -449ms
nodeModulesSize 74.9 MB 74.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
buildDuration 10.7s 10.7s ⚠️ +27ms
nodeModulesSize 74.9 MB 74.9 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.728 1.735 ⚠️ +0.01
/ avg req/sec 1447.16 1441 ⚠️ -6.16
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.118 1.107 -0.01
/error-in-render avg req/sec 2235.43 2258.81 +23.38
Client Bundles (main, webpack, commons)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
597-c48889ef..1870.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
index.html gzip 587 B 587 B ✓
link.html gzip 591 B 591 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "Hfwakq5sApYQezBVKe_D1",
+        "buildId": "CXUkiT1gGnfyJ1Zllj3XL",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Hfwakq5sApYQezBVKe_D1/_buildManifest.js"
+      src="/_next/static/CXUkiT1gGnfyJ1Zllj3XL/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Hfwakq5sApYQezBVKe_D1/_ssgManifest.js"
+      src="/_next/static/CXUkiT1gGnfyJ1Zllj3XL/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "Hfwakq5sApYQezBVKe_D1",
+        "buildId": "CXUkiT1gGnfyJ1Zllj3XL",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Hfwakq5sApYQezBVKe_D1/_buildManifest.js"
+      src="/_next/static/CXUkiT1gGnfyJ1Zllj3XL/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Hfwakq5sApYQezBVKe_D1/_ssgManifest.js"
+      src="/_next/static/CXUkiT1gGnfyJ1Zllj3XL/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "Hfwakq5sApYQezBVKe_D1",
+        "buildId": "CXUkiT1gGnfyJ1Zllj3XL",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Hfwakq5sApYQezBVKe_D1/_buildManifest.js"
+      src="/_next/static/CXUkiT1gGnfyJ1Zllj3XL/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Hfwakq5sApYQezBVKe_D1/_ssgManifest.js"
+      src="/_next/static/CXUkiT1gGnfyJ1Zllj3XL/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: dc9166b

@ijjk
Copy link
Member

ijjk commented Jan 26, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
buildDuration 11.1s 10.3s -745ms
nodeModulesSize 74.9 MB 74.9 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.107 2.13 ⚠️ +0.02
/ avg req/sec 1186.8 1173.51 ⚠️ -13.29
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.428 1.387 -0.04
/error-in-render avg req/sec 1750.32 1802 +51.68
Client Bundles (main, webpack, commons)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
buildDuration 12.6s 12.6s -27ms
nodeModulesSize 74.9 MB 74.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
buildDuration 13.2s 12.7s -481ms
nodeModulesSize 74.9 MB 74.9 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.12 2.177 ⚠️ +0.06
/ avg req/sec 1179.18 1148.38 ⚠️ -30.8
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.384 1.366 -0.02
/error-in-render avg req/sec 1805.73 1830.24 +24.51
Client Bundles (main, webpack, commons)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
597-c48889ef..1870.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary tarunama/next.js refactor/add-types-to-name-default-components-ts Change
index.html gzip 587 B 587 B ✓
link.html gzip 591 B 591 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "S8vV2Nd5cUx_EDYcgv3nj",
+        "buildId": "3kUQ_VB4y0fcy-paF5zj8",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/S8vV2Nd5cUx_EDYcgv3nj/_buildManifest.js"
+      src="/_next/static/3kUQ_VB4y0fcy-paF5zj8/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/S8vV2Nd5cUx_EDYcgv3nj/_ssgManifest.js"
+      src="/_next/static/3kUQ_VB4y0fcy-paF5zj8/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "S8vV2Nd5cUx_EDYcgv3nj",
+        "buildId": "3kUQ_VB4y0fcy-paF5zj8",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/S8vV2Nd5cUx_EDYcgv3nj/_buildManifest.js"
+      src="/_next/static/3kUQ_VB4y0fcy-paF5zj8/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/S8vV2Nd5cUx_EDYcgv3nj/_ssgManifest.js"
+      src="/_next/static/3kUQ_VB4y0fcy-paF5zj8/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "S8vV2Nd5cUx_EDYcgv3nj",
+        "buildId": "3kUQ_VB4y0fcy-paF5zj8",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/S8vV2Nd5cUx_EDYcgv3nj/_buildManifest.js"
+      src="/_next/static/3kUQ_VB4y0fcy-paF5zj8/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/S8vV2Nd5cUx_EDYcgv3nj/_ssgManifest.js"
+      src="/_next/static/3kUQ_VB4y0fcy-paF5zj8/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: c1df8b8

@kodiakhq kodiakhq bot merged commit b40fd6c into vercel:canary Jan 26, 2021
@tarunama tarunama deleted the refactor/add-types-to-name-default-components-ts branch January 27, 2021 02:02
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarunama @ijjk @timneutkens